From nobody Fri Nov 7 02:11:44 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=163.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1546415011425309.91263902100775; Tue, 1 Jan 2019 23:43:31 -0800 (PST) Received: from localhost ([127.0.0.1]:42585 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gebBZ-0003qt-HU for importer@patchew.org; Wed, 02 Jan 2019 02:43:29 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43843) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gebAh-0003Kc-3k for qemu-devel@nongnu.org; Wed, 02 Jan 2019 02:42:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gebAd-0003xa-Qm for qemu-devel@nongnu.org; Wed, 02 Jan 2019 02:42:34 -0500 Received: from m12-18.163.com ([220.181.12.18]:53723) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gebAd-0003vT-47 for qemu-devel@nongnu.org; Wed, 02 Jan 2019 02:42:31 -0500 Received: from localhost.localdomain (unknown [183.134.169.2]) by smtp14 (Coremail) with SMTP id EsCowAA3f21SayxcRM0JHw--.50850S2; Wed, 02 Jan 2019 15:42:12 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=6fXUWSMqgWIhcplfLG 9Cu5GRmOQhbkJJDBbwttP7V5o=; b=pJ51JJ0JD/1hRHQJBi5BMkZ/vGwKZb4A8o 2ibn0SzeTRUpoztrnmTbsqwTkTMS3d5Kr8D/FMWvX0w5pDHqcHETQz4yaqaFiqcc 0E+8Yi35zOTkTKulwVOPKJnud+z3oEYrEGGr/azooQdsIfg68QgtRpMUUPqDyiNb 6zx0SLhBA= From: Li Qiang To: ehabkost@redhat.com, richard.henderson@linaro.org, imammedo@redhat.com, cota@braap.org, philmd@redhat.com, pbonzini@redhat.com Date: Tue, 1 Jan 2019 23:41:14 -0800 Message-Id: <20190102074114.26988-1-liq3ea@163.com> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: EsCowAA3f21SayxcRM0JHw--.50850S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7GF1fJFy5Xr4kJrykJF1UZFb_yoWxZwb_A3 WSvF1kWr18u3W7Kr1jy3WfZr1rG3sYvF1Yyw4Iya4kAw43Jwn0k3yv9a4xXa1fW3y3AFy3 trZIyFyYyF17JjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUURBT3UUUUU== X-Originating-IP: [183.134.169.2] X-CM-SenderInfo: 5oltjvrd6rljoofrz/xtbBZgYwbVaDzkuwcwABsv X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 220.181.12.18 Subject: [Qemu-devel] [PATCH] qom: cpu: destroy work_mutex in cpu_common_finalize X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Li Qiang , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Commit 376692b9dc6(cpus: protect work list with work_mutex) initialize a work_mutex in cpu_common_initfn, however forget to destroy it. This will cause resource leak when hotunplug cpu or hotplug cpu fails. Signed-off-by: Li Qiang Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- qom/cpu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qom/cpu.c b/qom/cpu.c index 9ad1372d57..367ebf9d61 100644 --- a/qom/cpu.c +++ b/qom/cpu.c @@ -380,6 +380,9 @@ static void cpu_common_initfn(Object *obj) =20 static void cpu_common_finalize(Object *obj) { + CPUState *cpu =3D CPU(obj); + + qemu_mutex_destroy(&cpu->work_mutex); } =20 static int64_t cpu_common_get_arch_id(CPUState *cpu) --=20 2.17.1