From nobody Fri Nov 7 03:51:41 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1545473516765234.1030951386541; Sat, 22 Dec 2018 02:11:56 -0800 (PST) Received: from localhost ([::1]:35501 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gaeG8-0005kL-ER for importer@patchew.org; Sat, 22 Dec 2018 05:11:52 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41836) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gadwN-0006Zg-N8 for qemu-devel@nongnu.org; Sat, 22 Dec 2018 04:51:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gadwM-0006kq-Qb for qemu-devel@nongnu.org; Sat, 22 Dec 2018 04:51:27 -0500 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:35006) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gadwM-0006do-KE for qemu-devel@nongnu.org; Sat, 22 Dec 2018 04:51:26 -0500 Received: by mail-wr1-x441.google.com with SMTP id 96so7530874wrb.2 for ; Sat, 22 Dec 2018 01:51:17 -0800 (PST) Received: from localhost.localdomain ([176.228.155.165]) by smtp.gmail.com with ESMTPSA id s3sm9557371wmj.23.2018.12.22.01.51.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Dec 2018 01:51:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=46yTJGRUMonQjaBI5LtgoPoU4gPLXELTxYuktuqxajY=; b=i0FOrwxU/nbjiB0A5jkRGprRs/234JfZW9pX6H05D2AEaAUQo7IKLHBmvWuC0u9/he Jbb2SIIhcfu5kqDixXR1yPLaPCmCkwLwVmbxGE/tN3sGW1jATYJ0If0MUDbfiASeRCFt OW3X8OQDI+iOcSs18TkzAxIu7Hb6qvr2SBROF7h/la0lYaUiq7wck0pX0osyDCutv2D3 9qfEmmQ8vXqEvorrTI3pQU1qFSzylfJBDf6PnRN/LyKoy5DSGmZzFSLIWidOsSdMI5M2 YGfcRUQxnMlz3e9gcei/5YqWBM/y8zIyzf8E7D8DdHIUZAnFrKyoIYDF343ZDDYt8V98 qczw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=46yTJGRUMonQjaBI5LtgoPoU4gPLXELTxYuktuqxajY=; b=G0FscdjJqUVpa4MuWvnQayOw0skiA4ZjzVib+n3iv8aMFKY7CIIU/IQo89tNxT8mbX SCW/SzUofDjddosyt3W4l5AsCimE0N2cW2U52iAgaUtflLlYJ5vhK7ox3DDCbUHDDxNG iyXlM24pGhPwuBw2DxUbEBpu2HSQt7yC2X3XHFhFzA5w03mx/Na22gvFR883slhiQKU6 0pN+FB16ZlMW7AvHvoDWkghZcz+JhatuL1DIgJq2P6FOG9EsNwMVBpMGh0BOiLNtx3iC wmjs6GN7RK3w8lvRsTcqALsuhXIN8BDuHQKjSCPrJpSfNzed1HRdON32o/dWhWqH84Jj ReLA== X-Gm-Message-State: AJcUukc2hAAh4WWPPxbiPioia95L/YI0GwHDtH92nSgwIhrPk4Uxeopt h7FvVCNf3JjP9I1RwEVcIQ74N9pD X-Google-Smtp-Source: ALg8bN4gXfP7w9hnw5i8HmgaV6MZmeHv6VoAGvxzuPTtcvNVVZQWf8YGT0PvridGHIssEPO/cy5w6g== X-Received: by 2002:adf:f390:: with SMTP id m16mr5522898wro.71.1545472276816; Sat, 22 Dec 2018 01:51:16 -0800 (PST) From: Marcel Apfelbaum To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Sat, 22 Dec 2018 11:50:31 +0200 Message-Id: <20181222095036.29743-27-marcel.apfelbaum@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181222095036.29743-1-marcel.apfelbaum@gmail.com> References: <20181222095036.29743-1-marcel.apfelbaum@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::441 Subject: [Qemu-devel] [PATCH PULL 26/31] rdma: check num_sge does not exceed MAX_SGE X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yuval.shaia@oracle.com, pjp@fedoraproject.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Prasad J Pandit rdma back-end has scatter/gather array ibv_sge[MAX_SGE=3D4] set to have 4 elements. A guest could send a 'PvrdmaSqWqe' ring element with 'num_sge' set to > MAX_SGE, which may lead to OOB access issue. Add check to avoid it. Reported-by: Saar Amar Signed-off-by: Prasad J Pandit Reviewed-by: Yuval Shaia Signed-off-by: Marcel Apfelbaum --- hw/rdma/rdma_backend.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c index ae1e4dcb29..bd4710d16f 100644 --- a/hw/rdma/rdma_backend.c +++ b/hw/rdma/rdma_backend.c @@ -476,9 +476,9 @@ void rdma_backend_post_send(RdmaBackendDev *backend_dev, } =20 pr_dbg("num_sge=3D%d\n", num_sge); - if (!num_sge) { - pr_dbg("num_sge=3D0\n"); - complete_work(IBV_WC_GENERAL_ERR, VENDOR_ERR_NO_SGE, ctx); + if (!num_sge || num_sge > MAX_SGE) { + pr_dbg("invalid num_sge=3D%d\n", num_sge); + complete_work(IBV_WC_GENERAL_ERR, VENDOR_ERR_INV_NUM_SGE, ctx); return; } =20 @@ -603,9 +603,9 @@ void rdma_backend_post_recv(RdmaBackendDev *backend_dev, } =20 pr_dbg("num_sge=3D%d\n", num_sge); - if (!num_sge) { - pr_dbg("num_sge=3D0\n"); - complete_work(IBV_WC_GENERAL_ERR, VENDOR_ERR_NO_SGE, ctx); + if (!num_sge || num_sge > MAX_SGE) { + pr_dbg("invalid num_sge=3D%d\n", num_sge); + complete_work(IBV_WC_GENERAL_ERR, VENDOR_ERR_INV_NUM_SGE, ctx); return; } =20 --=20 2.17.1