From nobody Fri Nov 7 04:05:06 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1545473800711862.9176279056892; Sat, 22 Dec 2018 02:16:40 -0800 (PST) Received: from localhost ([::1]:41726 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gaeKl-0000vO-FQ for importer@patchew.org; Sat, 22 Dec 2018 05:16:39 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41849) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gadwN-0006Zp-UN for qemu-devel@nongnu.org; Sat, 22 Dec 2018 04:51:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gadwM-0006kw-S6 for qemu-devel@nongnu.org; Sat, 22 Dec 2018 04:51:27 -0500 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:36111) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gadwM-0006cq-Lj for qemu-devel@nongnu.org; Sat, 22 Dec 2018 04:51:26 -0500 Received: by mail-wm1-x341.google.com with SMTP id p6so7872160wmc.1 for ; Sat, 22 Dec 2018 01:51:16 -0800 (PST) Received: from localhost.localdomain ([176.228.155.165]) by smtp.gmail.com with ESMTPSA id s3sm9557371wmj.23.2018.12.22.01.51.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Dec 2018 01:51:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=9iR+hXjh8mxFOwqrXYzH1/P0rkkiaMRtIEVQvpnNQuc=; b=D8ayGRVO2o6eRQ+jiewpaX3kKMoS+PpqNWLOi0wV2KqUhne9ifZA2lf/am44yThL0M dYfRyyZHBVuTh+ot2L6JlSQsXjy76ZafFCAole/hZ0JqAVUZRQ9Ey+aY9q0hlu6V5IWx 7/YgvxUf7kEXRf4Kmi4Jp9gcOuuTIti6/gRa8RCVv/oeVJQ7EFgAJp1iIl5RhmiLyKDT qfAPTBhhpRV5RX1C5IHrfgdBphT6yF1hxsMdWokDXWPWZixytjBNdtGGY/sDmyuLyJ+F jcfGVSQqi8Bj7pTmVO+mJNnN3W9SCx/JHfLLXsFtt4fiaJZOKuL9z9Juphzt1goT0qbF X5YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9iR+hXjh8mxFOwqrXYzH1/P0rkkiaMRtIEVQvpnNQuc=; b=f0FcsYV9H3/V1SxSkdSjhZ/8r0rPIQOz83RmullNNc3W6fxKzHsELgJp7fhXMBdIGk akFCZKckhfUrg04OVIOu6oKy+X3/b2lDE/TjLHaMUzHEjtnsUoUI2QPGK/2PsOOxjID9 +Zt/6m/mqgGR0r37mhMQDlc/RtZ+G63O2Di5wTOUkOj4VfZ5l3Cm+QWcB9G7ljB9kpBc epdM7xCpkFxHzjjUc0jmDY0Q6ZfhQ45T9eeZJ94nSHAvt190mZNZ8rzSBXnDXWGR0ku3 2NZDN/PuYZY8c21DTtSvVI0eF+8EB3t4SzSMDp6U/3LfK1XpWQ+BXcjNN7Hq0jqQbc4q PZTg== X-Gm-Message-State: AJcUuke522qGJchnvXT9e0O+GTy69k6G7E4U6s1OiQRebbaGXwgvsx3V STrU7vj+xBgxI1rxIQ5ZqQgv41f+ X-Google-Smtp-Source: ALg8bN6i4FsByksTccsv3DQRtxWjehfq1fKacmINEslwF9jbk/g4ZM3Ywb7HVWfM5bbqNj/pd5MPnA== X-Received: by 2002:a1c:da92:: with SMTP id r140mr6199922wmg.136.1545472275470; Sat, 22 Dec 2018 01:51:15 -0800 (PST) From: Marcel Apfelbaum To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Sat, 22 Dec 2018 11:50:30 +0200 Message-Id: <20181222095036.29743-26-marcel.apfelbaum@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181222095036.29743-1-marcel.apfelbaum@gmail.com> References: <20181222095036.29743-1-marcel.apfelbaum@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 Subject: [Qemu-devel] [PATCH PULL 25/31] pvrdma: release device resources in case of an error X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yuval.shaia@oracle.com, pjp@fedoraproject.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Prasad J Pandit If during pvrdma device initialisation an error occurs, pvrdma_realize() does not release memory resources, leading to memory leakage. Reported-by: Li Qiang Signed-off-by: Prasad J Pandit Message-Id: <20181212175817.815-1-ppandit@redhat.com> Reviewed-by: Yuval Shaia Signed-off-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c index 23dc9926e3..64de16fb52 100644 --- a/hw/rdma/vmw/pvrdma_main.c +++ b/hw/rdma/vmw/pvrdma_main.c @@ -573,7 +573,7 @@ static void pvrdma_shutdown_notifier(Notifier *n, void = *opaque) =20 static void pvrdma_realize(PCIDevice *pdev, Error **errp) { - int rc; + int rc =3D 0; PVRDMADev *dev =3D PVRDMA_DEV(pdev); Object *memdev_root; bool ram_shared =3D false; @@ -649,6 +649,7 @@ static void pvrdma_realize(PCIDevice *pdev, Error **err= p) =20 out: if (rc) { + pvrdma_fini(pdev); error_append_hint(errp, "Device fail to load\n"); } } --=20 2.17.1