From nobody Tue Feb 10 02:55:25 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1545319320822266.066789931368; Thu, 20 Dec 2018 07:22:00 -0800 (PST) Received: from localhost ([::1]:38173 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ga099-0007RN-Bj for importer@patchew.org; Thu, 20 Dec 2018 10:21:59 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53421) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ga07n-0006lw-93 for qemu-devel@nongnu.org; Thu, 20 Dec 2018 10:20:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ga07k-00060Z-6d for qemu-devel@nongnu.org; Thu, 20 Dec 2018 10:20:35 -0500 Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]:40332) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ga07k-0005zO-0C for qemu-devel@nongnu.org; Thu, 20 Dec 2018 10:20:32 -0500 Received: by mail-ed1-x544.google.com with SMTP id g22so2055558edr.7 for ; Thu, 20 Dec 2018 07:20:31 -0800 (PST) Received: from mocramis-ultrabook.localdomain ([178.208.16.32]) by smtp.gmail.com with ESMTPSA id f35sm6606853edd.80.2018.12.20.07.20.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Dec 2018 07:20:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blade-group.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=H18RmlP2dIwZkeae7noniR82FbmEKq9yfjZ0miMoonY=; b=IrslB/1jG+hO2e9ehOQ9qy/ju1dKtedXN403KrPvZPKG0J9yh/LSxsTheGzojiOYOy q3jfR1tBNMM3L/pjU0DRh5xDlxXUZ6dPF0M/zwckWtdgMP2zfDDkSO96pkAlUUaw461A QjLxEB24AeAm5b/xR5u53SPVASevi9J8EcUUvaUtyj3WXxLJJmwmsgLgxf6i4KnJIvHT Fm0jLTZbH9vCBZSpXG76nHt5NUr5vH8TFNrwt37Yf7VPpWoR5JFxQmyQTcKartxga/U0 FvHAggX961GoVBD3xABYyHH1UFqgMLZFDuI9XUBjVbNO2OuA8fwakkebamJHA/Gjvtgo 9Cmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=H18RmlP2dIwZkeae7noniR82FbmEKq9yfjZ0miMoonY=; b=J3+mOiteML2Mo1j8PIJy4QMF2Iy+EFy1CcQ/pTlb7xrhMFEfWh4bPg4ZYzsjHt8nyN 2LMKX8qzjrshMqtQkmVOhrHokHA0BKpWmo5l3hKaKO9cxALeXU2ouwWs+2PBBp0xcilE x8bCEyiO5R0FXDz9K2HIJJQubcsCNc2YlD8tKYn8mNXjoge/Ppgoxg3JfgPwJbVHytO1 DZFQi1eDEsejKejrtQY7Xde3rBtH44/CYSWtshxsovntQviG1akL5VxGsMxej+CaHuzs aMocb4EnudciYO/8MIRCGdvrhp9nG2G0FXaR08gpd7BXrp10k/oHllWAdce9/zLo61af gWWg== X-Gm-Message-State: AA+aEWaAYOE4NhPstR22fu1o/ueKaajkeVLJeBKNIAWHGI72QbzFe349 TVp4wsJt+/KgCR2duskDvkmWnfNyVHU1zw== X-Google-Smtp-Source: AFSGD/VhFy30UtWM5XUYog08+T57QMI4J7kMEjRr+utJp+65ELfKN5IPk+okaGPui6xt0r5AaCBtBQ== X-Received: by 2002:a17:906:7087:: with SMTP id b7-v6mr19563725ejk.194.1545319230673; Thu, 20 Dec 2018 07:20:30 -0800 (PST) From: remy.noel@blade-group.com To: qemu-devel@nongnu.org Date: Thu, 20 Dec 2018 16:20:29 +0100 Message-Id: <20181220152030.28035-2-remy.noel@blade-group.com> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181220152030.28035-1-remy.noel@blade-group.com> References: <20181220152030.28035-1-remy.noel@blade-group.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::544 Subject: [Qemu-devel] [QEMU-devel][PATCH v4 1/2] aio-posix: Unregister fd from ctx epoll when removing fd_handler. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Remy Noel , Fam Zheng , "open list:Block I/O path" , Stefan Hajnoczi Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Remy Noel Cleaning the events will cause aio_epoll_update to unregister the fd. Otherwise, the fd is kept registered until it is destroyed. Signed-off-by: Remy Noel --- util/aio-posix.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/util/aio-posix.c b/util/aio-posix.c index 51c41ed3c9..a927319d2c 100644 --- a/util/aio-posix.c +++ b/util/aio-posix.c @@ -245,6 +245,9 @@ void aio_set_fd_handler(AioContext *ctx, QLIST_REMOVE(node, node); deleted =3D true; } + /* Clean events in order to unregister fd from the ctx epoll. */ + node->pfd.events =3D 0; + poll_disable_change =3D -!node->io_poll; } else { poll_disable_change =3D !io_poll - (node && !node->io_poll); --=20 2.19.2