From nobody Fri Nov 7 02:25:11 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1545184513134409.88125620943515; Tue, 18 Dec 2018 17:55:13 -0800 (PST) Received: from localhost ([::1]:57230 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZR4l-0001hv-97 for importer@patchew.org; Tue, 18 Dec 2018 20:55:07 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43352) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZR2d-0000E2-Cm for qemu-devel@nongnu.org; Tue, 18 Dec 2018 20:52:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZR2c-0004YS-Fr for qemu-devel@nongnu.org; Tue, 18 Dec 2018 20:52:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47940) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gZR2X-0004TY-9U; Tue, 18 Dec 2018 20:52:49 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7F588C050DEE; Wed, 19 Dec 2018 01:52:48 +0000 (UTC) Received: from probe.redhat.com (ovpn-124-24.rdu2.redhat.com [10.10.124.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0BD5D65978; Wed, 19 Dec 2018 01:52:46 +0000 (UTC) From: John Snow To: qemu-devel@nongnu.org, qemu-block@nongnu.org Date: Tue, 18 Dec 2018 20:52:29 -0500 Message-Id: <20181219015230.18652-5-jsnow@redhat.com> In-Reply-To: <20181219015230.18652-1-jsnow@redhat.com> References: <20181219015230.18652-1-jsnow@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 19 Dec 2018 01:52:48 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v4 4/5] iotests: implement pretty-print for log and qmp_log X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , vsementsov@virtuozzo.com, Markus Armbruster , Max Reitz , John Snow Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" If iotests have lines exceeding >998 characters long, git doesn't want to send it plaintext to the list. We can solve this by allowing the iotests to use pretty printed QMP output that we can match against instead. As a bonus, it's much nicer for human eyes too. --- tests/qemu-iotests/iotests.py | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 812302538d..d3c57e266f 100644 --- a/tests/qemu-iotests/iotests.py +++ b/tests/qemu-iotests/iotests.py @@ -284,12 +284,18 @@ def filter_img_info(output, filename): lines.append(line) return '\n'.join(lines) =20 -def log(msg, filters=3D[]): +def log(msg, filters=3D[], indent=3DNone): + '''Logs either a string message or a JSON serializable message (like Q= MP). + If indent is provided, JSON serializable messages are pretty-printed.'= '' for flt in filters: msg =3D flt(msg) if isinstance(msg, dict) or isinstance(msg, list): - sort_keys =3D not isinstance(msg, OrderedDict) - print(json.dumps(msg, sort_keys=3Dsort_keys)) + # Python < 3.4 needs to know not to add whitespace when pretty-pri= nting: + separators =3D (', ', ': ') if indent is None else (',', ': ') + # Don't sort if it's already sorted + do_sort =3D not isinstance(msg, OrderedDict) + print(json.dumps(msg, sort_keys=3Ddo_sort, + indent=3Dindent, separators=3Dseparators)) else: print(msg) =20 @@ -478,12 +484,12 @@ class VM(qtest.QEMUQtestMachine): result.append(filter_qmp_event(ev)) return result =20 - def qmp_log(self, cmd, filters=3D[], **kwargs): + def qmp_log(self, cmd, filters=3D[], indent=3DNone, **kwargs): full_cmd =3D OrderedDict({"execute": cmd, "arguments": ordered_kwargs(kwargs)}) - log(full_cmd, filters) + log(full_cmd, filters, indent=3Dindent) result =3D self.qmp(cmd, **kwargs) - log(result, filters) + log(result, filters, indent=3Dindent) return result =20 def run_job(self, job, auto_finalize=3DTrue, auto_dismiss=3DFalse): --=20 2.17.2