From nobody Tue Dec 16 11:04:44 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=oracle.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1545035447089682.6956174410208; Mon, 17 Dec 2018 00:30:47 -0800 (PST) Received: from localhost ([::1]:45457 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYoIP-00005f-B0 for importer@patchew.org; Mon, 17 Dec 2018 03:30:37 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYo0B-0002ZR-FF for qemu-devel@nongnu.org; Mon, 17 Dec 2018 03:11:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gYo08-0007oS-6f for qemu-devel@nongnu.org; Mon, 17 Dec 2018 03:11:47 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:36110) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gYo07-0007nW-TM for qemu-devel@nongnu.org; Mon, 17 Dec 2018 03:11:44 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wBH84BZn156551; Mon, 17 Dec 2018 08:11:42 GMT Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2120.oracle.com with ESMTP id 2pct8qm8jk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 17 Dec 2018 08:11:42 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id wBH8BfQG021992 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 17 Dec 2018 08:11:41 GMT Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id wBH8Bfda022350; Mon, 17 Dec 2018 08:11:41 GMT Received: from localhost.localdomain (/77.138.186.148) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 17 Dec 2018 00:11:40 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : in-reply-to : references; s=corp-2018-07-02; bh=Al0WFiFZOmzT5X9VecDtx5Wu+47zkub7g0Id8UbqhHI=; b=ouphjUnBArdJfubbAcp/0Edl6hbz7pgZxpNIPK6JptgkQB2Nva5ahGhvsEV0Jkr9f+ke lJZqmshR6QzJX4XZ2ElmWuz/IsC+GV02UiGUlKLSpiq3D3C/4AlYGDTmgQ8IkrrPEOzW 9vTuPma/CEigVT2wWOiVZOMWsuiodFjQ9XsqM0lWjdXWmdCk2tKK8yZLNiQ/+BR4D48C i/GTfUBLX6u18K0LMQWQ+omSbRjEi+GMUzEaP6LCA5gd70UabLM9+O1uvjf2ZdOSpLma 8FcFf+19hT+VXnCuElw9a23Yq4ye+ul2cL11OC7/mPJDqxxoLnWiXqFgqFiokCF0PgrA jQ== From: Yuval Shaia To: yuval.shaia@oracle.com, marcel.apfelbaum@gmail.com, dmitry.fleytman@gmail.com, jasowang@redhat.com, eblake@redhat.com, armbru@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, shamir.rabinovitch@oracle.com, cohuck@redhat.com Date: Mon, 17 Dec 2018 10:10:41 +0200 Message-Id: <20181217081047.2039-18-yuval.shaia@oracle.com> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181217081047.2039-1-yuval.shaia@oracle.com> References: <20181217081047.2039-1-yuval.shaia@oracle.com> X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9109 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812170077 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 156.151.31.85 Subject: [Qemu-devel] [PATCH v7 17/23] hw/pvrdma: Fill error code in command's response X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Driver checks error code let's set it. In addition, for code simplification purposes, set response's fields ack, response and err outside of the scope of command handlers. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma_cmd.c | 199 ++++++++++++++++++--------------------- 1 file changed, 91 insertions(+), 108 deletions(-) diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c index 0d3c818c20..3b94545761 100644 --- a/hw/rdma/vmw/pvrdma_cmd.c +++ b/hw/rdma/vmw/pvrdma_cmd.c @@ -128,6 +128,9 @@ static int query_port(PVRDMADev *dev, union pvrdma_cmd_= req *req, struct pvrdma_port_attr attrs =3D {0}; =20 pr_dbg("port=3D%d\n", cmd->port_num); + if (cmd->port_num > MAX_PORTS) { + return -EINVAL; + } =20 if (rdma_backend_query_port(&dev->backend_dev, (struct ibv_port_attr *)&attrs)) { @@ -135,9 +138,6 @@ static int query_port(PVRDMADev *dev, union pvrdma_cmd_= req *req, } =20 memset(resp, 0, sizeof(*resp)); - resp->hdr.response =3D cmd->hdr.response; - resp->hdr.ack =3D PVRDMA_CMD_QUERY_PORT_RESP; - resp->hdr.err =3D 0; =20 resp->attrs.state =3D dev->func0->device_active ? attrs.state : PVRDMA_PORT_DOWN; @@ -160,12 +160,16 @@ static int query_pkey(PVRDMADev *dev, union pvrdma_cm= d_req *req, struct pvrdma_cmd_query_pkey_resp *resp =3D &rsp->query_pkey_resp; =20 pr_dbg("port=3D%d\n", cmd->port_num); + if (cmd->port_num > MAX_PORTS) { + return -EINVAL; + } + pr_dbg("index=3D%d\n", cmd->index); + if (cmd->index > MAX_PKEYS) { + return -EINVAL; + } =20 memset(resp, 0, sizeof(*resp)); - resp->hdr.response =3D cmd->hdr.response; - resp->hdr.ack =3D PVRDMA_CMD_QUERY_PKEY_RESP; - resp->hdr.err =3D 0; =20 resp->pkey =3D PVRDMA_PKEY; pr_dbg("pkey=3D0x%x\n", resp->pkey); @@ -178,17 +182,15 @@ static int create_pd(PVRDMADev *dev, union pvrdma_cmd= _req *req, { struct pvrdma_cmd_create_pd *cmd =3D &req->create_pd; struct pvrdma_cmd_create_pd_resp *resp =3D &rsp->create_pd_resp; + int rc; =20 pr_dbg("context=3D0x%x\n", cmd->ctx_handle ? cmd->ctx_handle : 0); =20 memset(resp, 0, sizeof(*resp)); - resp->hdr.response =3D cmd->hdr.response; - resp->hdr.ack =3D PVRDMA_CMD_CREATE_PD_RESP; - resp->hdr.err =3D rdma_rm_alloc_pd(&dev->rdma_dev_res, &dev->backend_d= ev, - &resp->pd_handle, cmd->ctx_handle); + rc =3D rdma_rm_alloc_pd(&dev->rdma_dev_res, &dev->backend_dev, + &resp->pd_handle, cmd->ctx_handle); =20 - pr_dbg("ret=3D%d\n", resp->hdr.err); - return resp->hdr.err; + return rc; } =20 static int destroy_pd(PVRDMADev *dev, union pvrdma_cmd_req *req, @@ -210,10 +212,9 @@ static int create_mr(PVRDMADev *dev, union pvrdma_cmd_= req *req, struct pvrdma_cmd_create_mr_resp *resp =3D &rsp->create_mr_resp; PCIDevice *pci_dev =3D PCI_DEVICE(dev); void *host_virt =3D NULL; + int rc =3D 0; =20 memset(resp, 0, sizeof(*resp)); - resp->hdr.response =3D cmd->hdr.response; - resp->hdr.ack =3D PVRDMA_CMD_CREATE_MR_RESP; =20 pr_dbg("pd_handle=3D%d\n", cmd->pd_handle); pr_dbg("access_flags=3D0x%x\n", cmd->access_flags); @@ -224,22 +225,18 @@ static int create_mr(PVRDMADev *dev, union pvrdma_cmd= _req *req, cmd->length); if (!host_virt) { pr_dbg("Failed to map to pdir\n"); - resp->hdr.err =3D -EINVAL; - goto out; + return -EINVAL; } } =20 - resp->hdr.err =3D rdma_rm_alloc_mr(&dev->rdma_dev_res, cmd->pd_handle, - cmd->start, cmd->length, host_virt, - cmd->access_flags, &resp->mr_handle, - &resp->lkey, &resp->rkey); - if (resp->hdr.err && host_virt) { + rc =3D rdma_rm_alloc_mr(&dev->rdma_dev_res, cmd->pd_handle, cmd->start, + cmd->length, host_virt, cmd->access_flags, + &resp->mr_handle, &resp->lkey, &resp->rkey); + if (rc && host_virt) { munmap(host_virt, cmd->length); } =20 -out: - pr_dbg("ret=3D%d\n", resp->hdr.err); - return resp->hdr.err; + return rc; } =20 static int destroy_mr(PVRDMADev *dev, union pvrdma_cmd_req *req, @@ -317,28 +314,25 @@ static int create_cq(PVRDMADev *dev, union pvrdma_cmd= _req *req, struct pvrdma_cmd_create_cq *cmd =3D &req->create_cq; struct pvrdma_cmd_create_cq_resp *resp =3D &rsp->create_cq_resp; PvrdmaRing *ring =3D NULL; + int rc; =20 memset(resp, 0, sizeof(*resp)); - resp->hdr.response =3D cmd->hdr.response; - resp->hdr.ack =3D PVRDMA_CMD_CREATE_CQ_RESP; =20 resp->cqe =3D cmd->cqe; =20 - resp->hdr.err =3D create_cq_ring(PCI_DEVICE(dev), &ring, cmd->pdir_dma, - cmd->nchunks, cmd->cqe); - if (resp->hdr.err) { - goto out; + rc =3D create_cq_ring(PCI_DEVICE(dev), &ring, cmd->pdir_dma, cmd->nchu= nks, + cmd->cqe); + if (rc) { + return rc; } =20 pr_dbg("ring=3D%p\n", ring); =20 - resp->hdr.err =3D rdma_rm_alloc_cq(&dev->rdma_dev_res, &dev->backend_d= ev, - cmd->cqe, &resp->cq_handle, ring); + rc =3D rdma_rm_alloc_cq(&dev->rdma_dev_res, &dev->backend_dev, cmd->cq= e, + &resp->cq_handle, ring); resp->cqe =3D cmd->cqe; =20 -out: - pr_dbg("ret=3D%d\n", resp->hdr.err); - return resp->hdr.err; + return rc; } =20 static int destroy_cq(PVRDMADev *dev, union pvrdma_cmd_req *req, @@ -458,30 +452,31 @@ static int create_qp(PVRDMADev *dev, union pvrdma_cmd= _req *req, struct pvrdma_cmd_create_qp *cmd =3D &req->create_qp; struct pvrdma_cmd_create_qp_resp *resp =3D &rsp->create_qp_resp; PvrdmaRing *rings =3D NULL; + int rc; =20 memset(resp, 0, sizeof(*resp)); - resp->hdr.response =3D cmd->hdr.response; - resp->hdr.ack =3D PVRDMA_CMD_CREATE_QP_RESP; =20 pr_dbg("total_chunks=3D%d\n", cmd->total_chunks); pr_dbg("send_chunks=3D%d\n", cmd->send_chunks); =20 - resp->hdr.err =3D create_qp_rings(PCI_DEVICE(dev), cmd->pdir_dma, &rin= gs, - cmd->max_send_wr, cmd->max_send_sge, - cmd->send_chunks, cmd->max_recv_wr, - cmd->max_recv_sge, cmd->total_chunks - - cmd->send_chunks - 1); - if (resp->hdr.err) { - goto out; + rc =3D create_qp_rings(PCI_DEVICE(dev), cmd->pdir_dma, &rings, + cmd->max_send_wr, cmd->max_send_sge, cmd->send_ch= unks, + cmd->max_recv_wr, cmd->max_recv_sge, + cmd->total_chunks - cmd->send_chunks - 1); + if (rc) { + return rc; } =20 pr_dbg("rings=3D%p\n", rings); =20 - resp->hdr.err =3D rdma_rm_alloc_qp(&dev->rdma_dev_res, cmd->pd_handle, - cmd->qp_type, cmd->max_send_wr, - cmd->max_send_sge, cmd->send_cq_handl= e, - cmd->max_recv_wr, cmd->max_recv_sge, - cmd->recv_cq_handle, rings, &resp->qp= n); + rc =3D rdma_rm_alloc_qp(&dev->rdma_dev_res, cmd->pd_handle, cmd->qp_ty= pe, + cmd->max_send_wr, cmd->max_send_sge, + cmd->send_cq_handle, cmd->max_recv_wr, + cmd->max_recv_sge, cmd->recv_cq_handle, rings, + &resp->qpn); + if (rc) { + return rc; + } =20 resp->max_send_wr =3D cmd->max_send_wr; resp->max_recv_wr =3D cmd->max_recv_wr; @@ -489,35 +484,31 @@ static int create_qp(PVRDMADev *dev, union pvrdma_cmd= _req *req, resp->max_recv_sge =3D cmd->max_recv_sge; resp->max_inline_data =3D cmd->max_inline_data; =20 -out: - pr_dbg("ret=3D%d\n", resp->hdr.err); - return resp->hdr.err; + return 0; } =20 static int modify_qp(PVRDMADev *dev, union pvrdma_cmd_req *req, union pvrdma_cmd_resp *rsp) { struct pvrdma_cmd_modify_qp *cmd =3D &req->modify_qp; + int rc; =20 pr_dbg("qp_handle=3D%d\n", cmd->qp_handle); =20 memset(rsp, 0, sizeof(*rsp)); - rsp->hdr.response =3D cmd->hdr.response; - rsp->hdr.ack =3D PVRDMA_CMD_MODIFY_QP_RESP; =20 /* No need to verify sgid_index since it is u8 */ =20 - rsp->hdr.err =3D - rdma_rm_modify_qp(&dev->rdma_dev_res, &dev->backend_dev, cmd->qp_h= andle, - cmd->attr_mask, cmd->attrs.ah_attr.grh.sgid_inde= x, - (union ibv_gid *)&cmd->attrs.ah_attr.grh.dgid, - cmd->attrs.dest_qp_num, - (enum ibv_qp_state)cmd->attrs.qp_state, - cmd->attrs.qkey, cmd->attrs.rq_psn, - cmd->attrs.sq_psn); - - pr_dbg("ret=3D%d\n", rsp->hdr.err); - return rsp->hdr.err; + rc =3D rdma_rm_modify_qp(&dev->rdma_dev_res, &dev->backend_dev, + cmd->qp_handle, cmd->attr_mask, + cmd->attrs.ah_attr.grh.sgid_index, + (union ibv_gid *)&cmd->attrs.ah_attr.grh.dgid, + cmd->attrs.dest_qp_num, + (enum ibv_qp_state)cmd->attrs.qp_state, + cmd->attrs.qkey, cmd->attrs.rq_psn, + cmd->attrs.sq_psn); + + return rc; } =20 static int query_qp(PVRDMADev *dev, union pvrdma_cmd_req *req, @@ -526,21 +517,18 @@ static int query_qp(PVRDMADev *dev, union pvrdma_cmd_= req *req, struct pvrdma_cmd_query_qp *cmd =3D &req->query_qp; struct pvrdma_cmd_query_qp_resp *resp =3D &rsp->query_qp_resp; struct ibv_qp_init_attr init_attr; + int rc; =20 pr_dbg("qp_handle=3D%d\n", cmd->qp_handle); pr_dbg("attr_mask=3D0x%x\n", cmd->attr_mask); =20 memset(rsp, 0, sizeof(*rsp)); - rsp->hdr.response =3D cmd->hdr.response; - rsp->hdr.ack =3D PVRDMA_CMD_QUERY_QP_RESP; =20 - rsp->hdr.err =3D rdma_rm_query_qp(&dev->rdma_dev_res, &dev->backend_de= v, - cmd->qp_handle, - (struct ibv_qp_attr *)&resp->attrs, - cmd->attr_mask, &init_attr); + rc =3D rdma_rm_query_qp(&dev->rdma_dev_res, &dev->backend_dev, cmd->qp= _handle, + (struct ibv_qp_attr *)&resp->attrs, cmd->attr_ma= sk, + &init_attr); =20 - pr_dbg("ret=3D%d\n", rsp->hdr.err); - return rsp->hdr.err; + return rc; } =20 static int destroy_qp(PVRDMADev *dev, union pvrdma_cmd_req *req, @@ -589,11 +577,8 @@ static int create_bind(PVRDMADev *dev, union pvrdma_cm= d_req *req, =20 rc =3D rdma_rm_add_gid(&dev->rdma_dev_res, &dev->backend_dev, dev->backend_eth_device_name, gid, cmd->index); - if (rc < 0) { - return -EINVAL; - } =20 - return 0; + return rc; } =20 static int destroy_bind(PVRDMADev *dev, union pvrdma_cmd_req *req, @@ -612,12 +597,7 @@ static int destroy_bind(PVRDMADev *dev, union pvrdma_c= md_req *req, rc =3D rdma_rm_del_gid(&dev->rdma_dev_res, &dev->backend_dev, dev->backend_eth_device_name, cmd->index); =20 - if (rc < 0) { - rsp->hdr.err =3D rc; - goto out; - } - - return 0; + return rc; } =20 static int create_uc(PVRDMADev *dev, union pvrdma_cmd_req *req, @@ -625,18 +605,14 @@ static int create_uc(PVRDMADev *dev, union pvrdma_cmd= _req *req, { struct pvrdma_cmd_create_uc *cmd =3D &req->create_uc; struct pvrdma_cmd_create_uc_resp *resp =3D &rsp->create_uc_resp; + int rc; =20 pr_dbg("pfn=3D%d\n", cmd->pfn); =20 memset(resp, 0, sizeof(*resp)); - resp->hdr.response =3D cmd->hdr.response; - resp->hdr.ack =3D PVRDMA_CMD_CREATE_UC_RESP; - resp->hdr.err =3D rdma_rm_alloc_uc(&dev->rdma_dev_res, cmd->pfn, - &resp->ctx_handle); + rc =3D rdma_rm_alloc_uc(&dev->rdma_dev_res, cmd->pfn, &resp->ctx_handl= e); =20 - pr_dbg("ret=3D%d\n", resp->hdr.err); - - return 0; + return rc; } =20 static int destroy_uc(PVRDMADev *dev, union pvrdma_cmd_req *req, @@ -650,30 +626,32 @@ static int destroy_uc(PVRDMADev *dev, union pvrdma_cm= d_req *req, =20 return 0; } + struct cmd_handler { uint32_t cmd; + uint32_t ack; int (*exec)(PVRDMADev *dev, union pvrdma_cmd_req *req, union pvrdma_cmd_resp *rsp); }; =20 static struct cmd_handler cmd_handlers[] =3D { - {PVRDMA_CMD_QUERY_PORT, query_port}, - {PVRDMA_CMD_QUERY_PKEY, query_pkey}, - {PVRDMA_CMD_CREATE_PD, create_pd}, - {PVRDMA_CMD_DESTROY_PD, destroy_pd}, - {PVRDMA_CMD_CREATE_MR, create_mr}, - {PVRDMA_CMD_DESTROY_MR, destroy_mr}, - {PVRDMA_CMD_CREATE_CQ, create_cq}, - {PVRDMA_CMD_RESIZE_CQ, NULL}, - {PVRDMA_CMD_DESTROY_CQ, destroy_cq}, - {PVRDMA_CMD_CREATE_QP, create_qp}, - {PVRDMA_CMD_MODIFY_QP, modify_qp}, - {PVRDMA_CMD_QUERY_QP, query_qp}, - {PVRDMA_CMD_DESTROY_QP, destroy_qp}, - {PVRDMA_CMD_CREATE_UC, create_uc}, - {PVRDMA_CMD_DESTROY_UC, destroy_uc}, - {PVRDMA_CMD_CREATE_BIND, create_bind}, - {PVRDMA_CMD_DESTROY_BIND, destroy_bind}, + {PVRDMA_CMD_QUERY_PORT, PVRDMA_CMD_QUERY_PORT_RESP, query_por= t}, + {PVRDMA_CMD_QUERY_PKEY, PVRDMA_CMD_QUERY_PKEY_RESP, query_pke= y}, + {PVRDMA_CMD_CREATE_PD, PVRDMA_CMD_CREATE_PD_RESP, create_pd= }, + {PVRDMA_CMD_DESTROY_PD, PVRDMA_CMD_DESTROY_PD_RESP_NOOP, destroy_p= d}, + {PVRDMA_CMD_CREATE_MR, PVRDMA_CMD_CREATE_MR_RESP, create_mr= }, + {PVRDMA_CMD_DESTROY_MR, PVRDMA_CMD_DESTROY_MR_RESP_NOOP, destroy_m= r}, + {PVRDMA_CMD_CREATE_CQ, PVRDMA_CMD_CREATE_CQ_RESP, create_cq= }, + {PVRDMA_CMD_RESIZE_CQ, PVRDMA_CMD_RESIZE_CQ_RESP, NULL}, + {PVRDMA_CMD_DESTROY_CQ, PVRDMA_CMD_DESTROY_CQ_RESP_NOOP, destroy_c= q}, + {PVRDMA_CMD_CREATE_QP, PVRDMA_CMD_CREATE_QP_RESP, create_qp= }, + {PVRDMA_CMD_MODIFY_QP, PVRDMA_CMD_MODIFY_QP_RESP, modify_qp= }, + {PVRDMA_CMD_QUERY_QP, PVRDMA_CMD_QUERY_QP_RESP, query_qp}, + {PVRDMA_CMD_DESTROY_QP, PVRDMA_CMD_DESTROY_QP_RESP, destroy_q= p}, + {PVRDMA_CMD_CREATE_UC, PVRDMA_CMD_CREATE_UC_RESP, create_uc= }, + {PVRDMA_CMD_DESTROY_UC, PVRDMA_CMD_DESTROY_UC_RESP_NOOP, destroy_u= c}, + {PVRDMA_CMD_CREATE_BIND, PVRDMA_CMD_CREATE_BIND_RESP_NOOP, create_bi= nd}, + {PVRDMA_CMD_DESTROY_BIND, PVRDMA_CMD_DESTROY_BIND_RESP_NOOP, destroy_b= ind}, }; =20 int execute_command(PVRDMADev *dev) @@ -696,7 +674,12 @@ int execute_command(PVRDMADev *dev) } =20 err =3D cmd_handlers[dsr_info->req->hdr.cmd].exec(dev, dsr_info->req, - dsr_info->rsp); + dsr_info->rsp); + dsr_info->rsp->hdr.response =3D dsr_info->req->hdr.response; + dsr_info->rsp->hdr.ack =3D cmd_handlers[dsr_info->req->hdr.cmd].ack; + dsr_info->rsp->hdr.err =3D err < 0 ? -err : 0; + pr_dbg("rsp->hdr.err=3D%d\n", dsr_info->rsp->hdr.err); + out: set_reg_val(dev, PVRDMA_REG_ERR, err); post_interrupt(dev, INTR_VEC_CMD_RING); --=20 2.17.2