From nobody Tue Feb 10 00:40:09 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=163.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1544837407010838.0125548303486; Fri, 14 Dec 2018 17:30:07 -0800 (PST) Received: from localhost ([::1]:37127 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXymC-00076L-2w for importer@patchew.org; Fri, 14 Dec 2018 20:29:56 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49954) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXykZ-0005B1-8L for qemu-devel@nongnu.org; Fri, 14 Dec 2018 20:28:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXykV-0003Nd-P6 for qemu-devel@nongnu.org; Fri, 14 Dec 2018 20:28:15 -0500 Received: from m12-13.163.com ([220.181.12.13]:55668) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXykV-0003MW-1v for qemu-devel@nongnu.org; Fri, 14 Dec 2018 20:28:11 -0500 Received: from localhost.localdomain (unknown [183.134.170.47]) by smtp9 (Coremail) with SMTP id DcCowABHyuiIWBRcdawzAA--.1809S5; Sat, 15 Dec 2018 09:27:46 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=HyQk4ackbckjxRsWO3 np1LMqXrC1YBfoAnh8qIKzdxY=; b=m2EeCJKs/RqffsbD8XNYQCNe+VLYDJP4T4 8xANKrF8XBRVG4GYgaDH/Z40I6sDVZNMuyBsF41gauisR3OSaqfmgOtNbA4f2obc RPzlWbVd+eyiYQ/xcv/cPqYkZvcs5L3xl9bwr3T67jv5TndAnf/90BWI0/yABHJq eKssT7dYw= From: Li Qiang To: thuth@redhat.com, lvivier@redhat.com, pbonzini@redhat.com, mst@redhat.com, peter.maydell@linaro.org, marcandre.lureau@redhat.com, berrange@redhat.com, jasowang@redhat.com Date: Fri, 14 Dec 2018 17:26:25 -0800 Message-Id: <20181215012625.73315-4-liq3ea@163.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181215012625.73315-1-liq3ea@163.com> References: <20181215012625.73315-1-liq3ea@163.com> X-CM-TRANSID: DcCowABHyuiIWBRcdawzAA--.1809S5 X-Coremail-Antispam: 1Uf129KBjvdXoW7Jw1kKF4kKw4fGr45KFyUJrb_yoW3uwc_GF W2yrs5XFyUZ3ySya4qg3y5AFZagrWrGrWxZF1aqryfXrn8u3Z8GF4UZryrWrsxWayxX3WU C34I9F43CFnxtjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU820P3UUUUU== X-Originating-IP: [183.134.170.47] X-CM-SenderInfo: 5oltjvrd6rljoofrz/1tbiKRIebVXlo--C1AAAsy X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 220.181.12.13 Subject: [Qemu-devel] [PATCH 3/3] util: check the return value of fcntl in qemu_set_{block, nonblock} X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Li Qiang , liq3ea@gmail.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Assert that the return value is not an error. This is like commit 7e6478e7d4f for qemu_set_cloexec. Signed-off-by: Li Qiang --- util/oslib-posix.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/util/oslib-posix.c b/util/oslib-posix.c index c1bee2a581..4ce1ba9ca4 100644 --- a/util/oslib-posix.c +++ b/util/oslib-posix.c @@ -233,14 +233,18 @@ void qemu_set_block(int fd) { int f; f =3D fcntl(fd, F_GETFL); - fcntl(fd, F_SETFL, f & ~O_NONBLOCK); + assert(f !=3D -1); + f =3D fcntl(fd, F_SETFL, f & ~O_NONBLOCK); + assert(f !=3D -1); } =20 void qemu_set_nonblock(int fd) { int f; f =3D fcntl(fd, F_GETFL); - fcntl(fd, F_SETFL, f | O_NONBLOCK); + assert(f !=3D -1); + f =3D fcntl(fd, F_SETFL, f | O_NONBLOCK); + assert(f !=3D -1); } =20 int socket_set_fast_reuse(int fd) --=20 2.17.1