From nobody Tue Apr 15 03:11:27 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1544758784313349.3299669003612; Thu, 13 Dec 2018 19:39:44 -0800 (PST) Received: from localhost ([::1]:59158 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXeKE-0007Hw-PO for importer@patchew.org; Thu, 13 Dec 2018 22:39:42 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXe1C-0006Gd-63 for qemu-devel@nongnu.org; Thu, 13 Dec 2018 22:20:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXe1B-0007fY-1q for qemu-devel@nongnu.org; Thu, 13 Dec 2018 22:20:01 -0500 Received: from mail-ot1-x32c.google.com ([2607:f8b0:4864:20::32c]:37718) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gXe18-0007KD-O1 for qemu-devel@nongnu.org; Thu, 13 Dec 2018 22:19:59 -0500 Received: by mail-ot1-x32c.google.com with SMTP id 40so4122092oth.4 for ; Thu, 13 Dec 2018 19:19:53 -0800 (PST) Received: from cloudburst.twiddle.net ([187.217.227.243]) by smtp.gmail.com with ESMTPSA id g138sm2367537oib.26.2018.12.13.19.19.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 13 Dec 2018 19:19:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ZdFhnUufyrFc19z7ViZt8Wb0ZHqiPUdjffxN+QTai+8=; b=Ab0xZM5+p7jt2C1eY6xTAYgj/nyCM9kJ43gpeMnw+PGQtrjCveEnR2/NHhIwy8ro35 h9PQ2d0mZaU4kjX9GmWUfq0kY1MPNjm1ShF+1OBm0+zi9VG5PDrrDC2aG9ViUeU1lzwY 89xSsgQxMyMEWeJlKwzjiAq/eLJkfaPnG72p8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ZdFhnUufyrFc19z7ViZt8Wb0ZHqiPUdjffxN+QTai+8=; b=KyOANR+T1dE54bud+YDnXGOq0dwJ8ycF9lc0+lT5npv21cEwBAdUJdX1WCiXMymriq mYRsRrf3u+qlDsdPIyEmdtCaLnHL2K1B+3rCVGNIsv6/rPZnc9Xor4Q1zc5dP+2uG4ip OrUXKEbiJ9jij4xAmOaUrJLAEHHEqtKl2GWyBIhpQr3HK1FRMbLREST/3WzXX0bxHNGs NPqRINn96i4yTd6UzAJ4Km+d63umNo+Dzx7UkhBW8hSpX+eE0CzWVRWBEadxXwB/YZAL HPoOtJOcp1TfVTlUWEDmdDfvHi1KPeAn6rJDZWuMROYz4HuUrzrdIIAx3ygEGGdRIQ3A nzAQ== X-Gm-Message-State: AA+aEWbMSqx9DOJANS+C+kjmHGS2W34aaAWvS0q5rpM8NS8oojW+CKIj OgeLJFpAhUMaYnD+gfar/OGECxNSthovHQ== X-Google-Smtp-Source: AFSGD/WRhiNhROt9Nq4Cb+vQWapZQ10Mi8qSqqoh05MKulXEkZr3ZGjRrDCCN1kmvwfPn6SdbuR8Vg== X-Received: by 2002:a05:6830:1204:: with SMTP id r4mr1034296otp.101.1544757592168; Thu, 13 Dec 2018 19:19:52 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 13 Dec 2018 21:19:14 -0600 Message-Id: <20181214031923.29527-25-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181214031923.29527-1-richard.henderson@linaro.org> References: <20181214031923.29527-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::32c Subject: [Qemu-devel] [PULL 23/32] tcg: Clean up generic bswap32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Based on the only current user, Sparc: New code uses 1 constant that takes 2 insns to create, plus 8. Old code used 2 constants that took 2 insns to create, plus 9. The result is a new total of 10 vs an old total of 13. Signed-off-by: Richard Henderson --- tcg/tcg-op.c | 54 ++++++++++++++++++++++++++-------------------------- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c index 7a8015c5a9..a956499e46 100644 --- a/tcg/tcg-op.c +++ b/tcg/tcg-op.c @@ -1012,22 +1012,22 @@ void tcg_gen_bswap32_i32(TCGv_i32 ret, TCGv_i32 arg) if (TCG_TARGET_HAS_bswap32_i32) { tcg_gen_op2_i32(INDEX_op_bswap32_i32, ret, arg); } else { - TCGv_i32 t0, t1; - t0 =3D tcg_temp_new_i32(); - t1 =3D tcg_temp_new_i32(); + TCGv_i32 t0 =3D tcg_temp_new_i32(); + TCGv_i32 t1 =3D tcg_temp_new_i32(); + TCGv_i32 t2 =3D tcg_const_i32(0x00ff00ff); =20 - tcg_gen_shli_i32(t0, arg, 24); + /* arg =3D abcd */ + tcg_gen_shri_i32(t0, arg, 8); /* t0 =3D .abc */ + tcg_gen_and_i32(t1, arg, t2); /* t1 =3D .b.d */ + tcg_gen_and_i32(t0, t0, t2); /* t0 =3D .a.c */ + tcg_temp_free_i32(t2); + tcg_gen_shli_i32(t1, t1, 8); /* t1 =3D b.d. */ + tcg_gen_or_i32(ret, t0, t1); /* ret =3D badc */ =20 - tcg_gen_andi_i32(t1, arg, 0x0000ff00); - tcg_gen_shli_i32(t1, t1, 8); - tcg_gen_or_i32(t0, t0, t1); + tcg_gen_shri_i32(t0, ret, 16); /* t0 =3D ..ba */ + tcg_gen_shli_i32(t1, ret, 16); /* t1 =3D dc.. */ + tcg_gen_or_i32(ret, t0, t1); /* ret =3D dcba */ =20 - tcg_gen_shri_i32(t1, arg, 8); - tcg_gen_andi_i32(t1, t1, 0x0000ff00); - tcg_gen_or_i32(t0, t0, t1); - - tcg_gen_shri_i32(t1, arg, 24); - tcg_gen_or_i32(ret, t0, t1); tcg_temp_free_i32(t0); tcg_temp_free_i32(t1); } @@ -1638,23 +1638,23 @@ void tcg_gen_bswap32_i64(TCGv_i64 ret, TCGv_i64 arg) } else if (TCG_TARGET_HAS_bswap32_i64) { tcg_gen_op2_i64(INDEX_op_bswap32_i64, ret, arg); } else { - TCGv_i64 t0, t1; - t0 =3D tcg_temp_new_i64(); - t1 =3D tcg_temp_new_i64(); + TCGv_i64 t0 =3D tcg_temp_new_i64(); + TCGv_i64 t1 =3D tcg_temp_new_i64(); + TCGv_i64 t2 =3D tcg_const_i64(0x00ff00ff); =20 - tcg_gen_shli_i64(t0, arg, 24); - tcg_gen_ext32u_i64(t0, t0); + /* arg =3D ....abcd */ + tcg_gen_shri_i64(t0, arg, 8); /* t0 =3D .....abc */ + tcg_gen_and_i64(t1, arg, t2); /* t1 =3D .....b.d */ + tcg_gen_and_i64(t0, t0, t2); /* t0 =3D .....a.c */ + tcg_temp_free_i64(t2); + tcg_gen_shli_i64(t1, t1, 8); /* t1 =3D ....b.d. */ + tcg_gen_or_i64(ret, t0, t1); /* ret =3D ....badc */ =20 - tcg_gen_andi_i64(t1, arg, 0x0000ff00); - tcg_gen_shli_i64(t1, t1, 8); - tcg_gen_or_i64(t0, t0, t1); + tcg_gen_shli_i64(t1, ret, 48); /* t1 =3D dc...... */ + tcg_gen_shri_i64(t0, ret, 16); /* t0 =3D ......ba */ + tcg_gen_shri_i64(t1, ret, 32); /* t1 =3D ....dc.. */ + tcg_gen_or_i64(ret, t0, t1); /* ret =3D ....dcba */ =20 - tcg_gen_shri_i64(t1, arg, 8); - tcg_gen_andi_i64(t1, t1, 0x0000ff00); - tcg_gen_or_i64(t0, t0, t1); - - tcg_gen_shri_i64(t1, arg, 24); - tcg_gen_or_i64(ret, t0, t1); tcg_temp_free_i64(t0); tcg_temp_free_i64(t1); } --=20 2.17.2