From nobody Wed Apr 16 12:22:22 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 154462291583527.056820729359742; Wed, 12 Dec 2018 05:55:15 -0800 (PST) Received: from localhost ([::1]:45061 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gX4yo-0007w9-MZ for importer@patchew.org; Wed, 12 Dec 2018 08:55:14 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gX4Z1-0003C7-2Y for qemu-devel@nongnu.org; Wed, 12 Dec 2018 08:28:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gX4Z0-0001Z3-4c for qemu-devel@nongnu.org; Wed, 12 Dec 2018 08:28:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44090) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gX4Yu-0001TD-VT; Wed, 12 Dec 2018 08:28:29 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4FDA43082A26; Wed, 12 Dec 2018 13:28:28 +0000 (UTC) Received: from linux.fritz.box.com (ovpn-117-245.ams2.redhat.com [10.36.117.245]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3E24A60C44; Wed, 12 Dec 2018 13:28:27 +0000 (UTC) From: Kevin Wolf To: qemu-block@nongnu.org Date: Wed, 12 Dec 2018 14:27:16 +0100 Message-Id: <20181212132735.16080-23-kwolf@redhat.com> In-Reply-To: <20181212132735.16080-1-kwolf@redhat.com> References: <20181212132735.16080-1-kwolf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Wed, 12 Dec 2018 13:28:28 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 22/41] file-posix: Avoid aio_worker() for QEMU_AIO_READ/WRITE X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" aio_worker() doesn't add anything interesting, it's only a useless indirection. Call the handler function directly instead. As we know that this handler function is only called from coroutine context and the coroutine stays around until the worker thread finishes, we can keep RawPosixAIOData on the stack. Signed-off-by: Kevin Wolf --- block/file-posix.c | 27 +++++++++++++++++++-------- 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/block/file-posix.c b/block/file-posix.c index 877c0700e1..0f64c83639 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -1300,8 +1300,9 @@ static ssize_t handle_aiocb_rw_linear(RawPosixAIOData= *aiocb, char *buf) return offset; } =20 -static ssize_t handle_aiocb_rw(RawPosixAIOData *aiocb) +static int handle_aiocb_rw(void *opaque) { + RawPosixAIOData *aiocb =3D opaque; ssize_t nbytes; char *buf; =20 @@ -1793,15 +1794,11 @@ static int aio_worker(void *arg) ssize_t ret =3D 0; =20 switch (aiocb->aio_type & QEMU_AIO_TYPE_MASK) { - case QEMU_AIO_READ: - ret =3D handle_aiocb_rw(aiocb); - break; - case QEMU_AIO_WRITE: - ret =3D handle_aiocb_rw(aiocb); - break; case QEMU_AIO_IOCTL: ret =3D handle_aiocb_ioctl(aiocb); break; + case QEMU_AIO_READ: + case QEMU_AIO_WRITE: case QEMU_AIO_FLUSH: case QEMU_AIO_DISCARD: case QEMU_AIO_WRITE_ZEROES: @@ -1865,6 +1862,7 @@ static int coroutine_fn raw_co_prw(BlockDriverState *= bs, uint64_t offset, uint64_t bytes, QEMUIOVector *qiov, int= type) { BDRVRawState *s =3D bs->opaque; + RawPosixAIOData acb; =20 if (fd_open(bs) < 0) return -EIO; @@ -1887,7 +1885,20 @@ static int coroutine_fn raw_co_prw(BlockDriverState = *bs, uint64_t offset, } } =20 - return paio_submit_co(bs, s->fd, offset, qiov, bytes, type); + acb =3D (RawPosixAIOData) { + .bs =3D bs, + .aio_fildes =3D s->fd, + .aio_type =3D type, + .aio_offset =3D offset, + .aio_nbytes =3D bytes, + .io =3D { + .iov =3D qiov->iov, + .niov =3D qiov->niov, + }, + }; + + assert(qiov->size =3D=3D bytes); + return raw_thread_pool_submit(bs, handle_aiocb_rw, &acb); } =20 static int coroutine_fn raw_co_preadv(BlockDriverState *bs, uint64_t offse= t, --=20 2.19.2