From nobody Fri Apr 26 04:55:37 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1543997085526920.9168655638484; Wed, 5 Dec 2018 00:04:45 -0800 (PST) Received: from localhost ([::1]:60819 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUSAm-00041z-97 for importer@patchew.org; Wed, 05 Dec 2018 03:04:44 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43351) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUS9r-0003l4-Iy for qemu-devel@nongnu.org; Wed, 05 Dec 2018 03:03:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gUS9o-0003YL-6L for qemu-devel@nongnu.org; Wed, 05 Dec 2018 03:03:47 -0500 Received: from mga03.intel.com ([134.134.136.65]:48448) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gUS9n-0003RL-Nv for qemu-devel@nongnu.org; Wed, 05 Dec 2018 03:03:44 -0500 Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Dec 2018 00:03:37 -0800 Received: from joy-optiplex-7040.sh.intel.com ([10.239.13.9]) by fmsmga005.fm.intel.com with ESMTP; 05 Dec 2018 00:03:35 -0800 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,317,1539673200"; d="scan'208";a="301156217" From: Zhao Yan To: qemu-devel@nongnu.org Date: Wed, 5 Dec 2018 02:58:30 -0500 Message-Id: <20181205075830.15678-1-yan.y.zhao@intel.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.65 Subject: [Qemu-devel] [PATCH v4] xen/pt: allow passthrough of devices with bogus interrupt pin X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sstabellini@kernel.org, Zhao Yan , Jan Beulich , anthony.perard@citrix.com, xen-devel@lists.xenproject.org, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" For some pci device, even its PCI_INTERRUPT_PIN is not 0, it actually doesn't support INTx mode, so its machine irq read from host sysfs is 0. In that case, report PCI_INTERRUPT_PIN as 0 to guest and let passthrough continue. Cc: Roger Pau Monn=C3=A9 Cc: Jan Beulich Reviewed-by: Roger Pau Monn=C3=A9 Signed-off-by: Zhao Yan Acked-by: Anthony PERARD --- v2: fix some coding style issue v3: 1. let subject be more descriptive (roger) 2. disable INTx assertion if machine irq is 0.(roger) 3. in xen_pt_irqpin_reg_init(), drop the else branch as the default value for *data is 0. (roger) v4: drop setting machine_irq as its default value is 0. (roger) --- hw/xen/xen_pt.c | 6 ++++++ hw/xen/xen_pt_config_init.c | 4 +++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index e5a6eff..82d7375 100644 --- a/hw/xen/xen_pt.c +++ b/hw/xen/xen_pt.c @@ -847,6 +847,12 @@ static void xen_pt_realize(PCIDevice *d, Error **errp) } =20 machine_irq =3D s->real_device.irq; + if (machine_irq =3D=3D 0) { + XEN_PT_LOG(d, "machine irq is 0\n"); + cmd |=3D PCI_COMMAND_INTX_DISABLE; + goto out; + } + rc =3D xc_physdev_map_pirq(xen_xc, xen_domid, machine_irq, &pirq); if (rc < 0) { error_setg_errno(errp, errno, "Mapping machine irq %u to" diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c index aee31c6..12f71c1 100644 --- a/hw/xen/xen_pt_config_init.c +++ b/hw/xen/xen_pt_config_init.c @@ -300,7 +300,9 @@ static int xen_pt_irqpin_reg_init(XenPCIPassthroughStat= e *s, XenPTRegInfo *reg, uint32_t real_offset, uint32_t *data) { - *data =3D xen_pt_pci_read_intx(s); + if (s->real_device.irq) { + *data =3D xen_pt_pci_read_intx(s); + } return 0; } =20 --=20 2.7.4