From nobody Sat Sep 28 22:01:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1543855887420632.8761143227741; Mon, 3 Dec 2018 08:51:27 -0800 (PST) Received: from localhost ([::1]:50608 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gTrRH-0006je-9U for importer@patchew.org; Mon, 03 Dec 2018 11:51:19 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gTqm9-0001Zz-0Y for qemu-devel@nongnu.org; Mon, 03 Dec 2018 11:08:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gTqm8-0003Os-9U for qemu-devel@nongnu.org; Mon, 03 Dec 2018 11:08:48 -0500 Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]:38576) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gTqm8-0003OY-4m for qemu-devel@nongnu.org; Mon, 03 Dec 2018 11:08:48 -0500 Received: by mail-oi1-x243.google.com with SMTP id a77so11361978oii.5 for ; Mon, 03 Dec 2018 08:08:48 -0800 (PST) Received: from cloudburst.twiddle.net (172.189-204-159.bestel.com.mx. [189.204.159.172]) by smtp.gmail.com with ESMTPSA id c19sm6338165otl.16.2018.12.03.08.08.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Dec 2018 08:08:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=VGbbvWUE6rnQSaltbq2Rb0A4jW/k/dy2fVEq4xZiX2I=; b=QC0MTw72j4UIvJOPKZdj2SARIJHQFMUC/Dtl6bcFQa4kHCx3TTOHLGQnSPgwxmvpFV SJp5+fT1V3NF44WY84bivWNLm0ldVVxpOgfrMzZ1LhDPUYRf79LK36/1jSWpimswmwv+ kwxr9THiJIPnBxlwv/D4IQFCOdd+stjQJ/Og8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=VGbbvWUE6rnQSaltbq2Rb0A4jW/k/dy2fVEq4xZiX2I=; b=pDWH49F87bSgySfOToJuGnWGrRqD/MD0tJWteRT8lbyKHxnu4BfYLuOiVx0mQ8xErx XqQwDnkvxbLSzV0wq1+y/S/UVXwrtosMP+uXsjk2+oNRoln6jdN2mS8/v0pCEwDEeAFb DeS6J/KSBjQihrb1Iry+t3Kam7Z+/YCw4nWoi/Ykla1VHyZEYYT+M4tQUyhjUN0BDFNm ++fn43UROvtbGZBIfWhASINCDq82qipxMuqLI4dsW+TPNDNb1CxUwZ2n4T3oxHqniJok Aeagl8pBt3OVkNIq/YjoZPtkYP1k3IM7FkPVOUwx4pxY61YPTc49PKsQCLqnvYkv+n05 Hsig== X-Gm-Message-State: AA+aEWZkXPk8Has0l1iJhU2KcJzA46qf8TZQ9pi4uRAoi1TNc3BkmK8k HuoIJfyXbrTVLM7jkIODOojyYSxgxGnCFA== X-Google-Smtp-Source: AFSGD/VfNw6ID0yN9ZzIFVQpp2YHliMWPZFfIDpnxpkSm+STA4HHyyrDNScRZRgJqJkLCOmM5vbaUw== X-Received: by 2002:aca:4ace:: with SMTP id x197mr10677583oia.129.1543853327133; Mon, 03 Dec 2018 08:08:47 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 3 Dec 2018 10:08:37 -0600 Message-Id: <20181203160840.15115-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181203160840.15115-1-richard.henderson@linaro.org> References: <20181203160840.15115-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::243 Subject: [Qemu-devel] [PATCH for-4.0 2/5] tcg/i386: Implement INDEX_op_extr{lh}_i64_i32 for 32-bit guests X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cota@braap.org, alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This preserves the invariant that all TCG_TYPE_I32 values are zero-extended in the 64-bit host register. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.h | 5 +++-- tcg/i386/tcg-target.inc.c | 6 ++++++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/tcg/i386/tcg-target.h b/tcg/i386/tcg-target.h index 2441658865..c523d5f5e1 100644 --- a/tcg/i386/tcg-target.h +++ b/tcg/i386/tcg-target.h @@ -135,8 +135,9 @@ extern bool have_avx2; #define TCG_TARGET_HAS_direct_jump 1 =20 #if TCG_TARGET_REG_BITS =3D=3D 64 -#define TCG_TARGET_HAS_extrl_i64_i32 0 -#define TCG_TARGET_HAS_extrh_i64_i32 0 +/* Keep target addresses zero-extended in a register. */ +#define TCG_TARGET_HAS_extrl_i64_i32 (TARGET_LONG_BITS =3D=3D 32) +#define TCG_TARGET_HAS_extrh_i64_i32 (TARGET_LONG_BITS =3D=3D 32) #define TCG_TARGET_HAS_div2_i64 1 #define TCG_TARGET_HAS_rot_i64 1 #define TCG_TARGET_HAS_ext8s_i64 1 diff --git a/tcg/i386/tcg-target.inc.c b/tcg/i386/tcg-target.inc.c index 6bf4f84b20..ab31dfa66d 100644 --- a/tcg/i386/tcg-target.inc.c +++ b/tcg/i386/tcg-target.inc.c @@ -2546,12 +2546,16 @@ static inline void tcg_out_op(TCGContext *s, TCGOpc= ode opc, break; case INDEX_op_extu_i32_i64: case INDEX_op_ext32u_i64: + case INDEX_op_extrl_i64_i32: tcg_out_ext32u(s, a0, a1); break; case INDEX_op_ext_i32_i64: case INDEX_op_ext32s_i64: tcg_out_ext32s(s, a0, a1); break; + case INDEX_op_extrh_i64_i32: + tcg_out_shifti(s, SHIFT_SHR + P_REXW, a0, 32); + break; #endif =20 OP_32_64(deposit): @@ -2915,6 +2919,7 @@ static const TCGTargetOpDef *tcg_target_op_def(TCGOpc= ode op) case INDEX_op_neg_i64: case INDEX_op_not_i32: case INDEX_op_not_i64: + case INDEX_op_extrh_i64_i32: return &r_0; =20 case INDEX_op_ext8s_i32: @@ -2930,6 +2935,7 @@ static const TCGTargetOpDef *tcg_target_op_def(TCGOpc= ode op) case INDEX_op_ext32u_i64: case INDEX_op_ext_i32_i64: case INDEX_op_extu_i32_i64: + case INDEX_op_extrl_i64_i32: case INDEX_op_extract_i32: case INDEX_op_extract_i64: case INDEX_op_sextract_i32: --=20 2.17.2