From nobody Thu Nov 6 19:31:44 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1543805013596114.9460298600469; Sun, 2 Dec 2018 18:43:33 -0800 (PST) Received: from localhost ([::1]:46528 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gTeCb-0005Sy-1S for importer@patchew.org; Sun, 02 Dec 2018 21:43:17 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48371) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gTeBh-0004zo-2L for qemu-devel@nongnu.org; Sun, 02 Dec 2018 21:42:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gTeBd-0004js-UM for qemu-devel@nongnu.org; Sun, 02 Dec 2018 21:42:21 -0500 Received: from mga03.intel.com ([134.134.136.65]:62117) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gTeBd-0004hU-MV for qemu-devel@nongnu.org; Sun, 02 Dec 2018 21:42:17 -0500 Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Dec 2018 18:42:10 -0800 Received: from joy-optiplex-7040.sh.intel.com ([10.239.13.9]) by orsmga003.jf.intel.com with ESMTP; 02 Dec 2018 18:42:08 -0800 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,308,1539673200"; d="scan'208";a="106738321" From: Zhao Yan To: anthony.perard@citrix.com, sstabellini@kernel.org, roger.pau@citrix.com, JBeulich@suse.com, qemu-devel@nongnu.org Date: Sun, 2 Dec 2018 21:37:28 -0500 Message-Id: <20181203023728.26774-1-yan.y.zhao@intel.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.65 Subject: [Qemu-devel] [PATCH] xen/pt: Fix a xen passthrough failure X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Zhao Yan Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" For some pci device, even its PCI_INTERRUPT_PIN is not 0, it actually doesn't support INTx mode, so its machine irq read from host sysfs is 0. In that case, report PCI_INTERRUPT_PIN as 0 to guest and let passthrough continue. Cc: Roger Pau Monn=C3=A9 Cc: Jan Beulich Signed-off-by: Zhao Yan --- hw/xen/xen_pt.c | 5 +++++ hw/xen/xen_pt_config_init.c | 7 ++++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index f1f3a3727c..de63cb8e94 100644 --- a/hw/xen/xen_pt.c +++ b/hw/xen/xen_pt.c @@ -847,6 +847,11 @@ static void xen_pt_realize(PCIDevice *d, Error **errp) } =20 machine_irq =3D s->real_device.irq; + if(machine_irq =3D=3D 0) { + XEN_PT_LOG(d, "machine irq is 0\n"); + goto out; + } + rc =3D xc_physdev_map_pirq(xen_xc, xen_domid, machine_irq, &pirq); if (rc < 0) { error_setg_errno(errp, errno, "Mapping machine irq %u to" diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c index 47f9010c75..8baddbed90 100644 --- a/hw/xen/xen_pt_config_init.c +++ b/hw/xen/xen_pt_config_init.c @@ -300,7 +300,12 @@ static int xen_pt_irqpin_reg_init(XenPCIPassthroughSta= te *s, XenPTRegInfo *reg, uint32_t real_offset, uint32_t *data) { - *data =3D xen_pt_pci_read_intx(s); + if (s->real_device.irq) + *data =3D xen_pt_pci_read_intx(s); + else { + XEN_PT_LOG(&s->dev, "machine irq is 0, init guest PCI_INTERRUPT_PI= N to 0\n"); + *data =3D 0; + } return 0; } =20 --=20 2.17.1