From nobody Tue Feb 10 09:57:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1543615374226748.7906838432323; Fri, 30 Nov 2018 14:02:54 -0800 (PST) Received: from localhost ([::1]:34789 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSqs1-0001oR-WC for importer@patchew.org; Fri, 30 Nov 2018 17:02:46 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52567) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSqiC-0007zi-F2 for qemu-devel@nongnu.org; Fri, 30 Nov 2018 16:52:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gSqiA-0006vo-Tn for qemu-devel@nongnu.org; Fri, 30 Nov 2018 16:52:36 -0500 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]:41099) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gSqiA-0006tK-O9 for qemu-devel@nongnu.org; Fri, 30 Nov 2018 16:52:34 -0500 Received: by mail-pg1-x543.google.com with SMTP id 70so3049139pgh.8 for ; Fri, 30 Nov 2018 13:52:34 -0800 (PST) Received: from cloudburst.twiddle.net (97-113-170-180.tukw.qwest.net. [97.113.170.180]) by smtp.gmail.com with ESMTPSA id a18sm6973967pgj.30.2018.11.30.13.52.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 30 Nov 2018 13:52:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=meIomQO1GtN3dMIndLu+UFeHsb6xbjxNIqoRJl4bs4M=; b=JR4ASTrdv+nh4SdxVNJz3aDFiriHArQBIgOYh0tCofkYO+l9q+QLuOphY+AlGXoDu+ 3+ADPDIgcSTyqlxTM/KzhxBkDXAKeqCNM5q3ixpPq1am5Zp+UuqQ/cTnQ7LjUNOL941m Je26snvROIh5sl07huJ6rbiBXLntouwMfAeoM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=meIomQO1GtN3dMIndLu+UFeHsb6xbjxNIqoRJl4bs4M=; b=Cb7amY84A04s5Qw5lfbZtn9yPHnApy9MQenA7yCO3HghvzcLzEMSFdyJH5ngA6RVvt fOmNjN5aJS/4C/KxTsjOTrarQgf9/ruWMqTI+tPgU1M2SN3De2PIMkEmqqA/t4n7g43o +EO91WLv6BnoF08kOGck4Gw6lC/LpuULAX+dhZRKXTsEp62BWydL6rRm7KoHYWzGzc8U 6pKUhhsX38+R+EX7JzVUbJtN/jfXPJdqK+vPPSvt0IRbv90zJfIt+h+RU9DdI2c1iD3I n4HODSyYfLoWNp5+mfRhp/toTYCwo8Kn7mYZ3aagswTCCpC7YuDPSUslfReDnnubEGaE rh+w== X-Gm-Message-State: AA+aEWbuYLvldxtRHIGyfKMotEPfGT1g0k7XDDfG56t+IGk9XMDTZ5lH B31JbOtzCjstwTkluP6yI5diAUuKapc= X-Google-Smtp-Source: AFSGD/WrqdaKm/AX8Udkm/TUwOMLpxixkPYuyv1v7MDF/R/BzptiEkpKqXNZiBLIBm9OVbKwyAe6Kg== X-Received: by 2002:a63:9306:: with SMTP id b6mr5941075pge.36.1543614753448; Fri, 30 Nov 2018 13:52:33 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 30 Nov 2018 13:52:13 -0800 Message-Id: <20181130215221.20554-9-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181130215221.20554-1-richard.henderson@linaro.org> References: <20181130215221.20554-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::543 Subject: [Qemu-devel] [PATCH v3 08/16] tcg/s390: Remove retranslation code X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" There is no longer a need for preserving branch offset operands, as we no longer re-translate. Signed-off-by: Richard Henderson Reviewed-by: Alex Benn=C3=A9e --- tcg/s390/tcg-target.inc.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/tcg/s390/tcg-target.inc.c b/tcg/s390/tcg-target.inc.c index 17c435ade5..96c344142e 100644 --- a/tcg/s390/tcg-target.inc.c +++ b/tcg/s390/tcg-target.inc.c @@ -1329,13 +1329,11 @@ static void tgen_branch(TCGContext *s, int cc, TCGL= abel *l) static void tgen_compare_branch(TCGContext *s, S390Opcode opc, int cc, TCGReg r1, TCGReg r2, TCGLabel *l) { - intptr_t off; + intptr_t off =3D 0; =20 if (l->has_value) { off =3D l->u.value_ptr - s->code_ptr; } else { - /* We need to keep the offset unchanged for retranslation. */ - off =3D s->code_ptr[1]; tcg_out_reloc(s, s->code_ptr + 1, R_390_PC16DBL, l, 2); } =20 @@ -1347,13 +1345,11 @@ static void tgen_compare_branch(TCGContext *s, S390= Opcode opc, int cc, static void tgen_compare_imm_branch(TCGContext *s, S390Opcode opc, int cc, TCGReg r1, int i2, TCGLabel *l) { - tcg_target_long off; + tcg_target_long off =3D 0; =20 if (l->has_value) { off =3D l->u.value_ptr - s->code_ptr; } else { - /* We need to keep the offset unchanged for retranslation. */ - off =3D s->code_ptr[1]; tcg_out_reloc(s, s->code_ptr + 1, R_390_PC16DBL, l, 2); } =20 @@ -1696,7 +1692,6 @@ static void tcg_out_qemu_ld(TCGContext* s, TCGReg dat= a_reg, TCGReg addr_reg, =20 base_reg =3D tcg_out_tlb_read(s, addr_reg, opc, mem_index, 1); =20 - /* We need to keep the offset unchanged for retranslation. */ tcg_out16(s, RI_BRC | (S390_CC_NE << 4)); label_ptr =3D s->code_ptr; s->code_ptr +=3D 1; @@ -1724,7 +1719,6 @@ static void tcg_out_qemu_st(TCGContext* s, TCGReg dat= a_reg, TCGReg addr_reg, =20 base_reg =3D tcg_out_tlb_read(s, addr_reg, opc, mem_index, 0); =20 - /* We need to keep the offset unchanged for retranslation. */ tcg_out16(s, RI_BRC | (S390_CC_NE << 4)); label_ptr =3D s->code_ptr; s->code_ptr +=3D 1; --=20 2.17.2