From nobody Sat Apr 27 14:47:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=samsung.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 154332731697313.663832634405821; Tue, 27 Nov 2018 06:01:56 -0800 (PST) Received: from localhost ([::1]:42565 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRdvw-0002lw-GF for importer@patchew.org; Tue, 27 Nov 2018 09:01:48 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49398) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRdlL-0002NS-BT for qemu-devel@nongnu.org; Tue, 27 Nov 2018 08:50:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRdlH-0008Dl-E7 for qemu-devel@nongnu.org; Tue, 27 Nov 2018 08:50:51 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:51092) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gRdlH-0008Ct-7q for qemu-devel@nongnu.org; Tue, 27 Nov 2018 08:50:47 -0500 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20181127135046euoutp02369699b56fbc094c7eff6b16905697f2~q-2hwdcu_2240422404euoutp02P for ; Tue, 27 Nov 2018 13:50:46 +0000 (GMT) Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20181127135045eucas1p1619bd13c918ddbb941d4d39eacfc7310~q-2hYRd6V1958819588eucas1p1F; Tue, 27 Nov 2018 13:50:45 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id D3.E7.04441.5BB4DFB5; Tue, 27 Nov 2018 13:50:45 +0000 (GMT) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20181127135045eucas1p1e259cacbab5e715f7845b9beee22f882~q-2goblNK2351423514eucas1p1z; Tue, 27 Nov 2018 13:50:45 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20181127135044eusmtrp189ec76bbe9d395f1ed48a1c2575a30f9~q-2gaAA0l2189621896eusmtrp1-; Tue, 27 Nov 2018 13:50:44 +0000 (GMT) Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id B0.CB.04284.4BB4DFB5; Tue, 27 Nov 2018 13:50:44 +0000 (GMT) Received: from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20181127135044eusmtip12b88cbc45176b363224012caefd6166f~q-2f5mypM1950919509eusmtip1H; Tue, 27 Nov 2018 13:50:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20181127135046euoutp02369699b56fbc094c7eff6b16905697f2~q-2hwdcu_2240422404euoutp02P DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1543326646; bh=diLhltG4bd5NJmm2OD08qIfPUrfIYmKRi7VgIuEA9rw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Sd5z1hmxUulz2APcZyWqjo1EF7x73UoK0wNNItQ8P7X351AU+oG5M9FUds+0yFboY fy2QOrE5FmxpMXE+BnALo8DkVkEw63+wDw/OeHie4hEv/hrGUhD006W/MsiwgZb8Sk UjPorKErBVEsmhluC21O5iaqXDJr2QgtrNiR6OWM= X-AuditID: cbfec7f2-5c9ff70000001159-29-5bfd4bb5bc1d From: Ilya Maximets To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Date: Tue, 27 Nov 2018 16:50:27 +0300 Message-Id: <20181127135030.1671-2-i.maximets@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181127135030.1671-1-i.maximets@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprKKsWRmVeSWpSXmKPExsWy7djP87pbvf9GG+w8pGrRcC/U4kr7T3aL 00c7mC2e3TrJbLGgrZ3VYv+2f6wWx3t3sDiwezy5tpnJ4/2+q2wefVtWMQYwR3HZpKTmZJal FunbJXBl3Pw6ibHgukzFl7/f2BoYNwl3MXJySAiYSDTs2MDYxcjFISSwglFi4f9LbBDOF0aJ tZdmQGU+M0o8Xr+RvYuRA6zlxBwTiPhyRomXSxYyQTg/GCX2rrjECjKXTUBH4tTqI4wgtoiA m8SLB8fBxjIL3GSUWPpxAQtIQlggRKJr0VywBhYBVYkZp1rZQWxeASuJP3s6GSEOlJdYveEA M4jNKWAt8f3fEjaIGkGJkzOfgM1hBqpp3jqbGWSBhEAzu8SBnbuhml0kVv/5ywxhC0u8Or6F HcKWkTg9uYcFwq6XuN/ykhGiuYNRYvqhf0wQCXuJLa/Pgf3MLKApsX6XPkTYUeL/xKlskKDg k7jxVhDiBj6JSdumM0OEeSU62oQgqlUkfh9cDnWBlMTNd5+hLvCQ6FuyiGUCo+IsJN/MQvLN LIS9CxiZVzGKp5YW56anFhvmpZbrFSfmFpfmpesl5+duYgQmltP/jn/awfj1UtIhRgEORiUe 3g3ff0cLsSaWFVfmHmKU4GBWEuF1Vv4bLcSbklhZlVqUH19UmpNafIhRmoNFSZy3muFBtJBA emJJanZqakFqEUyWiYNTqoHRxir48a96SWH9+l+ztr+1Wcz3OcVqEmeS9g+NbicPWZ2tmxK0 KuNtQz7P3pSfUP15+1H5XzcnNVe0Ndf8m9PBVRy468PU9S0W535qLdgn0O23wPdl3rFtx0X4 t+nrPl/lFmm+PMsv+MveiEnn7m8QPup3+TzX5JNKmoLHNbmfLyxlu3KlwT9fiaU4I9FQi7mo OBEAowALxygDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmkeLIzCtJLcpLzFFi42I5/e/4Xd0t3n+jDaZsMbFouBdqcaX9J7vF 6aMdzBbPbp1ktljQ1s5qsX/bP1aL4707WBzYPZ5c28zk8X7fVTaPvi2rGAOYo/RsivJLS1IV MvKLS2yVog0tjPQMLS30jEws9QyNzWOtjEyV9O1sUlJzMstSi/TtEvQybn6dxFhwXabiy99v bA2Mm4S7GDk4JARMJE7MMeli5OIQEljKKPHs/S22LkZOoLiUxI9fF1ghbGGJP9e62CCKvjFK nP1ynREkwSagI3Fq9REwW0TATeLFg+NgRcwC9xkljm2aCjZJWCBIYu+CW8wgNouAqsSMU63s IDavgJXEnz2djBAb5CVWbzgAVsMpYC3x/d8SsF4hoJpPB16xQdQLSpyc+YQFxGYGqm/eOpt5 AqPALCSpWUhSCxiZVjGKpJYW56bnFhvqFSfmFpfmpesl5+duYgRGwLZjPzfvYLy0MfgQowAH oxIP74bvv6OFWBPLiitzDzFKcDArifA6K/+NFuJNSaysSi3Kjy8qzUktPsRoCvTERGYp0eR8 YHTmlcQbmhqaW1gamhubG5tZKInznjeojBISSE8sSc1OTS1ILYLpY+LglGpgVJ3XsXDVFCEh n9SM6fXsmft3/eNc9vluYt7xwGsHBd6ndjNM3HRsxbfclnjnZxI7XfSa5MzmBHis+JBlv27K DIUM39J05ll8r1TOOsjbL5/HcfvCm4yzRwx1/hZG860U3naJWeq4R7iKXFpd1rOnrlZFAckV xybf16xieahrVqWesoLBxWS+EktxRqKhFnNRcSIA9HWr2JYCAAA= X-CMS-MailID: 20181127135045eucas1p1e259cacbab5e715f7845b9beee22f882 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20181127135045eucas1p1e259cacbab5e715f7845b9beee22f882 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181127135045eucas1p1e259cacbab5e715f7845b9beee22f882 References: <20181127135030.1671-1-i.maximets@samsung.com> Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 210.118.77.12 Subject: [Qemu-devel] [PATCH v2 1/4] hostmem-memfd: disable for systems wihtout sealing support X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , qemu-devel@nongnu.org, Gerd Hoffmann , Igor Mammedov , Ilya Maximets , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) If seals are not supported, memfd_create() will fail. Furthermore, there is no way to disable it in this case because '.seal' property is not registered. This issue leads to vhost-user-test failures on RHEL 7.2: qemu-system-x86_64: -object memory-backend-memfd,id=3Dmem,size=3D2M,: \ failed to create memfd: Invalid argument and actually breaks the feature on such systems. Let's restrict memfd backend to systems with sealing support. Signed-off-by: Ilya Maximets Reviewed-by: Marc-Andr=C3=A9 Lureau --- backends/hostmem-memfd.c | 18 ++++++++---------- tests/vhost-user-test.c | 6 +++--- 2 files changed, 11 insertions(+), 13 deletions(-) diff --git a/backends/hostmem-memfd.c b/backends/hostmem-memfd.c index b6836b28e5..a3455da9c9 100644 --- a/backends/hostmem-memfd.c +++ b/backends/hostmem-memfd.c @@ -156,15 +156,13 @@ memfd_backend_class_init(ObjectClass *oc, void *data) "Huge pages size (ex: 2M, 1G= )", &error_abort); } - if (qemu_memfd_check(MFD_ALLOW_SEALING)) { - object_class_property_add_bool(oc, "seal", - memfd_backend_get_seal, - memfd_backend_set_seal, - &error_abort); - object_class_property_set_description(oc, "seal", - "Seal growing & shrinking", - &error_abort); - } + object_class_property_add_bool(oc, "seal", + memfd_backend_get_seal, + memfd_backend_set_seal, + &error_abort); + object_class_property_set_description(oc, "seal", + "Seal growing & shrinking", + &error_abort); } =20 static const TypeInfo memfd_backend_info =3D { @@ -177,7 +175,7 @@ static const TypeInfo memfd_backend_info =3D { =20 static void register_types(void) { - if (qemu_memfd_check(0)) { + if (qemu_memfd_check(MFD_ALLOW_SEALING)) { type_register_static(&memfd_backend_info); } } diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c index 45d58d8ea2..e3e9a33580 100644 --- a/tests/vhost-user-test.c +++ b/tests/vhost-user-test.c @@ -169,7 +169,7 @@ static char *get_qemu_cmd(TestServer *s, int mem, enum test_memfd memfd, const char *mem_= path, const char *chr_opts, const char *extra) { - if (memfd =3D=3D TEST_MEMFD_AUTO && qemu_memfd_check(0)) { + if (memfd =3D=3D TEST_MEMFD_AUTO && qemu_memfd_check(MFD_ALLOW_SEALING= )) { memfd =3D TEST_MEMFD_YES; } =20 @@ -903,7 +903,7 @@ static void test_multiqueue(void) s->queues =3D 2; test_server_listen(s); =20 - if (qemu_memfd_check(0)) { + if (qemu_memfd_check(MFD_ALLOW_SEALING)) { cmd =3D g_strdup_printf( QEMU_CMD_MEMFD QEMU_CMD_CHR QEMU_CMD_NETDEV ",queues=3D%d " "-device virtio-net-pci,netdev=3Dnet0,mq=3Don,vectors=3D%d", @@ -963,7 +963,7 @@ int main(int argc, char **argv) /* run the main loop thread so the chardev may operate */ thread =3D g_thread_new(NULL, thread_function, loop); =20 - if (qemu_memfd_check(0)) { + if (qemu_memfd_check(MFD_ALLOW_SEALING)) { qtest_add_data_func("/vhost-user/read-guest-mem/memfd", GINT_TO_POINTER(TEST_MEMFD_YES), test_read_guest_mem); --=20 2.17.1 From nobody Sat Apr 27 14:47:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=samsung.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1543326877987392.0819314817883; Tue, 27 Nov 2018 05:54:37 -0800 (PST) Received: from localhost ([::1]:42506 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRdot-0004Vr-D0 for importer@patchew.org; Tue, 27 Nov 2018 08:54:31 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49453) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRdlS-0002RS-PL for qemu-devel@nongnu.org; Tue, 27 Nov 2018 08:51:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRdlO-0008Mm-TI for qemu-devel@nongnu.org; Tue, 27 Nov 2018 08:50:58 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:51143) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gRdlO-0008Lu-Nj for qemu-devel@nongnu.org; Tue, 27 Nov 2018 08:50:54 -0500 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20181127135053euoutp02b4ef6db79ac5dcf4e01c8eca3a27e713~q-2ox5gbh2240422404euoutp02U for ; Tue, 27 Nov 2018 13:50:53 +0000 (GMT) Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20181127135053eucas1p24233159d16b1a97829d70b8d91197b58~q-2oZURLS2251222512eucas1p2y; Tue, 27 Nov 2018 13:50:53 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id A9.E7.04441.DBB4DFB5; Tue, 27 Nov 2018 13:50:53 +0000 (GMT) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20181127135052eucas1p2cec316cce9b9218e4ab476315fd4596b~q-2npsFBg2226922269eucas1p2s; Tue, 27 Nov 2018 13:50:52 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20181127135052eusmtrp1500465a3554d9f495668431d0c8d447d~q-2na-CBi2189621896eusmtrp1S; Tue, 27 Nov 2018 13:50:52 +0000 (GMT) Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 8E.10.04128.CBB4DFB5; Tue, 27 Nov 2018 13:50:52 +0000 (GMT) Received: from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20181127135051eusmtip161e0706d1be451f9a04fbbc0d0f5f15b~q-2m2oaN21950619506eusmtip1k; Tue, 27 Nov 2018 13:50:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20181127135053euoutp02b4ef6db79ac5dcf4e01c8eca3a27e713~q-2ox5gbh2240422404euoutp02U DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1543326653; bh=GEubV4Xl2+w4QqD4xxZ2I4ZswHS5mSjjUIfJbjJnB+Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gZjpyYguiWnTp5S49fmumulgCUx5cTXLlI8yJbpM9w/07zmlH6QBQ5tnS1QC5rTa/ 3quTRp6UPZPxOYPtZYv3Suzf9mbbNlFsK0rpHb/DZyXAHE7z4mXinS4c/FO57hOMiq RBq2pJLaYucIKw5m08Nr2JMBx/xBQ9dZjo/TZeFc= X-AuditID: cbfec7f2-5e3ff70000001159-43-5bfd4bbd2354 From: Ilya Maximets To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Date: Tue, 27 Nov 2018 16:50:28 +0300 Message-Id: <20181127135030.1671-3-i.maximets@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181127135030.1671-1-i.maximets@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprGKsWRmVeSWpSXmKPExsWy7djP87p7vf9GG2yZymXRcC/U4kr7T3aL 00c7mC2e3TrJbLGgrZ3VYv+2f6wWx3t3sDiwezy5tpnJ4/2+q2wefVtWMQYwR3HZpKTmZJal FunbJXBlrOrvYCvYyFpxqeENewPjKpYuRk4OCQETiWXbVzJ2MXJxCAmsYJS4uHcXG4TzhVFi 584l7BDOZ0aJJQ+escK0HJ7YwAKRWM4oca/3NhOE8wOof/4psCo2AR2JU6uPMILYIgJuEi8e HAebyyxwk1Fi6ccFYNuFBawlXn8+xQZiswioSsz5MB+sgVfASmLelTY2iHXyEqs3HGAGsTmB 6r//W8IGUSMocXLmE7A5zEA1zVtnM4MskBDoZ5d40D0J6lYXiZsrjkMNEpZ4dXwLO4QtI3F6 cg80COol7re8ZIRo7mCUmH7oHxNEwl5iy+tzQA0cQBs0Jdbv0ocIO0r8XrCDDSQsIcAnceOt IMQNfBKTtk1nhgjzSnS0CUFUq0j8PricGcKWkrj57jPUBR4S3c+nsUxgVJyF5JtZSL6ZhbB3 ASPzKkbx1NLi3PTUYsO81HK94sTc4tK8dL3k/NxNjMDUcvrf8U87GL9eSjrEKMDBqMTDu+H7 72gh1sSy4srcQ4wSHMxKIrzOyn+jhXhTEiurUovy44tKc1KLDzFKc7AoifNWMzyIFhJITyxJ zU5NLUgtgskycXBKNTAqS333Nord3GXs1/xd7ObugqtPopTe/WHU3pXlv3V94WH1HR/nq5zh eXOx6fa7V5/FjRaFZrycGvRf3PWltMxdjv+2H2N+b5v3PNNW81jxqYUcmVIlyvzOjNdruGb4 sndKVnxN+MzXYLHxSb3cx8tWPOcPp8auW3Sa/f+6dUefz5bjbX3GF31ZiaU4I9FQi7moOBEA mEfLNSkDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFIsWRmVeSWpSXmKPExsVy+t/xu7p7vP9GG+w4ImHRcC/U4kr7T3aL 00c7mC2e3TrJbLGgrZ3VYv+2f6wWx3t3sDiwezy5tpnJ4/2+q2wefVtWMQYwR+nZFOWXlqQq ZOQXl9gqRRtaGOkZWlroGZlY6hkam8daGZkq6dvZpKTmZJalFunbJehlrOrvYCvYyFpxqeEN ewPjKpYuRk4OCQETicMTG4BsLg4hgaWMEh+ndjNDJKQkfvy6wAphC0v8udbFBlH0jVGie2MH WBGbgI7EqdVHGEFsEQE3iRcPjoMVMQvcZ5Q4tmkqG0hCWMBa4vXnU2A2i4CqxJwP88EaeAWs JOZdaWOD2CAvsXrDAbChnED13/8tAYsLAdV8OvCKDaJeUOLkzCdAp3IALVCXWD9PCCTMDNTa vHU28wRGwVlIqmYhVM1CUrWAkXkVo0hqaXFuem6xkV5xYm5xaV66XnJ+7iZGYLxsO/Zzyw7G rnfBhxgFOBiVeHg3fP8dLcSaWFZcmXuIUYKDWUmE11n5b7QQb0piZVVqUX58UWlOavEhRlOg 1yYyS4km5wNjOa8k3tDU0NzC0tDc2NzYzEJJnPe8QWWUkEB6YklqdmpqQWoRTB8TB6dUA+PZ fs8PaTZVD+/mLyupsPxWkxxSMdfjXUSS0HLBU3Ls8+OvsFmY8HRb/3sss8axcu5WibXLLB7m cN08mWS1LGPvXYHLX/U5Viwtfc/y94HZ3HlLvzntWMpo5Sq0kufNfsWPCtWvcv0+HX+RMl33 I1+Zu4fGqxrzgvYI8X3RrGXX13BfXtB5VVGJpTgj0VCLuag4EQBjXVWprQIAAA== X-CMS-MailID: 20181127135052eucas1p2cec316cce9b9218e4ab476315fd4596b X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20181127135052eucas1p2cec316cce9b9218e4ab476315fd4596b X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181127135052eucas1p2cec316cce9b9218e4ab476315fd4596b References: <20181127135030.1671-1-i.maximets@samsung.com> Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 210.118.77.12 Subject: [Qemu-devel] [PATCH v2 2/4] memfd: always check for MFD_CLOEXEC X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , qemu-devel@nongnu.org, Gerd Hoffmann , Igor Mammedov , Ilya Maximets , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) QEMU always sets this flag unconditionally. We need to check if it's supported. Signed-off-by: Ilya Maximets Reviewed-by: Marc-Andr=C3=A9 Lureau --- util/memfd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/memfd.c b/util/memfd.c index 8debd0d037..d74ce4d793 100644 --- a/util/memfd.c +++ b/util/memfd.c @@ -188,7 +188,7 @@ bool qemu_memfd_alloc_check(void) bool qemu_memfd_check(unsigned int flags) { #ifdef CONFIG_LINUX - int mfd =3D memfd_create("test", flags); + int mfd =3D memfd_create("test", flags | MFD_CLOEXEC); =20 if (mfd >=3D 0) { close(mfd); --=20 2.17.1 From nobody Sat Apr 27 14:47:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=samsung.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 15433274937071022.4408424327687; Tue, 27 Nov 2018 06:04:53 -0800 (PST) Received: from localhost ([::1]:42576 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRdyu-0006F6-IM for importer@patchew.org; Tue, 27 Nov 2018 09:04:52 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRdla-0002W7-Am for qemu-devel@nongnu.org; Tue, 27 Nov 2018 08:51:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRdlW-0000HC-Bq for qemu-devel@nongnu.org; Tue, 27 Nov 2018 08:51:06 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:47788) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gRdlW-0000CJ-63 for qemu-devel@nongnu.org; Tue, 27 Nov 2018 08:51:02 -0500 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20181127135100euoutp01fb9940a93c2de058ee2cd77efaea7227~q-2vApVGp2475424754euoutp01J for ; Tue, 27 Nov 2018 13:51:00 +0000 (GMT) Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20181127135100eucas1p2f2d90cf8bb56d50464ac127f93e5de0a~q-2unAlw02251322513eucas1p2z; Tue, 27 Nov 2018 13:51:00 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id EC.E7.04441.3CB4DFB5; Tue, 27 Nov 2018 13:50:59 +0000 (GMT) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20181127135059eucas1p2371079ab1d368d8d444d6a183719cfc7~q-2tnPI-w0501505015eucas1p2N; Tue, 27 Nov 2018 13:50:59 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20181127135058eusmtrp135371bbe7f38f9f5801c4dbbeb52869c~q-2tYwoHB2189621896eusmtrp1j; Tue, 27 Nov 2018 13:50:58 +0000 (GMT) Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 16.20.04128.2CB4DFB5; Tue, 27 Nov 2018 13:50:58 +0000 (GMT) Received: from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20181127135058eusmtip12368eb14ce92f09f041c7a7ed88f6d5d~q-2swWvGB1615916159eusmtip1k; Tue, 27 Nov 2018 13:50:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20181127135100euoutp01fb9940a93c2de058ee2cd77efaea7227~q-2vApVGp2475424754euoutp01J DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1543326660; bh=G6qVNsagLahNnT1E1keUV+wN4Fdw+aYdI7s4h8/TiWc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=muLL5TY/kJBB8cUVSZkB7cIecCDzptwKvc+9whdn7OmT5YweSPnUuR6oBY+8ClKBc AsotP0sXdM55OvtOA+DrsNL3sWU217t6P+6M0HycIghUB5CoEOWoSIYnu2LTShOWWk Enqbdjf2+41cMhLcLJg0CKjfMeYaVUxKQL+TlL8Y= X-AuditID: cbfec7f2-5e3ff70000001159-59-5bfd4bc3c5af From: Ilya Maximets To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Date: Tue, 27 Nov 2018 16:50:29 +0300 Message-Id: <20181127135030.1671-4-i.maximets@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181127135030.1671-1-i.maximets@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprCKsWRmVeSWpSXmKPExsWy7djP87qHvf9GG3xfY2jRcC/U4kr7T3aL 00c7mC2e3TrJbLGgrZ3VYv+2f6wWx3t3sDiwezy5tpnJ4/2+q2wefVtWMQYwR3HZpKTmZJal FunbJXBlPL7bzFLwiqViwsUVrA2MX5i7GDk5JARMJBbOvMnSxcjFISSwglFi0a/XzBDOF0aJ +QdmskE4nxkl7n1azgbTcvjMJbB2IYHljBK/j1tDFP1glJj++gY7SIJNQEfi1OojjCC2iICb xIsHx8EmMQvcZJRY+nEBC0hCWMBF4sjTLqBJHBwsAqoScw/FgYR5Bawk/h6dzwqxTF5i9YYD YMs4Bawlvv9bwgZRIyhxcuYTsDHMQDXNW2eDnS0hMJldYtPdY1CXukjs2HKFHcIWlnh1fAuU LSNxenIPC4RdL3G/5SUjRHMH0AeH/jFBJOwltrw+xw5yHLOApsT6XfoQYUeJKVcWgoUlBPgk brwVhLiBT2LStunMEGFeiY42IYhqFYnfB5dDg1pK4ua7z1AXeEis7VvLNoFRcRaSb2Yh+WYW wt4FjMyrGMVTS4tz01OLDfNSy/WKE3OLS/PS9ZLzczcxAtPK6X/HP+1g/Hop6RCjAAejEg/v hu+/o4VYE8uKK3MPMUpwMCuJ8Dor/40W4k1JrKxKLcqPLyrNSS0+xCjNwaIkzlvN8CBaSCA9 sSQ1OzW1ILUIJsvEwSnVwBh0K3advdKitau7zI/u2tOYcuXr/XNOlrXVjxSF5k18flhaSHid vXHX40sNl886Cipf82rkWll847Rfku3VjoDdz84+7K7X8c48vOnArHlTmSp3lbNXM9UfCnmr +76G/8PztKYAqTcXLKYYfbWL2XbFvHiD7vuzC5zCE80EGDk/ihq0vLnon6bEUpyRaKjFXFSc CAAo0lFGJwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJIsWRmVeSWpSXmKPExsVy+t/xu7qHvP9GG3x+rWPRcC/U4kr7T3aL 00c7mC2e3TrJbLGgrZ3VYv+2f6wWx3t3sDiwezy5tpnJ4/2+q2wefVtWMQYwR+nZFOWXlqQq ZOQXl9gqRRtaGOkZWlroGZlY6hkam8daGZkq6dvZpKTmZJalFunbJehlPL7bzFLwiqViwsUV rA2MX5i7GDk5JARMJA6fuQRkc3EICSxllPj7eQU7REJK4sevC6wQtrDEn2tdbBBF3xglXpyd wQiSYBPQkTi1+giYLSLgJvHiwXGwImaB+4wSxzZNZQNJCAu4SBx52gW0goODRUBVYu6hOJAw r4CVxN+j86EWyEus3nAA7CJOAWuJ7/+WgLUKAdV8OvCKDaJeUOLkzCcsIGOYBdQl1s8TAgkz A7U2b53NPIFRcBaSqlkIVbOQVC1gZF7FKJJaWpybnltspFecmFtcmpeul5yfu4kRGC3bjv3c soOx613wIUYBDkYlHt4N339HC7EmlhVX5h5ilOBgVhLhdVb+Gy3Em5JYWZValB9fVJqTWnyI 0RTos4nMUqLJ+cBIziuJNzQ1NLewNDQ3Njc2s1AS5z1vUBklJJCeWJKanZpakFoE08fEwSnV wHg+5fMa2+Cb7OfjLNLLOMJ7Hu+pOuQbvuBupcbxg7knHu5bIq6aEvN/SXFWptee94+nPfra c1TyY63z3AtX2ib/rbsQr5FlLux48wvTL23bn8ujfl27++S1p0fvgYpfwWovuEMXv+jiFQ9v u/apfZOqXO5Lu00JOxJannmdle5fPPl6vKDure9KLMUZiYZazEXFiQAKTTQhrAIAAA== X-CMS-MailID: 20181127135059eucas1p2371079ab1d368d8d444d6a183719cfc7 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20181127135059eucas1p2371079ab1d368d8d444d6a183719cfc7 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181127135059eucas1p2371079ab1d368d8d444d6a183719cfc7 References: <20181127135030.1671-1-i.maximets@samsung.com> Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 210.118.77.11 Subject: [Qemu-devel] [PATCH v2 3/4] memfd: set up correct errno if not supported X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , qemu-devel@nongnu.org, Gerd Hoffmann , Igor Mammedov , Ilya Maximets , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) qemu_memfd_create() prints the value of 'errno' which is not set in this case. Signed-off-by: Ilya Maximets Reviewed-by: Marc-Andr=C3=A9 Lureau --- util/memfd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/util/memfd.c b/util/memfd.c index d74ce4d793..393d23da96 100644 --- a/util/memfd.c +++ b/util/memfd.c @@ -40,6 +40,7 @@ static int memfd_create(const char *name, unsigned int fl= ags) #ifdef __NR_memfd_create return syscall(__NR_memfd_create, name, flags); #else + errno =3D ENOSYS; return -1; #endif } --=20 2.17.1 From nobody Sat Apr 27 14:47:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=samsung.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1543327675836581.9962452652411; Tue, 27 Nov 2018 06:07:55 -0800 (PST) Received: from localhost ([::1]:42598 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRe1q-0008HN-HH for importer@patchew.org; Tue, 27 Nov 2018 09:07:54 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49601) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRdlh-0002bl-5A for qemu-devel@nongnu.org; Tue, 27 Nov 2018 08:51:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRdlc-0000XZ-RQ for qemu-devel@nongnu.org; Tue, 27 Nov 2018 08:51:13 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:51237) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gRdlc-0000Wd-Kc for qemu-devel@nongnu.org; Tue, 27 Nov 2018 08:51:08 -0500 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20181127135107euoutp02ffe370c8134f9759dc5fc0461961b33a~q-21uOOKj2313823138euoutp02W for ; Tue, 27 Nov 2018 13:51:07 +0000 (GMT) Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20181127135107eucas1p226b728235aebcd19f1edd6058553f01f~q-21GPsFx0501505015eucas1p2T; Tue, 27 Nov 2018 13:51:07 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 00.53.04806.ACB4DFB5; Tue, 27 Nov 2018 13:51:06 +0000 (GMT) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20181127135106eucas1p119ab7de9758f13ea52adc0f4829ab9cb~q-20ahf7s1194811948eucas1p11; Tue, 27 Nov 2018 13:51:06 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20181127135106eusmtrp1fda39c624463860bc16f2066d2e13afa~q-20X88IC2190321903eusmtrp1i; Tue, 27 Nov 2018 13:51:06 +0000 (GMT) Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id FB.20.04128.ACB4DFB5; Tue, 27 Nov 2018 13:51:06 +0000 (GMT) Received: from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20181127135105eusmtip1d64635d542c4e935514d139723e67db7~q-2z2J6cc1872818728eusmtip1K; Tue, 27 Nov 2018 13:51:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20181127135107euoutp02ffe370c8134f9759dc5fc0461961b33a~q-21uOOKj2313823138euoutp02W DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1543326667; bh=w4Jv8ksWorck56mIfI6cvuADBi/bwNFiq1e9hNPUSn4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Apzxyxmnwpg0fsi0l9lpQPBBcMtEXKMkGk0nRCkbqaHwLOTdXunAA6o1MLzw6o2UW lqDpCv4IjRAzELy252JICjb9G/eFGPcfhkP/MiKSE7CcZs2vi0s2PgporgB45h170g XKULyVWttZiFdDBLKRej8qGQUbdXnvmMjBpcTFuo= X-AuditID: cbfec7f5-34dff700000012c6-d3-5bfd4bca7160 From: Ilya Maximets To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Date: Tue, 27 Nov 2018 16:50:30 +0300 Message-Id: <20181127135030.1671-5-i.maximets@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181127135030.1671-1-i.maximets@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprCKsWRmVeSWpSXmKPExsWy7djP87qnvP9GG3QdNLJouBdqcaX9J7vF 6aMdzBbPbp1ktljQ1s5qsX/bP1aL4707WBzYPZ5c28zk8X7fVTaPvi2rGAOYo7hsUlJzMstS i/TtErgy/r/qYC+4wVXRcsaogfEZexcjB4eEgIlEfzdHFyMXh5DACkaJK/e/sUE4Xxglps96 wgLhfGaU+PRjDlMXIydYR+u8NVBVyxklTiz4zArh/GCUuDungx2kik1AR+LU6iOMILaIgJvE iwfHwTqYBW4ySiz9uIAFJCEsYCqx4OcnMJtFQFXiavcEsGZeASuJ5b1t7BDr5CVWbzjADGJz ClhLfP+3hA2iRlDi5MwnYL3MQDXNW2czgyyQEOhnl/hxeh0jRLOLROPaW1CDhCVeHd8CZctI nJ7cwwJh10vcb3nJCNHcAfT1oX9Qj9pLbHl9DhxMzAKaEut36UOEHSXaNjaxQUKPT+LGW0GI G/gkJm2bzgwR5pXoaBOCqFaR+H1wOTOELSVx891nqAs8JJoeNzJNYFScheSbWUi+mYWwdwEj 8ypG8dTS4tz01GLjvNRyveLE3OLSvHS95PzcTYzAtHL63/GvOxj3/Uk6xCjAwajEwxvx9Xe0 EGtiWXFl7iFGCQ5mJRFeZ+W/0UK8KYmVValF+fFFpTmpxYcYpTlYlMR5qxkeRAsJpCeWpGan phakFsFkmTg4pRoY59b5OizN6+NaaMW0Vkff/tPR68dfH3KaoWavIfH+eGD4Q/6ZzW6lCkdW LDuXN/dv4sou+b6UC4XZRld2LdJN7J3A7GuX/ntqUlAlW17y7ccCWzcIun9TnRwT3v54f9+N JKua9JMuC7NLPIOr46/ZHviXzWH44M6uyG8fFmU/37pyrtwVucdMSizFGYmGWsxFxYkAZD4R QicDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBIsWRmVeSWpSXmKPExsVy+t/xu7qnvP9GGyx/LmDRcC/U4kr7T3aL 00c7mC2e3TrJbLGgrZ3VYv+2f6wWx3t3sDiwezy5tpnJ4/2+q2wefVtWMQYwR+nZFOWXlqQq ZOQXl9gqRRtaGOkZWlroGZlY6hkam8daGZkq6dvZpKTmZJalFunbJehl/H/VwV5wg6ui5YxR A+Mz9i5GTg4JAROJ1nlr2EBsIYGljBIX7pZAxKUkfvy6wAphC0v8udYFVMMFVPONUWLZhGuM IAk2AR2JU6uPgNkiAm4SLx4cBytiFrjPKHFs01SwqcICphILfn5iAbFZBFQlrnZPANvMK2Al sby3DeoKeYnVGw4wg9icAtYS3/8tgbrISuLTgVdsEPWCEidnPgGawwG0QF1i/TwhkDAzUGvz 1tnMExgFZyGpmoVQNQtJ1QJG5lWMIqmlxbnpucVGesWJucWleel6yfm5mxiBsbLt2M8tOxi7 3gUfYhTgYFTi4d3w/Xe0EGtiWXFl7iFGCQ5mJRFeZ+W/0UK8KYmVValF+fFFpTmpxYcYTYFe m8gsJZqcD4zjvJJ4Q1NDcwtLQ3Njc2MzCyVx3vMGlVFCAumJJanZqakFqUUwfUwcnFINjFqO a6YKH00R3cv33KHQLMPyRPbCc9fasrzqL9c+MLI6Jq576mFe0EO37W9kbrRwLMg4GPJSWDvl ovHjKZoNVj92fXu1y3DdrmmyHq6GrMvfSdXI2RYEeDnd+rzhyvHXHxwyX+56P/ugStajz2fe bTk59cI+8S2PlXRktl31+DZ3Wp1RYYS9ZKISS3FGoqEWc1FxIgCtUztzqwIAAA== X-CMS-MailID: 20181127135106eucas1p119ab7de9758f13ea52adc0f4829ab9cb X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20181127135106eucas1p119ab7de9758f13ea52adc0f4829ab9cb X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181127135106eucas1p119ab7de9758f13ea52adc0f4829ab9cb References: <20181127135030.1671-1-i.maximets@samsung.com> Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 210.118.77.12 Subject: [Qemu-devel] [PATCH v2 4/4] memfd: improve error messages X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , qemu-devel@nongnu.org, Gerd Hoffmann , Igor Mammedov , Ilya Maximets , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) This gives more information about the failure. Additionally 'ENOSYS' returned for a non-Linux platforms instead of 'errno', which is not initilaized in this case. Signed-off-by: Ilya Maximets Reviewed-by: Marc-Andr=C3=A9 Lureau --- util/memfd.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/util/memfd.c b/util/memfd.c index 393d23da96..00334e5b21 100644 --- a/util/memfd.c +++ b/util/memfd.c @@ -71,14 +71,18 @@ int qemu_memfd_create(const char *name, size_t size, bo= ol hugetlb, } mfd =3D memfd_create(name, flags); if (mfd < 0) { + error_setg_errno(errp, errno, + "failed to create memfd with flags 0x%x", flags); goto err; } =20 if (ftruncate(mfd, size) =3D=3D -1) { + error_setg_errno(errp, errno, "failed to resize memfd to %zu", siz= e); goto err; } =20 if (seals && fcntl(mfd, F_ADD_SEALS, seals) =3D=3D -1) { + error_setg_errno(errp, errno, "failed to add seals 0x%x", seals); goto err; } =20 @@ -88,8 +92,9 @@ err: if (mfd >=3D 0) { close(mfd); } +#else + error_setg_errno(errp, ENOSYS, "failed to create memfd"); #endif - error_setg_errno(errp, errno, "failed to create memfd"); return -1; } =20 --=20 2.17.1