From nobody Mon Apr 29 05:25:19 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=samsung.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1543317196144425.8927047907347; Tue, 27 Nov 2018 03:13:16 -0800 (PST) Received: from localhost ([::1]:41421 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRbIh-0004Lh-4p for importer@patchew.org; Tue, 27 Nov 2018 06:13:07 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRbGu-0003Kn-1s for qemu-devel@nongnu.org; Tue, 27 Nov 2018 06:11:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRbGq-0004q9-ON for qemu-devel@nongnu.org; Tue, 27 Nov 2018 06:11:16 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:44497) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gRbGq-0004pg-IY for qemu-devel@nongnu.org; Tue, 27 Nov 2018 06:11:12 -0500 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20181127111110euoutp025215ec040b3a975f7e3d97afebd33f25~q9rL9Civp2967029670euoutp02P for ; Tue, 27 Nov 2018 11:11:10 +0000 (GMT) Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20181127111110eucas1p16790015ef54a57ebf3a118ff2058d125~q9rLj_CAL3143931439eucas1p1W; Tue, 27 Nov 2018 11:11:10 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 99.3E.04441.E462DFB5; Tue, 27 Nov 2018 11:11:10 +0000 (GMT) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20181127111109eucas1p2b1eae35e38e46c3f76c86a350ed41926~q9rK7C0JM3090630906eucas1p2R; Tue, 27 Nov 2018 11:11:09 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20181127111109eusmtrp25b327153eac821cec26b97a1515768c3~q9rK6HMGs0895908959eusmtrp2Y; Tue, 27 Nov 2018 11:11:09 +0000 (GMT) Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 82.C3.04284.D462DFB5; Tue, 27 Nov 2018 11:11:09 +0000 (GMT) Received: from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20181127111108eusmtip2382d40fa9672477f40ace356a430332c~q9rKFyBfX0663606636eusmtip2j; Tue, 27 Nov 2018 11:11:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20181127111110euoutp025215ec040b3a975f7e3d97afebd33f25~q9rL9Civp2967029670euoutp02P DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1543317070; bh=+I5YAN8Wx9z7BmOvdA2l8gQC4KQitDwzRQxGs+9+CtA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=K9FoijI7hMSLfVLWJc1HN/0SFFZiYl9ghprtzIhHzPmvC17WceaiRCMJNbD+hIP3q un0TI/xNwWVZdsXq+VFUJWbpJTE7TTJDAmryVp/q3N9M+n5tKAjVOwX2GN8oG1q9A5 K+2lX7PGQMQV8hH/bNuyoP4WFrbN8XYgQzhFu5/Y= X-AuditID: cbfec7f2-5e3ff70000001159-9d-5bfd264e692e From: Ilya Maximets To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Date: Tue, 27 Nov 2018 14:10:47 +0300 Message-Id: <20181127111050.18453-2-i.maximets@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181127111050.18453-1-i.maximets@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplleLIzCtJLcpLzFFi42LZduznOV0/tb/RBu23BCwa7oVaXGn/yW5x +mgHs8WCtnZWi/3b/rFaHO/dweLA5vHk2mYmj/f7rrJ59G1ZxRjAHMVlk5Kak1mWWqRvl8CV cWOyUMET9orFu46zNTDOZeti5OSQEDCReL3/GXsXIxeHkMAKRomjex6wQThfGCXmTDjODlIl JPCZUaJ7lQhMx7RNfSwQ8eWMEocvqUE0/GCUmDy9EyzBJqAjcWr1EUYQW0TATeLFg+NgU5kF tjFK/Fk5G6xIWMBJ4k/3RVYQm0VAVaJvxXlmEJtXwFpiz6S3rBDb5CVWbzgAFOfg4BSwkdjy UwaiRFDi5MwnYGOYgUqat85mBpkvIfCZTWJH2w1miF4Xif47t6H+FJZ4dXwLO4QtI/F/53wm CLte4n7LS0aI5g5GiemH/kEl7CW2vD7HDrKYWUBTYv0ufYiwo8Slo71gYQkBPokbbwUhbuCT mLRtOjNEmFeio00IolpF4vfB5VDXSEncfPcZ6gIPiZ+LO9knMCrOQvLNLCTfzELYu4CReRWj eGppcW56arFhXmq5XnFibnFpXrpecn7uJkZgIjn97/inHYxfLyUdYhTgYFTi4d3w/Xe0EGti WXFl7iFGCQ5mJRFeZ+W/0UK8KYmVValF+fFFpTmpxYcYpTlYlMR5qxkeRAsJpCeWpGanphak FsFkmTg4pRoYtZgMhEV+XVo6sdyi28Rx8unXf9dGnk9ZYP1+0Z+Jv80uK2bfsZj3k31x29QX dzTCt7wN/5Sz1HIm/4S6neb1OY754tI1KcmNu/eY/vX4eLHxVd2/qhnrDv28N+UeT9wmTetL d9dL6Hl9SBb6ubdpR5nr3gNdm1xdOSI4fYqvnmXfOOFowNaLX5VYijMSDbWYi4oTAd8VUtEg AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDLMWRmVeSWpSXmKPExsVy+t/xe7q+an+jDTq36lg03Au1uNL+k93i 9NEOZosFbe2sFvu3/WO1ON67g8WBzePJtc1MHu/3XWXz6NuyijGAOUrPpii/tCRVISO/uMRW KdrQwkjP0NJCz8jEUs/Q2DzWyshUSd/OJiU1J7MstUjfLkEv48ZkoYIn7BWLdx1na2Ccy9bF yMkhIWAiMW1THwuILSSwlFFi9xYXiLiUxI9fF1ghbGGJP9e6gOq5gGq+MUoc6r0IlmAT0JE4 tfoII4gtIuAm8eLBcbAiZoFdjBLXFx5hBkkICzhJ/OmGaGARUJXoW3EeLM4rYC2xZ9JbqA3y Eqs3HACKc3BwCthIbPkpA3GQtcTSFzdYIcoFJU7OfAJ2KDNQefPW2cwTGAVmIUnNQpJawMi0 ilEktbQ4Nz232FCvODG3uDQvXS85P3cTIzDktx37uXkH46WNwYcYBTgYlXh4N3z/HS3EmlhW XJl7iFGCg1lJhNdZ+W+0EG9KYmVValF+fFFpTmrxIUZToB8mMkuJJucD4zGvJN7Q1NDcwtLQ 3Njc2MxCSZz3vEFllJBAemJJanZqakFqEUwfEwenVAPjfOsZk07dP+etdX3DfTY2Ry61e96q s2a+rm3XDteVO7Lj6BpnhzibpUylFjL/3vRwdE5lZPkjoRxQevtNqdKCVW2cC4ssjq9OlTRZ fJnl/V/B42LCcqsv651Ovlz6Y3++TFvOB2m3E3cdPzUf53yrssL7tt7G2xx6czfeDA0r8E5h fxXix2etxFKckWioxVxUnAgAeIOzjY8CAAA= X-CMS-MailID: 20181127111109eucas1p2b1eae35e38e46c3f76c86a350ed41926 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20181127111109eucas1p2b1eae35e38e46c3f76c86a350ed41926 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181127111109eucas1p2b1eae35e38e46c3f76c86a350ed41926 References: <20181127111050.18453-1-i.maximets@samsung.com> Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 210.118.77.12 Subject: [Qemu-devel] [PATCH 1/4] hostmem-memfd: enable seals only if supported X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ilya Maximets , Paolo Bonzini , Igor Mammedov , qemu-devel@nongnu.org, Eduardo Habkost Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) If seals are not supported, memfd_create() will fail. Furthermore, there is no way to disable it in this case because '.seal' property is not registered. This issue leads to vhost-user-test failures on RHEL 7.2: qemu-system-x86_64: -object memory-backend-memfd,id=3Dmem,size=3D2M,: \ failed to create memfd: Invalid argument Signed-off-by: Ilya Maximets --- backends/hostmem-memfd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/backends/hostmem-memfd.c b/backends/hostmem-memfd.c index b6836b28e5..ee39bdbde6 100644 --- a/backends/hostmem-memfd.c +++ b/backends/hostmem-memfd.c @@ -129,8 +129,8 @@ memfd_backend_instance_init(Object *obj) { HostMemoryBackendMemfd *m =3D MEMORY_BACKEND_MEMFD(obj); =20 - /* default to sealed file */ - m->seal =3D true; + /* default to sealed file if supported */ + m->seal =3D qemu_memfd_check(MFD_ALLOW_SEALING); } =20 static void --=20 2.17.1 From nobody Mon Apr 29 05:25:19 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=samsung.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 154331721456320.87944896041131; Tue, 27 Nov 2018 03:13:34 -0800 (PST) Received: from localhost ([::1]:41422 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRbJ1-000526-VX for importer@patchew.org; Tue, 27 Nov 2018 06:13:28 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRbH2-0003PV-84 for qemu-devel@nongnu.org; Tue, 27 Nov 2018 06:11:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRbGw-0004rw-4K for qemu-devel@nongnu.org; Tue, 27 Nov 2018 06:11:22 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:40886) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gRbGu-0004rH-Sp for qemu-devel@nongnu.org; Tue, 27 Nov 2018 06:11:17 -0500 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20181127111115euoutp017b396c2d699ae546bae4f6b8130dc027~q9rQoX2Za3199131991euoutp01C for ; Tue, 27 Nov 2018 11:11:15 +0000 (GMT) Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20181127111115eucas1p22af8bf415a250e13793e11e84fd945a3~q9rQJdvCh2353123531eucas1p2z; Tue, 27 Nov 2018 11:11:15 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id D7.94.04294.3562DFB5; Tue, 27 Nov 2018 11:11:15 +0000 (GMT) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20181127111114eucas1p21c991b4dd272c8afa803f90c178030a6~q9rPaRkK73088430884eucas1p2W; Tue, 27 Nov 2018 11:11:14 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20181127111114eusmtrp268bfc4f153311b05a7804d5b40ede488~q9rPLynFJ0920809208eusmtrp2J; Tue, 27 Nov 2018 11:11:14 +0000 (GMT) Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 53.38.04128.2562DFB5; Tue, 27 Nov 2018 11:11:14 +0000 (GMT) Received: from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20181127111113eusmtip219975332f8c3bde32ff3dbebc5545014~q9rOn8JaT0664206642eusmtip2k; Tue, 27 Nov 2018 11:11:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20181127111115euoutp017b396c2d699ae546bae4f6b8130dc027~q9rQoX2Za3199131991euoutp01C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1543317076; bh=P9v38u6q/nuWDQJkCKv8rOu6gSWpo/bswUVgNqIWWT8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pDaFYC4Ow4/KdbMCJuIIZo+dAwHmSZyR01wB4okR4VYiIQaeV/9UhpFUcjKq9rqER +6AOhcmkBvmvx9ixcN6XEbhpS2d2oCBWUBgbeGYl58mhWbGqhXCpm0fqV44AvwXRev 5ywTT9yGZVhmJTDF8LUaahLfsKHrFrqO1aPpi6IM= X-AuditID: cbfec7f4-835ff700000010c6-e7-5bfd265391c0 From: Ilya Maximets To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Date: Tue, 27 Nov 2018 14:10:48 +0300 Message-Id: <20181127111050.18453-3-i.maximets@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181127111050.18453-1-i.maximets@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplleLIzCtJLcpLzFFi42LZduznOd1gtb/RBr+Xcls03Au1uNL+k93i 9NEOZosFbe2sFvu3/WO1ON67g8WBzePJtc1MHu/3XWXz6NuyijGAOYrLJiU1J7MstUjfLoEr 49+mH+wFn1gqTv36yNzA+IG5i5GTQ0LARGLP3yfsXYxcHEICKxglGiZ/YIRwvjBK7N98jhnC +cwo8ffoakaYlgUH/jJBJJYzSkz++ZQFJCEk8INRYuKWIBCbTUBH4tTqI2ANIgJuEi8eHGcD aWAW2MYo8WflbLAGYQELiWUzVoLZLAKqEk23ToDZvALWQBvmsENsk5dYveEA0BkcHJwCNhJb fspAlAhKnJz5BKycGaikeetssEslBL6zSUy9uoQJpF5CwEXi0hRXiDHCEq+Ob4EaKSPxf+d8 Jgi7XuJ+y0tGiN4ORonph/5BJewltrw+xw4yh1lAU2L9Ln2IsKPE5Ms72SDG80nceCsIcQKf xKRt05khwrwSHW1CENUqEr8PLoeGtJTEzXef2SFKPCR63ydPYFScheSXWUh+mYWwdgEj8ypG 8dTS4tz01GKjvNRyveLE3OLSvHS95PzcTYzARHL63/EvOxh3/Uk6xCjAwajEw7vh++9oIdbE suLK3EOMEhzMSiK8zsp/o4V4UxIrq1KL8uOLSnNSiw8xSnOwKInzVjM8iBYSSE8sSc1OTS1I LYLJMnFwSjUwZiTtYN4y/XI+X0DilYeBrDf6Jm5Pac6rOGqo75s3u++I60o9t3kXN1bxnTt0 reiw4//ny3z4JUM6607umvCsYk/2wV1Hv/T8NrT16rgw7f6JlhLPQx9XRS9kfGHOsXTJ9A0T Nt197e2/4bGq8Ga/nFh778l/otQXvMrJv/xmhf9Gzt27arKuSymxFGckGmoxFxUnAgAwWMSw IAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHLMWRmVeSWpSXmKPExsVy+t/xe7pBan+jDX7+EbZouBdqcaX9J7vF 6aMdzBYL2tpZLfZv+8dqcbx3B4sDm8eTa5uZPN7vu8rm0bdlFWMAc5SeTVF+aUmqQkZ+cYmt UrShhZGeoaWFnpGJpZ6hsXmslZGpkr6dTUpqTmZZapG+XYJexr9NP9gLPrFUnPr1kbmB8QNz FyMnh4SAicSCA3+Zuhi5OIQEljJKPF72gw0iISXx49cFVghbWOLPtS42iKJvjBKPWvazgCTY BHQkTq0+wghiiwi4Sbx4cBysiFlgF6PE9YVHwFYIC1hILJuxEqyBRUBVounWCTCbV8AaaPUc dogN8hKrNxwAqufg4BSwkdjyUwYkLARUsvTFDVaIckGJkzOfgLUyA5U3b53NPIFRYBaS1Cwk qQWMTKsYRVJLi3PTc4uN9IoTc4tL89L1kvNzNzECw37bsZ9bdjB2vQs+xCjAwajEw7vh++9o IdbEsuLK3EOMEhzMSiK8zsp/o4V4UxIrq1KL8uOLSnNSiw8xmgL9MJFZSjQ5HxiTeSXxhqaG 5haWhubG5sZmFkrivOcNKqOEBNITS1KzU1MLUotg+pg4OKUaGIXKjyZbPbSNkwi0K5r1Lv6D 1IsvL423SlrtOPUlS4JzZZVxiJIVS98z18fljxwW+x2cHZfidd5IdLeKe45XeMCz5NzHKw4f UZPjdJvFs9lurc/UwnkOGuHP1/i1vo6/IC2zdsuDVG2tzdapM9atKhRjK913gFUhYwKvWHMb 078b4Qfzg10ClViKMxINtZiLihMBwZ31ZpECAAA= X-CMS-MailID: 20181127111114eucas1p21c991b4dd272c8afa803f90c178030a6 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20181127111114eucas1p21c991b4dd272c8afa803f90c178030a6 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181127111114eucas1p21c991b4dd272c8afa803f90c178030a6 References: <20181127111050.18453-1-i.maximets@samsung.com> Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 210.118.77.11 Subject: [Qemu-devel] [PATCH 2/4] memfd: always check for MFD_CLOEXEC X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ilya Maximets , Paolo Bonzini , Igor Mammedov , qemu-devel@nongnu.org, Eduardo Habkost Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) QEMU always sets this flag unconditionally. We need to check if it's supported. Signed-off-by: Ilya Maximets Reviewed-by: Marc-Andr=C3=A9 Lureau --- util/memfd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/memfd.c b/util/memfd.c index 8debd0d037..d74ce4d793 100644 --- a/util/memfd.c +++ b/util/memfd.c @@ -188,7 +188,7 @@ bool qemu_memfd_alloc_check(void) bool qemu_memfd_check(unsigned int flags) { #ifdef CONFIG_LINUX - int mfd =3D memfd_create("test", flags); + int mfd =3D memfd_create("test", flags | MFD_CLOEXEC); =20 if (mfd >=3D 0) { close(mfd); --=20 2.17.1 From nobody Mon Apr 29 05:25:19 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=samsung.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1543317223066270.80642484561713; Tue, 27 Nov 2018 03:13:43 -0800 (PST) Received: from localhost ([::1]:41423 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRbJF-0005nc-Br for importer@patchew.org; Tue, 27 Nov 2018 06:13:41 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51309) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRbHD-0003Zw-8u for qemu-devel@nongnu.org; Tue, 27 Nov 2018 06:11:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRbH9-0004uo-Bx for qemu-devel@nongnu.org; Tue, 27 Nov 2018 06:11:35 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:40915) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gRbH1-0004sK-T6 for qemu-devel@nongnu.org; Tue, 27 Nov 2018 06:11:24 -0500 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20181127111119euoutp01dc4e9e4c525817ad5b6a2f1dfec8bca9~q9rT6PSFW3199131991euoutp01E for ; Tue, 27 Nov 2018 11:11:19 +0000 (GMT) Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20181127111119eucas1p10a7010b5240940d40a6e4d2865f8dde6~q9rTfe72l1022410224eucas1p1b; Tue, 27 Nov 2018 11:11:19 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 7A.A9.04806.6562DFB5; Tue, 27 Nov 2018 11:11:18 +0000 (GMT) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20181127111118eucas1p1b76423fb92768a8501aea2a1dbb512fd~q9rS2zmmO1034610346eucas1p1y; Tue, 27 Nov 2018 11:11:18 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20181127111118eusmtrp2226510b24e4db9b1b1ebc9f52e588e95~q9rSoYxfT0920809208eusmtrp2Z; Tue, 27 Nov 2018 11:11:18 +0000 (GMT) Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id E4.38.04128.6562DFB5; Tue, 27 Nov 2018 11:11:18 +0000 (GMT) Received: from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20181127111117eusmtip251f32ab60e000513f96df64e063aa5b4~q9rSJk1Ln0816608166eusmtip2l; Tue, 27 Nov 2018 11:11:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20181127111119euoutp01dc4e9e4c525817ad5b6a2f1dfec8bca9~q9rT6PSFW3199131991euoutp01E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1543317079; bh=kVAzmWEtBqyzt4QZcnkwpd4TgPQtM+zAIq6vUXmzZfA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HBTRayuJvMR/LSgCqGak3nD5KGgpusrKH+lCEakXBxLmTxOp3sfj0Pg0tdzEOUH1s o4+ZA5jfyEqTsCIinDGQft8Su2GRYF5OqDk8G8hYHRuToTxiw/EGzrrphO7zT2TLW+ aMun7H5sAwr04oQZwT0fI9a79HQAVVkhax61iiIM= X-AuditID: cbfec7f5-34dff700000012c6-f1-5bfd2656901b From: Ilya Maximets To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Date: Tue, 27 Nov 2018 14:10:49 +0300 Message-Id: <20181127111050.18453-4-i.maximets@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181127111050.18453-1-i.maximets@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmleLIzCtJLcpLzFFi42LZduzned0wtb/RBiumGFg03Au1uNL+k93i 9NEOZosFbe2sFvu3/WO1ON67g8WBzePJtc1MHu/3XWXz6NuyijGAOYrLJiU1J7MstUjfLoEr o2n1Z9aC1SwV0x6uZW1g3MXcxcjJISFgIvF11kl2EFtIYAWjxNMrQV2MXED2F0aJJ4dOMEI4 nxklDl95Dtdx/usqRoiO5YwS1/epQhT9YJRY/20hK0iCTUBH4tTqI2BFIgJuEi8eHGcDKWIW 2MYo8WflbBaQhLCAo8THQ5vBGlgEVCW+fLkNFucVsJaY9Pkp1DZ5idUbDgDZHBycAjYSW37K QJQISpyc+QSsnBmopHnrbGaQ+RIC39kk1vb9YYXodZFoOPASyhaWeHV8CzuELSPxf+d8Jgi7 XuJ+y0tGiOYORonph/5BJewltrw+xw6ymFlAU2L9Lv0uRnagsKPEMWGQoIQAn8SNt4IQF/BJ TNo2nRkizCvR0SYEMUJF4vfB5VB/SEncfPeZHaLEQ+LR9rIJjIqzkLwyC8krsxCWLmBkXsUo nlpanJueWmycl1quV5yYW1yal66XnJ+7iRGYRE7/O/51B+O+P0mHGAU4GJV4eCO+/o4WYk0s K67MPcQowcGsJMLrrPw3Wog3JbGyKrUoP76oNCe1+BCjNAeLkjhvNcODaCGB9MSS1OzU1ILU IpgsEwenVANj976aT6GScfee735a6au98MOmjZfcGHinF/zr6n1w2ZLv8fvolW85S56ctbR+ aFFi8KxfyvH7s93e8Sv8C1wczwuL8ayqj9eUt1v9Nigt4dDlpNKLO0WTmBi+5m3dYFBvJvr5 yZ6zEeHv6te0FUqVTK290nwsx/jchO9PC7t1CvkElv0qMT6uxFKckWioxVxUnAgA+Bbsbh4D AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHLMWRmVeSWpSXmKPExsVy+t/xe7phan+jDVYfYLFouBdqcaX9J7vF 6aMdzBYL2tpZLfZv+8dqcbx3B4sDm8eTa5uZPN7vu8rm0bdlFWMAc5SeTVF+aUmqQkZ+cYmt UrShhZGeoaWFnpGJpZ6hsXmslZGpkr6dTUpqTmZZapG+XYJeRtPqz6wFq1kqpj1cy9rAuIu5 i5GTQ0LAROL811WMXYxcHEICSxklJk//zAiRkJL48esCK4QtLPHnWhcbRNE3RoktV9rBEmwC OhKnVh8BaxARcJN48eA4WBGzwC5GiesLj4CtEBZwlPh4aDNYA4uAqsSXL7dZQGxeAWuJSZ+f Qp0hL7F6wwEgm4ODU8BGYstPGZCwEFDJ0hc3WCHKBSVOznwC1soMVN68dTbzBEaBWUhSs5Ck FjAyrWIUSS0tzk3PLTbSK07MLS7NS9dLzs/dxAgM+23Hfm7Zwdj1LvgQowAHoxIP74bvv6OF WBPLiitzDzFKcDArifA6K/+NFuJNSaysSi3Kjy8qzUktPsRoCvTDRGYp0eR8YEzmlcQbmhqa W1gamhubG5tZKInznjeojBISSE8sSc1OTS1ILYLpY+LglGpg9O5dme/lVSu9quXGc67y3Ude nWmxflOtOEF92bOgpVOrz31QmbztX2Kk7fUaiW8Gx1xXsv2zCUg4LSccuTHxpk7R5h/7Z2kp fp6QvjU03ffYawdNgXmralQDYo7sb5whE8X3XPbYNMaXvgu8vpceOHt/eVPIim07DjoI3rP6 4MMnPOP9v6dvipVYijMSDbWYi4oTAX5aOACRAgAA X-CMS-MailID: 20181127111118eucas1p1b76423fb92768a8501aea2a1dbb512fd X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20181127111118eucas1p1b76423fb92768a8501aea2a1dbb512fd X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181127111118eucas1p1b76423fb92768a8501aea2a1dbb512fd References: <20181127111050.18453-1-i.maximets@samsung.com> Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 210.118.77.11 Subject: [Qemu-devel] [PATCH 3/4] memfd: set up correct errno if not supported X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ilya Maximets , Paolo Bonzini , Igor Mammedov , qemu-devel@nongnu.org, Eduardo Habkost Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) qemu_memfd_create() prints the value of 'errno' which is not set in this case. Signed-off-by: Ilya Maximets Reviewed-by: Marc-Andr=C3=A9 Lureau --- util/memfd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/util/memfd.c b/util/memfd.c index d74ce4d793..393d23da96 100644 --- a/util/memfd.c +++ b/util/memfd.c @@ -40,6 +40,7 @@ static int memfd_create(const char *name, unsigned int fl= ags) #ifdef __NR_memfd_create return syscall(__NR_memfd_create, name, flags); #else + errno =3D ENOSYS; return -1; #endif } --=20 2.17.1 From nobody Mon Apr 29 05:25:19 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=samsung.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1543317315510665.6856858198785; Tue, 27 Nov 2018 03:15:15 -0800 (PST) Received: from localhost ([::1]:41440 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRbKj-000789-Hi for importer@patchew.org; Tue, 27 Nov 2018 06:15:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51330) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRbHE-0003Zy-KA for qemu-devel@nongnu.org; Tue, 27 Nov 2018 06:11:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRbHB-0004vf-Ad for qemu-devel@nongnu.org; Tue, 27 Nov 2018 06:11:36 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:40947) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gRbH8-0004tX-Cv for qemu-devel@nongnu.org; Tue, 27 Nov 2018 06:11:31 -0500 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20181127111124euoutp01680407ac30315986931326f54aee8199~q9rY0jA9s0050900509euoutp01E for ; Tue, 27 Nov 2018 11:11:24 +0000 (GMT) Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20181127111124eucas1p13f112f28bb5ecaeb6f00a69a7d338200~q9rYZu66B0280002800eucas1p1e; Tue, 27 Nov 2018 11:11:24 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 9E.A9.04806.B562DFB5; Tue, 27 Nov 2018 11:11:24 +0000 (GMT) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20181127111123eucas1p15ecbe14062e47527e59ae7d219e3879c~q9rXni2et1032210322eucas1p1n; Tue, 27 Nov 2018 11:11:23 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20181127111123eusmtrp12d521cb50929d3db6d269d4d0f12e69a~q9rXZFTTG0472404724eusmtrp1Y; Tue, 27 Nov 2018 11:11:23 +0000 (GMT) Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 1A.C3.04284.B562DFB5; Tue, 27 Nov 2018 11:11:23 +0000 (GMT) Received: from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20181127111121eusmtip2d9d9bdf2190b08cc06bdc14ee22358c2~q9rWK8LlU0663706637eusmtip2f; Tue, 27 Nov 2018 11:11:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20181127111124euoutp01680407ac30315986931326f54aee8199~q9rY0jA9s0050900509euoutp01E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1543317084; bh=upD3DP832gpciamOTlt+BNACQXOA2tcDeTk/eGURqvQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Lq7GYUiOYeAiCdukfjKFjTqeCnfiB1HRNRLZEMtjex8ISYFJmiNj5LSOmBU7oxdf5 Yh0PZ4h0mldlqqozzPJDDu2SnA7nrPN1lucTyZMZ66WK12FRui+ET1mq6Djv5ziYrv TRvS5B+7TdKtJyVzMcCIlUl2MnYHUOp303o7wgec= X-AuditID: cbfec7f5-367ff700000012c6-04-5bfd265b870c From: Ilya Maximets To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Date: Tue, 27 Nov 2018 14:10:50 +0300 Message-Id: <20181127111050.18453-5-i.maximets@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181127111050.18453-1-i.maximets@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42LZduznOd0Ytb/RBseXM1s03Au1uNL+k93i 9NEOZosFbe2sFvu3/WO1ON67g8WBzePJtc1MHu/3XWXz6NuyijGAOYrLJiU1J7MstUjfLoEr Y/m7bywFM7kq1i+6x9rAuIa9i5GTQ0LAROLyjx9sXYxcHEICKxglrrx+xgrhfGGUePp+GZTz mVHi7IbjcC1LLt1nh0gsZ5TYsuc0M4Tzg1HiztM9LCBVbAI6EqdWH2EEsUUE3CRePDgOtoRZ YBujxJ+Vs4GKODiEBYwkdjyJB6lhEVCV+PlzHyuIzStgLfFuwU1GiG3yEqs3HGAGKecUsJHY 8lMGokRQ4uTMJ2CrmIFKmrfOZoYo/80m0f1NEsJ2keg9844NwhaWeHV8C9QDMhKnJ/ewQNj1 EvdbXjKCnCYh0MEoMf3QPyaIhL3Eltfn2EH2MgtoSqzfpQ8RdpS4dOYWE0hYQoBP4sZbQYgT +CQmbZvODBHmlehoE4KoVpH4fXA51GVSEjfffYa6wEPi9403rBMYFWcheWYWkmdmIexdwMi8 ilE8tbQ4Nz212DgvtVyvODG3uDQvXS85P3cTIzCVnP53/OsOxn1/kg4xCnAwKvHwRnz9HS3E mlhWXJl7iFGCg1lJhNdZ+W+0EG9KYmVValF+fFFpTmrxIUZpDhYlcd5qhgfRQgLpiSWp2amp BalFMFkmDk6pBkYGljZZlXOzWc/Ml6x/emmGyvHHCvOLH1/t/LSa2VJyxTd+rZdPEh411Bkc rWZeyCObcsqh2N3eg/Xyfv3vVgejn5sHmmns1ZK+8O0YV8WniCcrpIRSm00Dl3wIFxWp29fV rhluXyy5yd7juNmGHUbayTzVjaLuFWvr3s89muzp/HJ+xXuzxUosxRmJhlrMRcWJAKGuj4Qh AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrLLMWRmVeSWpSXmKPExsVy+t/xe7rRan+jDQ5/ZLdouBdqcaX9J7vF 6aMdzBYL2tpZLfZv+8dqcbx3B4sDm8eTa5uZPN7vu8rm0bdlFWMAc5SeTVF+aUmqQkZ+cYmt UrShhZGeoaWFnpGJpZ6hsXmslZGpkr6dTUpqTmZZapG+XYJexvJ331gKZnJVrF90j7WBcQ17 FyMnh4SAicSSS/eBbC4OIYGljBJ/psxig0hISfz4dYEVwhaW+HOtiw2i6BujxMQjLUwgCTYB HYlTq48wgtgiAm4SLx4cBytiFtjFKHF94RHmLkYODmEBI4kdT+JBalgEVCV+/twHNpRXwFri 3YKbjBAL5CVWbzgAVs4pYCOx5acMSFgIqGTpixtQ5YISJ2c+YQGxmYHKm7fOZp7AKDALSWoW ktQCRqZVjCKppcW56bnFhnrFibnFpXnpesn5uZsYgUG/7djPzTsYL20MPsQowMGoxMO74fvv aCHWxLLiytxDjBIczEoivM7Kf6OFeFMSK6tSi/Lji0pzUosPMZoC/TCRWUo0OR8YkXkl8Yam huYWlobmxubGZhZK4rznDSqjhATSE0tSs1NTC1KLYPqYODilGhhLyhxDj4UdcbzHcWPZecVt V8QMzFcIPRRI9GznvJ0TdNr2+5stjw+8en8x2aJZs8hYp2Qf572FMytuLpPy9BTgrPn1XaCk /f6UPH0G0xV7brSarTHqtlqj/3bmq7l3/7Us3nx872npNzu7OmuCAuyNFrl2B/LHcNxr+SfZ WL73apcr0wHR26lKLMUZiYZazEXFiQB5KSi3kAIAAA== X-CMS-MailID: 20181127111123eucas1p15ecbe14062e47527e59ae7d219e3879c X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20181127111123eucas1p15ecbe14062e47527e59ae7d219e3879c X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181127111123eucas1p15ecbe14062e47527e59ae7d219e3879c References: <20181127111050.18453-1-i.maximets@samsung.com> Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 210.118.77.11 Subject: [Qemu-devel] [PATCH 4/4] memfd: improve error messages X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ilya Maximets , Paolo Bonzini , Igor Mammedov , qemu-devel@nongnu.org, Eduardo Habkost Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) This gives more information about the failure. Additionally 'ENOSYS' returned for a non-Linux platforms instead of 'errno', which is not initilaized in this case. Signed-off-by: Ilya Maximets Reviewed-by: Marc-Andr=C3=A9 Lureau --- util/memfd.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/util/memfd.c b/util/memfd.c index 393d23da96..00334e5b21 100644 --- a/util/memfd.c +++ b/util/memfd.c @@ -71,14 +71,18 @@ int qemu_memfd_create(const char *name, size_t size, bo= ol hugetlb, } mfd =3D memfd_create(name, flags); if (mfd < 0) { + error_setg_errno(errp, errno, + "failed to create memfd with flags 0x%x", flags); goto err; } =20 if (ftruncate(mfd, size) =3D=3D -1) { + error_setg_errno(errp, errno, "failed to resize memfd to %zu", siz= e); goto err; } =20 if (seals && fcntl(mfd, F_ADD_SEALS, seals) =3D=3D -1) { + error_setg_errno(errp, errno, "failed to add seals 0x%x", seals); goto err; } =20 @@ -88,8 +92,9 @@ err: if (mfd >=3D 0) { close(mfd); } +#else + error_setg_errno(errp, ENOSYS, "failed to create memfd"); #endif - error_setg_errno(errp, errno, "failed to create memfd"); return -1; } =20 --=20 2.17.1