From nobody Mon Feb 9 18:27:19 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1543273606181481.743631387396; Mon, 26 Nov 2018 15:06:46 -0800 (PST) Received: from localhost ([::1]:39240 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRPxg-0003WT-CE for importer@patchew.org; Mon, 26 Nov 2018 18:06:40 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43060) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRPw3-0002ZO-Rx for qemu-devel@nongnu.org; Mon, 26 Nov 2018 18:05:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRPw0-0000Gk-BB for qemu-devel@nongnu.org; Mon, 26 Nov 2018 18:04:59 -0500 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]:35340) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gRPw0-0000Gc-69 for qemu-devel@nongnu.org; Mon, 26 Nov 2018 18:04:56 -0500 Received: by mail-pg1-x541.google.com with SMTP id s198so6879865pgs.2 for ; Mon, 26 Nov 2018 15:04:56 -0800 (PST) Received: from cloudburst.twiddle.net (97-113-170-180.tukw.qwest.net. [97.113.170.180]) by smtp.gmail.com with ESMTPSA id o13sm1798703pfk.57.2018.11.26.15.04.53 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Nov 2018 15:04:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references; bh=dpjKuA4SMUMijsyMzZSjISWd0OJDtOFutwkwA5Mu2Bk=; b=CFzKqbqG5fNEI1mvsih4XhDtu/lBo5Um01PgxgXvJs8OBn43Cw3sC1T5GvBqIJ0EZ+ 4kWOgWlEPwg64UNTmg0uwnS3nI4jXPWFclHtNrCLVZUfVR3ZCenAcyNieRWrdqpJde4U +VccPznnoYPgxSoZOYoNHpym4nz4LZIfS547A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=dpjKuA4SMUMijsyMzZSjISWd0OJDtOFutwkwA5Mu2Bk=; b=QqcZanid8sAAHC+re05tBvEMc7t2mFO3hCsjzERk+QYOH2q1Opr/ntp5w07L1SSMlo /oEnfwsjvB4dCZa+WqbuUAXYpb7M/OIDqe0Vy11IstPxJ1QmXco/51Z/8eHCeqsdBI/Y 8XUwImfEatrk5JMs+GgA/gFnh/CD9a5eXWaGCh3N+MjbBYUUsRxMfSiBw6Z6hxV3Gffb rM4RxNaATNKN7cxKa6gqkjSuUjIIKa0fuR4CRGXfO6OWXGW4mKrWociDszknAHV4ayGW h+KWuwaWEiicvT1yekCx+qGdBzSk4oQlc74XHVT+fMBxVr9rSs7/KVKYGZVq4ABsYGd1 Jd8w== X-Gm-Message-State: AA+aEWaKncUrSLF8BepWhoZ+XMp7S9L15z5TqSgNkiath+SObZs1gEUa amZ4xnxwl6r6Y3uarnaToFg9d/VZ5vA= X-Google-Smtp-Source: AFSGD/W4dhtRH4LSb8kaIDwiD94H8eQgS1nRRy01pntD+hbWZD+/saatSECFfqfKw1Dp7z0A8mcVqA== X-Received: by 2002:a63:ef47:: with SMTP id c7mr27044868pgk.386.1543273494726; Mon, 26 Nov 2018 15:04:54 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 26 Nov 2018 15:04:47 -0800 Message-Id: <20181126230450.672-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181126230450.672-1-richard.henderson@linaro.org> References: <20181126230450.672-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::541 Subject: [Qemu-devel] [PATCH 1/4] tcg: Renumber TCG_CALL_* flags X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Previously, the low 4 bits were used for TCG_CALL_TYPE_MASK, which was removed in 6a18ae2d2947532d5c26439548afa0481c4529f9. Signed-off-by: Richard Henderson --- tcg/tcg.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tcg/tcg.h b/tcg/tcg.h index 73737dc671..e94f805370 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -464,11 +464,11 @@ typedef TCGv_ptr TCGv_env; /* call flags */ /* Helper does not read globals (either directly or through an exception).= It implies TCG_CALL_NO_WRITE_GLOBALS. */ -#define TCG_CALL_NO_READ_GLOBALS 0x0010 +#define TCG_CALL_NO_READ_GLOBALS 0x0001 /* Helper does not write globals */ -#define TCG_CALL_NO_WRITE_GLOBALS 0x0020 +#define TCG_CALL_NO_WRITE_GLOBALS 0x0002 /* Helper can be safely suppressed if the return value is not used. */ -#define TCG_CALL_NO_SIDE_EFFECTS 0x0040 +#define TCG_CALL_NO_SIDE_EFFECTS 0x0004 =20 /* convenience version of most used call flags */ #define TCG_CALL_NO_RWG TCG_CALL_NO_READ_GLOBALS --=20 2.17.2 From nobody Mon Feb 9 18:27:19 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 15432736067471014.6183516487689; Mon, 26 Nov 2018 15:06:46 -0800 (PST) Received: from localhost ([::1]:39241 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRPxh-0003aG-IE for importer@patchew.org; Mon, 26 Nov 2018 18:06:41 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43059) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRPw3-0002ZN-Rv for qemu-devel@nongnu.org; Mon, 26 Nov 2018 18:05:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRPw1-0000Gv-NX for qemu-devel@nongnu.org; Mon, 26 Nov 2018 18:04:59 -0500 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]:46839) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gRPw1-0000Gp-IL for qemu-devel@nongnu.org; Mon, 26 Nov 2018 18:04:57 -0500 Received: by mail-pg1-x542.google.com with SMTP id w7so6858742pgp.13 for ; Mon, 26 Nov 2018 15:04:57 -0800 (PST) Received: from cloudburst.twiddle.net (97-113-170-180.tukw.qwest.net. [97.113.170.180]) by smtp.gmail.com with ESMTPSA id o13sm1798703pfk.57.2018.11.26.15.04.54 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Nov 2018 15:04:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references; bh=+rd8f0EuKeLcBkc84eNzbeuWs4zuLZUL/ehXCsMsyMI=; b=KeNi0Hd9x55Vd/RffJf7qe1LHe+fRGIzspyfMVYNwNj1gMwrPiJVaq8HWSO7rqhbeU OGbTLU22Xi69gWvmmD3BJ1wCSE2VRHjHMLA9yVZQ+CBLJp8a3DcnOVhNMttSEZpqG9Ro atRJUAaFEbtTLz4ZA+4XFoe4HF3kwVezRjUn4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=+rd8f0EuKeLcBkc84eNzbeuWs4zuLZUL/ehXCsMsyMI=; b=gXDaxb1l7McVat9rlRkZSIVEoG2Jfpb+menwcpzagcGLH2vJSjs2iekaaTABMx9vse VtuPUx3x6EhHKnaQUPnkoEQhRpbLMo4BstzL+RS5eWU0feRCAQmTCwrx9Yhf2XxbV3q7 zEwNV2OnEriQlbnF43RFMZOp03XrPkdV4vrwaoQQtb3xEBRHZTbipFhCS2XwqOju95uf 4aZbEdVHN6Kc8nPesIgtmL39gMZoXggsUxrcnGE6HMKTLDkjf00CEIJ3kDFhSY0tH1nF DILiykQ2uNelYjKmAROBNp85waZDxRjR464oNvTwksyi+vE5BriGfLzmWC5ihOHtozYa jJlg== X-Gm-Message-State: AA+aEWbPUPDWQI8p+340o6A70DJg6CfT3PoPzLt+GGfIH6BkxEynt321 WhFQRErQMUQlyFE7/ZLH+9dRt1oT6Yc= X-Google-Smtp-Source: AFSGD/XffQ0yoVkuq+odjbI0rRPvo90+EoHY59KnkdGusspcKlA7q54EG0SPvB5/VZQss1FRXus/ZA== X-Received: by 2002:a65:55ca:: with SMTP id k10mr26600240pgs.448.1543273496225; Mon, 26 Nov 2018 15:04:56 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 26 Nov 2018 15:04:48 -0800 Message-Id: <20181126230450.672-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181126230450.672-1-richard.henderson@linaro.org> References: <20181126230450.672-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::542 Subject: [Qemu-devel] [PATCH 2/4] tcg: Add TCG_CALL_NO_RETURN X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Remember which helpers have been marked noreturn. Signed-off-by: Richard Henderson --- include/exec/helper-head.h | 13 +++++++++++++ include/exec/helper-tcg.h | 21 ++++++++++++++------- tcg/tcg.h | 2 ++ 3 files changed, 29 insertions(+), 7 deletions(-) diff --git a/include/exec/helper-head.h b/include/exec/helper-head.h index 276dd5afce..ab4f8b6623 100644 --- a/include/exec/helper-head.h +++ b/include/exec/helper-head.h @@ -108,6 +108,19 @@ #define dh_is_signed_env dh_is_signed_ptr #define dh_is_signed(t) dh_is_signed_##t =20 +#define dh_callflag_i32 0 +#define dh_callflag_s32 0 +#define dh_callflag_int 0 +#define dh_callflag_i64 0 +#define dh_callflag_s64 0 +#define dh_callflag_f16 0 +#define dh_callflag_f32 0 +#define dh_callflag_f64 0 +#define dh_callflag_ptr 0 +#define dh_callflag_void 0 +#define dh_callflag_noreturn TCG_CALL_NO_RETURN +#define dh_callflag(t) glue(dh_callflag_, dh_alias(t)) + #define dh_sizemask(t, n) \ ((dh_is_64bit(t) << (n*2)) | (dh_is_signed(t) << (n*2+1))) =20 diff --git a/include/exec/helper-tcg.h b/include/exec/helper-tcg.h index b3bdb0c399..268e0f804b 100644 --- a/include/exec/helper-tcg.h +++ b/include/exec/helper-tcg.h @@ -11,36 +11,43 @@ #define str(s) #s =20 #define DEF_HELPER_FLAGS_0(NAME, FLAGS, ret) \ - { .func =3D HELPER(NAME), .name =3D str(NAME), .flags =3D FLAGS, \ + { .func =3D HELPER(NAME), .name =3D str(NAME), \ + .flags =3D FLAGS | dh_callflag(ret), \ .sizemask =3D dh_sizemask(ret, 0) }, =20 #define DEF_HELPER_FLAGS_1(NAME, FLAGS, ret, t1) \ - { .func =3D HELPER(NAME), .name =3D str(NAME), .flags =3D FLAGS, \ + { .func =3D HELPER(NAME), .name =3D str(NAME), \ + .flags =3D FLAGS | dh_callflag(ret), \ .sizemask =3D dh_sizemask(ret, 0) | dh_sizemask(t1, 1) }, =20 #define DEF_HELPER_FLAGS_2(NAME, FLAGS, ret, t1, t2) \ - { .func =3D HELPER(NAME), .name =3D str(NAME), .flags =3D FLAGS, \ + { .func =3D HELPER(NAME), .name =3D str(NAME), \ + .flags =3D FLAGS | dh_callflag(ret), \ .sizemask =3D dh_sizemask(ret, 0) | dh_sizemask(t1, 1) \ | dh_sizemask(t2, 2) }, =20 #define DEF_HELPER_FLAGS_3(NAME, FLAGS, ret, t1, t2, t3) \ - { .func =3D HELPER(NAME), .name =3D str(NAME), .flags =3D FLAGS, \ + { .func =3D HELPER(NAME), .name =3D str(NAME), \ + .flags =3D FLAGS | dh_callflag(ret), \ .sizemask =3D dh_sizemask(ret, 0) | dh_sizemask(t1, 1) \ | dh_sizemask(t2, 2) | dh_sizemask(t3, 3) }, =20 #define DEF_HELPER_FLAGS_4(NAME, FLAGS, ret, t1, t2, t3, t4) \ - { .func =3D HELPER(NAME), .name =3D str(NAME), .flags =3D FLAGS, \ + { .func =3D HELPER(NAME), .name =3D str(NAME), \ + .flags =3D FLAGS | dh_callflag(ret), \ .sizemask =3D dh_sizemask(ret, 0) | dh_sizemask(t1, 1) \ | dh_sizemask(t2, 2) | dh_sizemask(t3, 3) | dh_sizemask(t4, 4) }, =20 #define DEF_HELPER_FLAGS_5(NAME, FLAGS, ret, t1, t2, t3, t4, t5) \ - { .func =3D HELPER(NAME), .name =3D str(NAME), .flags =3D FLAGS, \ + { .func =3D HELPER(NAME), .name =3D str(NAME), \ + .flags =3D FLAGS | dh_callflag(ret), \ .sizemask =3D dh_sizemask(ret, 0) | dh_sizemask(t1, 1) \ | dh_sizemask(t2, 2) | dh_sizemask(t3, 3) | dh_sizemask(t4, 4) \ | dh_sizemask(t5, 5) }, =20 #define DEF_HELPER_FLAGS_6(NAME, FLAGS, ret, t1, t2, t3, t4, t5, t6) \ - { .func =3D HELPER(NAME), .name =3D str(NAME), .flags =3D FLAGS, \ + { .func =3D HELPER(NAME), .name =3D str(NAME), \ + .flags =3D FLAGS | dh_callflag(ret), \ .sizemask =3D dh_sizemask(ret, 0) | dh_sizemask(t1, 1) \ | dh_sizemask(t2, 2) | dh_sizemask(t3, 3) | dh_sizemask(t4, 4) \ | dh_sizemask(t5, 5) | dh_sizemask(t6, 6) }, diff --git a/tcg/tcg.h b/tcg/tcg.h index e94f805370..6b6bc75c82 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -469,6 +469,8 @@ typedef TCGv_ptr TCGv_env; #define TCG_CALL_NO_WRITE_GLOBALS 0x0002 /* Helper can be safely suppressed if the return value is not used. */ #define TCG_CALL_NO_SIDE_EFFECTS 0x0004 +/* Helper is QEMU_NORETURN. */ +#define TCG_CALL_NO_RETURN 0x0008 =20 /* convenience version of most used call flags */ #define TCG_CALL_NO_RWG TCG_CALL_NO_READ_GLOBALS --=20 2.17.2 From nobody Mon Feb 9 18:27:19 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1543273727280761.1354512001026; Mon, 26 Nov 2018 15:08:47 -0800 (PST) Received: from localhost ([::1]:39249 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRPzc-0006oV-Mh for importer@patchew.org; Mon, 26 Nov 2018 18:08:40 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRPwH-0002oC-G5 for qemu-devel@nongnu.org; Mon, 26 Nov 2018 18:05:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRPw7-0000I4-IT for qemu-devel@nongnu.org; Mon, 26 Nov 2018 18:05:07 -0500 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]:39498) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gRPw3-0000H2-Pc for qemu-devel@nongnu.org; Mon, 26 Nov 2018 18:04:59 -0500 Received: by mail-pg1-x543.google.com with SMTP id w6so6877520pgl.6 for ; Mon, 26 Nov 2018 15:04:58 -0800 (PST) Received: from cloudburst.twiddle.net (97-113-170-180.tukw.qwest.net. [97.113.170.180]) by smtp.gmail.com with ESMTPSA id o13sm1798703pfk.57.2018.11.26.15.04.56 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Nov 2018 15:04:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references; bh=cSSRpXux8jrEAJrLH5pON8RbGB5i6xvuDyS55RcT4eY=; b=fMTfZX9FpsFESCixE//OJvf7YONSauAuLkMybk5knPxr63JsF7Mk5xWRI0XvqQgjQa VpB8bldmeRyppGjlDxHCZEpU3ABPt8J9+Xr1ykCrp0JsZdvsemlfmoxq/xFI7vAflXKE JjbGiaPgfMMAzLtbI/UrKCqvVhoAVJubp4Ct0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=cSSRpXux8jrEAJrLH5pON8RbGB5i6xvuDyS55RcT4eY=; b=HNGlpLvVRjavY8ioqWBPaCICRCDl2OoWhFDAHHZ3A6+DdfZrrNFG1KYRiKwCF3aIy5 BkVbzYGVYR2BpAkYZpMKpidfrm/A8YN2GAOf1cvJsxA80lj/eRcL15ENYZmak8V6v4vl viWNZSFNV/JsmoLXrcfeHa2rGw9GSSVa7HI08ozUAwCVTcyl0WUjnm8/HWmAjBiiffjH rRaVfQbkLPvndQjHfEEg/HGevo+nBSW7D9JSTm8RF7c0MN0soAdBozYq40GOYMcyIWpS HwLDMmk69halvtSYp4eJtuoSLIBSdG2wkvAedp9yDiziV6tLMjedCha1pbYcBVFC51tC 39eA== X-Gm-Message-State: AA+aEWZHg9t/63QqTqcU4xn+xEyC5AbN8Zv9M0xTnDgfb1OP5IGTUFQG 2dooeK/P+zwMmwMohmx03YjH706Lw3Q= X-Google-Smtp-Source: AFSGD/Xq/FGTltWYUECKE/U04jjQqMydXo66mVHI4aQCD2C4Nikh93Ig8SkbJfp6c5L2uW30lwalvQ== X-Received: by 2002:a63:4f20:: with SMTP id d32mr26816250pgb.47.1543273497538; Mon, 26 Nov 2018 15:04:57 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 26 Nov 2018 15:04:49 -0800 Message-Id: <20181126230450.672-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181126230450.672-1-richard.henderson@linaro.org> References: <20181126230450.672-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::543 Subject: [Qemu-devel] [PATCH 3/4] tcg: Reference count labels X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Increment when adding branches, and decrement when removing them. Signed-off-by: Richard Henderson --- tcg/tcg-op.h | 1 + tcg/tcg.h | 3 ++- tcg/tcg-op.c | 2 ++ tcg/tcg.c | 20 ++++++++++++++++++++ 4 files changed, 25 insertions(+), 1 deletion(-) diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h index db4e9188f4..7007ec0d4d 100644 --- a/tcg/tcg-op.h +++ b/tcg/tcg-op.h @@ -260,6 +260,7 @@ static inline void gen_set_label(TCGLabel *l) =20 static inline void tcg_gen_br(TCGLabel *l) { + l->refs++; tcg_gen_op1(INDEX_op_br, label_arg(l)); } =20 diff --git a/tcg/tcg.h b/tcg/tcg.h index 6b6bc75c82..c6caeeb42b 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -246,7 +246,8 @@ typedef struct TCGRelocation { =20 typedef struct TCGLabel { unsigned has_value : 1; - unsigned id : 31; + unsigned id : 15; + unsigned refs : 16; union { uintptr_t value; tcg_insn_unit *value_ptr; diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c index 1ad095cc35..bab889662d 100644 --- a/tcg/tcg-op.c +++ b/tcg/tcg-op.c @@ -240,6 +240,7 @@ void tcg_gen_brcond_i32(TCGCond cond, TCGv_i32 arg1, TC= Gv_i32 arg2, TCGLabel *l) if (cond =3D=3D TCG_COND_ALWAYS) { tcg_gen_br(l); } else if (cond !=3D TCG_COND_NEVER) { + l->refs++; tcg_gen_op4ii_i32(INDEX_op_brcond_i32, arg1, arg2, cond, label_arg= (l)); } } @@ -1405,6 +1406,7 @@ void tcg_gen_brcond_i64(TCGCond cond, TCGv_i64 arg1, = TCGv_i64 arg2, TCGLabel *l) if (cond =3D=3D TCG_COND_ALWAYS) { tcg_gen_br(l); } else if (cond !=3D TCG_COND_NEVER) { + l->refs++; if (TCG_TARGET_REG_BITS =3D=3D 32) { tcg_gen_op6ii_i32(INDEX_op_brcond2_i32, TCGV_LOW(arg1), TCGV_HIGH(arg1), TCGV_LOW(arg2), diff --git a/tcg/tcg.c b/tcg/tcg.c index 17c193791f..31b9b58240 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -2191,6 +2191,26 @@ static void process_op_defs(TCGContext *s) =20 void tcg_op_remove(TCGContext *s, TCGOp *op) { + TCGLabel *label; + + switch (op->opc) { + case INDEX_op_br: + label =3D arg_label(op->args[0]); + label->refs--; + break; + case INDEX_op_brcond_i32: + case INDEX_op_brcond_i64: + label =3D arg_label(op->args[3]); + label->refs--; + break; + case INDEX_op_brcond2_i32: + label =3D arg_label(op->args[5]); + label->refs--; + break; + default: + break; + } + QTAILQ_REMOVE(&s->ops, op, link); QTAILQ_INSERT_TAIL(&s->free_ops, op, link); s->nb_ops--; --=20 2.17.2 From nobody Mon Feb 9 18:27:19 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1543273727281540.6694862274946; Mon, 26 Nov 2018 15:08:47 -0800 (PST) Received: from localhost ([::1]:39248 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRPza-0006ng-RW for importer@patchew.org; Mon, 26 Nov 2018 18:08:38 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRPwH-0002oJ-Ir for qemu-devel@nongnu.org; Mon, 26 Nov 2018 18:05:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRPwC-0000Px-PD for qemu-devel@nongnu.org; Mon, 26 Nov 2018 18:05:13 -0500 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]:33436) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gRPw5-0000H5-NP for qemu-devel@nongnu.org; Mon, 26 Nov 2018 18:05:03 -0500 Received: by mail-pf1-x442.google.com with SMTP id c123so6626614pfb.0 for ; Mon, 26 Nov 2018 15:05:00 -0800 (PST) Received: from cloudburst.twiddle.net (97-113-170-180.tukw.qwest.net. [97.113.170.180]) by smtp.gmail.com with ESMTPSA id o13sm1798703pfk.57.2018.11.26.15.04.57 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Nov 2018 15:04:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references; bh=a0XirnQ7KM4RULalH+OyIr7voieSl1aNO3zcM/erWq4=; b=NdyQs7524wesy0vigNHMby5pjG+QxRG9kxgP3PK8vJeFL/IJSCjPcV8B0UKIWrvmBI 0PkBmSvPgKyD5KseCTJVcfpVi4U1P7c2mlXstMzDiFNcwW36YJBxXjJ7Oe5CR1EprdGl 7F6INDx0qz3WDrcESXdI0m3ZVjihRfW+2+3/w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=a0XirnQ7KM4RULalH+OyIr7voieSl1aNO3zcM/erWq4=; b=hR7xk7pwz7TPQ70HxdTZJTqXRR/p3kywIBXOpL5BBDFqA3dnVuEfXk2tv0rvHbYARJ D79ZGWGp5LgMbLgwEwa1CzuYkZxHJibVJ9vBRGa+FzQgnKF/M9roAWhY331nUJ7HT2cs 0cswQuJPaB1RhpQh7oka2DqSYDr/DamXt9DatQJvKCW14/n2Iy4nmhmgx2eVy9PDZ3Wp d0traMKvTUzl2vIwDwOoy/nwBVNNWo8PifXLiLIyizyOIpZVTVBhOROD9YWijBlyFkLK iXh97vS1pYw/nc/rmUSf7ervf3rGvoSzLPysiUm66ieCQV2Ei/ZSfbDfuzmWg9S6Fdry B/JQ== X-Gm-Message-State: AA+aEWaNNPb6m4VSs3MaJVAlzLquueyHqyd8fxnpOtvGI45oof+uNmPI O+5/WXAdG0+0MiYDCHMm4Tt/+I2o76o= X-Google-Smtp-Source: AFSGD/WmdAnOv9NGKs7wKQ17hICon9576ODyyOf0w8/XMg/UGcyD/+hta9PA+tCVlEwQI7+kUvY1PQ== X-Received: by 2002:a65:534b:: with SMTP id w11mr26930014pgr.125.1543273498747; Mon, 26 Nov 2018 15:04:58 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 26 Nov 2018 15:04:50 -0800 Message-Id: <20181126230450.672-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181126230450.672-1-richard.henderson@linaro.org> References: <20181126230450.672-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::442 Subject: [Qemu-devel] [PATCH 4/4] tcg: Add reachable_code_pass X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Delete trivially dead code that follows unconditional branches and noreturn helpers. These can occur either via optimization or via the structure of a target's translator following an exception. Signed-off-by: Richard Henderson Reviewed-by: Emilio G. Cota --- tcg/tcg.c | 76 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 76 insertions(+) diff --git a/tcg/tcg.c b/tcg/tcg.c index 31b9b58240..ffbf8f01ad 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -2301,6 +2301,81 @@ static void tcg_la_bb_end(TCGContext *s) } } =20 +/* Reachable analysis : remove unreachable code. */ +static void reachable_code_pass(TCGContext *s) +{ + TCGOp *op, *op_next; + bool dead =3D false; + + QTAILQ_FOREACH_SAFE(op, &s->ops, link, op_next) { + bool remove =3D dead; + TCGLabel *label; + int call_flags; + + switch (op->opc) { + case INDEX_op_set_label: + label =3D arg_label(op->args[0]); + if (label->refs =3D=3D 0) { + /* + * While there is an occasional backward branch, virtually + * all branches generated by the translators are forward. + * Which means that generally we will have already removed + * all references to the label that will be, and there is + * little to be gained by iterating. + */ + remove =3D true; + } else { + /* Once we see a label, insns become live again. */ + dead =3D false; + remove =3D false; + + /* + * Optimization can fold conditional branches to unconditi= onal. + * If we find a label with one reference which is preceede= d by + * an unconditional branch to it, remove both. This neede= d to + * wait until the dead code in between them was removed. + */ + if (label->refs =3D=3D 1) { + TCGOp *op_prev =3D QTAILQ_PREV(op, TCGOpHead, link); + if (op_prev->opc =3D=3D INDEX_op_br && + label =3D=3D arg_label(op_prev->args[0])) { + tcg_op_remove(s, op_prev); + remove =3D true; + } + } + } + break; + + case INDEX_op_br: + case INDEX_op_exit_tb: + case INDEX_op_goto_ptr: + /* Unconditional branches; everything following is dead. */ + dead =3D true; + break; + + case INDEX_op_call: + /* Notice noreturn helper calls, raising exceptions. */ + call_flags =3D op->args[TCGOP_CALLO(op) + TCGOP_CALLI(op) + 1]; + if (call_flags & TCG_CALL_NO_RETURN) { + dead =3D true; + } + break; + + case INDEX_op_insn_start: + /* Never remove -- we need to keep these for unwind. */ + remove =3D false; + break; + + default: + break; + } + + if (remove) { + tcg_op_remove(s, op); + } + } +} + /* Liveness analysis : update the opc_arg_life array to tell if a given input arguments is dead. Instructions updating dead temporaries are removed. */ @@ -3537,6 +3612,7 @@ int tcg_gen_code(TCGContext *s, TranslationBlock *tb) atomic_set(&prof->la_time, prof->la_time - profile_getclock()); #endif =20 + reachable_code_pass(s); liveness_pass_1(s); =20 if (s->nb_indirects > 0) { --=20 2.17.2