From nobody Thu Nov 6 19:45:25 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1543273072988386.2346480108024; Mon, 26 Nov 2018 14:57:52 -0800 (PST) Received: from localhost ([::1]:39192 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRPox-0005Lj-Ok for importer@patchew.org; Mon, 26 Nov 2018 17:57:39 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41278) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRPnz-00054h-4E for qemu-devel@nongnu.org; Mon, 26 Nov 2018 17:56:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRPnp-0004U3-J5 for qemu-devel@nongnu.org; Mon, 26 Nov 2018 17:56:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55924) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gRPnp-0004Te-E5 for qemu-devel@nongnu.org; Mon, 26 Nov 2018 17:56:29 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 583A0308AA13 for ; Mon, 26 Nov 2018 22:56:26 +0000 (UTC) Received: from localhost (ovpn-116-21.gru2.redhat.com [10.97.116.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id CC2A7608C6; Mon, 26 Nov 2018 22:56:21 +0000 (UTC) From: Eduardo Habkost To: Markus Armbruster , qemu-devel@nongnu.org Date: Mon, 26 Nov 2018 20:56:20 -0200 Message-Id: <20181126225620.5301-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Mon, 26 Nov 2018 22:56:26 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] apic: Make APIC ID limit error message clearer X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Wainer dos Santos Moschetta , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Remove the "apic initialization failed" prefix (it conveys no useful information), replace "invalid" with "too large", and add an error hint with two possible solutions for the problem. Before: $ qemu-system-x86_64 -machine q35 -smp 256 qemu-system-x86_64: apic initialization failed. APIC ID 255 is invalid After: $ qemu-system-x86_64 -machine q35 -smp 256 -display none qemu-system-x86_64: APIC ID 255 is too large Possible solutions: * Lowering the number of VCPUs on the -smp option * Using accel=3Dkvm,kernel-irqchip=3Don or accel=3Dkvm,kernel-irqchip=3Ds= plit Signed-off-by: Eduardo Habkost --- I'm not sure this is the best way to provide usage hints to the user. Any suggestions? --- hw/intc/apic.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/intc/apic.c b/hw/intc/apic.c index 97ffdd820f..f08006334d 100644 --- a/hw/intc/apic.c +++ b/hw/intc/apic.c @@ -886,8 +886,11 @@ static void apic_realize(DeviceState *dev, Error **err= p) APICCommonState *s =3D APIC(dev); =20 if (s->id >=3D MAX_APICS) { - error_setg(errp, "%s initialization failed. APIC ID %d is invalid", - object_get_typename(OBJECT(dev)), s->id); + error_setg(errp, "APIC ID %d is too large", s->id); + error_append_hint(errp, + "Possible solutions:\n" + "* Lowering the number of VCPUs on the -smp option\n" + "* Using accel=3Dkvm,kernel-irqchip=3Don or accel=3Dkvm,kernel= -irqchip=3Dsplit\n"); return; } =20 --=20 2.18.0.rc1.1.g3f1ff2140