From nobody Tue Feb 10 23:58:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1542985469715865.7846084302223; Fri, 23 Nov 2018 07:04:29 -0800 (PST) Received: from localhost ([::1]:52849 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQD0O-00008C-9K for importer@patchew.org; Fri, 23 Nov 2018 10:04:28 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44145) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQCj1-0000EH-Mb for qemu-devel@nongnu.org; Fri, 23 Nov 2018 09:46:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gQCiz-0003da-OJ for qemu-devel@nongnu.org; Fri, 23 Nov 2018 09:46:31 -0500 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:44384) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gQCiy-0003ZO-0I for qemu-devel@nongnu.org; Fri, 23 Nov 2018 09:46:29 -0500 Received: by mail-wr1-x444.google.com with SMTP id z5so8281528wrt.11 for ; Fri, 23 Nov 2018 06:46:27 -0800 (PST) Received: from cloudburst.twiddle.net ([195.77.246.50]) by smtp.gmail.com with ESMTPSA id p74sm10339630wmd.29.2018.11.23.06.46.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 23 Nov 2018 06:46:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=U/S7zmMlyfjLiA6mFcj5+nW10ojCNetN9JvrDZkZZc8=; b=eVx5hERWeDN6cgl78AOSxjgjzuKL148atgXH5RpR62+L73c69Z2Zso0t9eoEJVHFph tSSq00gMokiBDw12PVrHktM4GMWvMdxebx5fe2YIjKB8nCeZ/CvtxcyTIxwN99TXhofj zmPoZzIa1YIBcxZOPMMXeo4SyPH30RUhU9pYY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=U/S7zmMlyfjLiA6mFcj5+nW10ojCNetN9JvrDZkZZc8=; b=OsYpC/3hG7GwMyfCxHmQi0YGF82B5iQNI3UP3DUw5Wqt451O//oZ4axC9OKq1WEYnZ 1xTCN1gc5m8iWU/BzUMfkYgvFz8BqzsmnNCYvpN9vLyQ4pXYvAb8fzomvjYsfLD42aZ6 bJ6UGNEusexIRkLcQPIkEudkPzI1UNVWTdgu2NMEskZu3cE2JDTi/6nqCTd/BcyvTOXf MQrw3ZLsDx/j6NAvrpDADcg4dnj/oPbWkRhxvjBhnRAm5VeMeA0EtyyFOzNuD+2Ss3Rl RmpOOs/pDIf6yfxiq9gyO3Jd1bbS0jHY2lhuYpodD2V1hwJzf2XNXKRUIa8kKqkc5pv/ ly9g== X-Gm-Message-State: AA+aEWbPSxSmfjEEhJDvgLKZEVEjaE2j6qLkKuX+g5qxI+b62tAQMgJn 8kK4lxiYuUun9CipwOpKeiv0/2HSV6Zj4g== X-Google-Smtp-Source: AFSGD/W8Sup7JwsRmlkxYyG2hErSiDqCdNXkDlooycqPk71ZK02BzNyeS4ckvqht1dwKUji2kQL3ow== X-Received: by 2002:adf:fa91:: with SMTP id h17mr15253153wrr.320.1542984386577; Fri, 23 Nov 2018 06:46:26 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 23 Nov 2018 15:45:48 +0100 Message-Id: <20181123144558.5048-28-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181123144558.5048-1-richard.henderson@linaro.org> References: <20181123144558.5048-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 Subject: [Qemu-devel] [PATCH for-4.0 v2 27/37] tcg: Clean up generic bswap64 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alistair.Francis@wdc.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Based on the only current user, Sparc: New code uses 2 constants that take 2 insns to load from constant pool, plus 13. Old code used 6 constants that took 1 or 2 insns to create, plus 21. The result is a new total of 17 vs an old total of 29. Signed-off-by: Richard Henderson --- tcg/tcg-op.c | 43 ++++++++++++++++++------------------------- 1 file changed, 18 insertions(+), 25 deletions(-) diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c index a956499e46..887b371a81 100644 --- a/tcg/tcg-op.c +++ b/tcg/tcg-op.c @@ -1678,37 +1678,30 @@ void tcg_gen_bswap64_i64(TCGv_i64 ret, TCGv_i64 arg) } else { TCGv_i64 t0 =3D tcg_temp_new_i64(); TCGv_i64 t1 =3D tcg_temp_new_i64(); + TCGv_i64 t2 =3D tcg_temp_new_i64(); =20 - tcg_gen_shli_i64(t0, arg, 56); + /* arg =3D abcdefgh */ + tcg_gen_movi_i64(t2, 0x00ff00ff00ff00ffull); + tcg_gen_shri_i64(t0, arg, 8); /* t0 =3D .abcdefg */ + tcg_gen_and_i64(t1, arg, t2); /* t1 =3D .b.d.f.h */ + tcg_gen_and_i64(t0, t0, t2); /* t0 =3D .a.c.e.g */ + tcg_gen_shli_i64(t1, t1, 8); /* t1 =3D b.d.f.h. */ + tcg_gen_or_i64(ret, t0, t1); /* ret =3D badcfehg */ =20 - tcg_gen_andi_i64(t1, arg, 0x0000ff00); - tcg_gen_shli_i64(t1, t1, 40); - tcg_gen_or_i64(t0, t0, t1); + tcg_gen_movi_i64(t2, 0x0000ffff0000ffffull); + tcg_gen_shri_i64(t0, ret, 16); /* t0 =3D ..badcfe */ + tcg_gen_and_i64(t1, ret, t2); /* t1 =3D ..dc..hg */ + tcg_gen_and_i64(t0, t0, t2); /* t0 =3D ..ba..fe */ + tcg_gen_shli_i64(t1, t1, 16); /* t1 =3D dc..hg.. */ + tcg_gen_or_i64(ret, t0, t1); /* ret =3D dcbahgfe */ =20 - tcg_gen_andi_i64(t1, arg, 0x00ff0000); - tcg_gen_shli_i64(t1, t1, 24); - tcg_gen_or_i64(t0, t0, t1); + tcg_gen_shri_i64(t0, ret, 32); /* t0 =3D ....dcba */ + tcg_gen_shli_i64(t1, ret, 32); /* t1 =3D hgfe.... */ + tcg_gen_or_i64(ret, t0, t1); /* ret =3D hgfedcba */ =20 - tcg_gen_andi_i64(t1, arg, 0xff000000); - tcg_gen_shli_i64(t1, t1, 8); - tcg_gen_or_i64(t0, t0, t1); - - tcg_gen_shri_i64(t1, arg, 8); - tcg_gen_andi_i64(t1, t1, 0xff000000); - tcg_gen_or_i64(t0, t0, t1); - - tcg_gen_shri_i64(t1, arg, 24); - tcg_gen_andi_i64(t1, t1, 0x00ff0000); - tcg_gen_or_i64(t0, t0, t1); - - tcg_gen_shri_i64(t1, arg, 40); - tcg_gen_andi_i64(t1, t1, 0x0000ff00); - tcg_gen_or_i64(t0, t0, t1); - - tcg_gen_shri_i64(t1, arg, 56); - tcg_gen_or_i64(ret, t0, t1); tcg_temp_free_i64(t0); tcg_temp_free_i64(t1); + tcg_temp_free_i64(t2); } } =20 --=20 2.17.2