From nobody Sun May 5 12:00:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1542893616291685.6888698705762; Thu, 22 Nov 2018 05:33:36 -0800 (PST) Received: from localhost ([::1]:46603 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPp6i-00070Z-AA for importer@patchew.org; Thu, 22 Nov 2018 08:33:24 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51075) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPp5d-0006FX-4l for qemu-devel@nongnu.org; Thu, 22 Nov 2018 08:32:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPp5Z-0005oZ-TR for qemu-devel@nongnu.org; Thu, 22 Nov 2018 08:32:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57952) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gPp5Z-0005nn-OF for qemu-devel@nongnu.org; Thu, 22 Nov 2018 08:32:13 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E41EB811DA for ; Thu, 22 Nov 2018 13:32:12 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-59.ams2.redhat.com [10.36.116.59]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9CE5B28D20; Thu, 22 Nov 2018 13:32:08 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id D83CE9F12; Thu, 22 Nov 2018 14:32:07 +0100 (CET) From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Thu, 22 Nov 2018 14:32:07 +0100 Message-Id: <20181122133207.29928-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 22 Nov 2018 13:32:12 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] audio/hda: fix guest triggerable assert X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Guest writes to a readonly register trigger the assert in intel_hda_reg_write(). Add a check and just ignore them. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=3D1628433 Signed-off-by: Gerd Hoffmann Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/audio/intel-hda.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c index 23a2cf6484..066532713c 100644 --- a/hw/audio/intel-hda.c +++ b/hw/audio/intel-hda.c @@ -929,6 +929,10 @@ static void intel_hda_reg_write(IntelHDAState *d, cons= t IntelHDAReg *reg, uint32 if (!reg) { return; } + if (!reg->wmask) { + /* read-only register */ + return; + } =20 if (d->debug) { time_t now =3D time(NULL); --=20 2.9.3