From nobody Mon May 6 19:31:22 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1542651869990711.3348832065462; Mon, 19 Nov 2018 10:24:29 -0800 (PST) Received: from localhost ([::1]:58516 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gOoDk-0003UH-Mt for importer@patchew.org; Mon, 19 Nov 2018 13:24:28 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33628) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gOoCt-0002xb-0u for qemu-devel@nongnu.org; Mon, 19 Nov 2018 13:23:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gOoCs-0002Ut-E2 for qemu-devel@nongnu.org; Mon, 19 Nov 2018 13:23:34 -0500 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:35708) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gOoCs-0002TJ-8A for qemu-devel@nongnu.org; Mon, 19 Nov 2018 13:23:34 -0500 Received: by mail-wm1-x342.google.com with SMTP id t15-v6so6270183wmt.0 for ; Mon, 19 Nov 2018 10:23:34 -0800 (PST) Received: from donizetti.lan ([2001:b07:6468:f312:8d3c:3030:bb0b:6c69]) by smtp.gmail.com with ESMTPSA id q7-v6sm29997007wmg.27.2018.11.19.10.23.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 19 Nov 2018 10:23:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=gTj4+gJhuUkydCA57bZIp29DAoiT5pg6mgf6krbsRD4=; b=nZOrGHDJSownyOGVX2iQYfUTtZxzhzkXr6v6oGNpKe85Xp/Gz0VEoKuQIt/8CqzuEZ nMy++uyu2n2vsc4QsNsa6uQVLkvEuXHta4mciL+765OyeZSvkbaJa1p37aBeZAgPH0SP //A2VSzekFDy4W4h4MrRSvbL1Z8Dhhyhh2+d047Ehu43vX5MFhS1g3tB6AT/JjeJB+xk M+jALr3FxASOIJ5X6RzzMiUN4ptoq7ogdNCbZ4xIeS0yejSmW/kNYUHXYt+Sv9+yejWe jl++r9G1wGi0+nZSZ0uO2FXU/XXv5Cfh1rXb4yYP8n63d9Dq/ph6JDdNwufq77JaSSjo Ev9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=gTj4+gJhuUkydCA57bZIp29DAoiT5pg6mgf6krbsRD4=; b=DH3bt4Fk2Mm33wynTnRZPLzc7MWFQxlpvKDsUHAlDjZcgd6WACY8MgeK5CF8kmpbft jqElbediyW3OMznkJgx+YEBKADBymviMaXo1Lx+ljWIc2zpfbiiElaJ72U0zs3Fd861b CnLLYw2YGKxd6IJansgQ2dHcC4bPwMB94MyJnm3aXEA/ui7NNfAfzhglayigySphKIR6 EOTxbYl/+oIXkbIgA+m0xB/KHedoQv3YF5lJKipTkH6Ra7xx3lawNHmPk2AYmLMwzHcd fBO77JebQw6NpeyEjmHcINvAHY3mDVheK3odnSgDkTMYH9fmdIQjv1O2NgRe8hxRnTXQ 6bxQ== X-Gm-Message-State: AGRZ1gJknYOIQeeZhibJ6uLi6xmamtvZ5C26oXHX6PMdTelB+VKnyJbx jG7aHeFcO/We0vav1+XxMRe/M5a8 X-Google-Smtp-Source: AJdET5eyhUcVBkGG+DpLhFkMvOpisHmfxK8qKuAF5DOF5eRk559XQ8o5XcEJEyU/wcuIDmo4GIa9qg== X-Received: by 2002:a1c:dfc1:: with SMTP id w184mr7836946wmg.2.1542651812947; Mon, 19 Nov 2018 10:23:32 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 19 Nov 2018 19:23:30 +0100 Message-Id: <20181119182330.17147-1-pbonzini@redhat.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::342 Subject: [Qemu-devel] [PATCH v2] target/i386: kvm: add VMX migration blocker X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dgilbert@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Nested VMX does not support live migration yet. Add a blocker until that is worked out. Nested SVM only does not support it, but unfortunately it is enabled by default for -cpu host so we cannot really disable it. Signed-off-by: Paolo Bonzini Reviewed-by: Dr. David Alan Gilbert --- target/i386/kvm.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/target/i386/kvm.c b/target/i386/kvm.c index f524e7d929..27dcca5365 100644 --- a/target/i386/kvm.c +++ b/target/i386/kvm.c @@ -854,6 +854,7 @@ static int hyperv_init_vcpu(X86CPU *cpu) } =20 static Error *invtsc_mig_blocker; +static Error *vmx_mig_blocker; =20 #define KVM_MAX_CPUID_ENTRIES 100 =20 @@ -1246,6 +1247,17 @@ int kvm_arch_init_vcpu(CPUState *cs) !!(c->ecx & CPUID_EXT_SMX); } =20 + if ((env->features[FEAT_1_ECX] & CPUID_EXT_VMX) && !vmx_mig_blocker) { + error_setg(&vmx_mig_blocker, + "Nested VMX virtualization does not support live migrat= ion yet"); + r =3D migrate_add_blocker(vmx_mig_blocker, &local_err); + if (local_err) { + error_report_err(local_err); + error_free(vmx_mig_blocker); + return r; + } + } + if (env->mcg_cap & MCG_LMCE_P) { has_msr_mcg_ext_ctl =3D has_msr_feature_control =3D true; } --=20 2.19.1