From nobody Mon Feb 9 19:06:53 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1542642715754249.26540839309177; Mon, 19 Nov 2018 07:51:55 -0800 (PST) Received: from localhost ([::1]:57333 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gOlpz-0005Z7-MC for importer@patchew.org; Mon, 19 Nov 2018 10:51:47 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41498) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gOlmZ-0003cy-Il for qemu-devel@nongnu.org; Mon, 19 Nov 2018 10:48:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gOlmX-00018U-Se for qemu-devel@nongnu.org; Mon, 19 Nov 2018 10:48:15 -0500 Received: from m12-16.163.com ([220.181.12.16]:52575) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gOlmX-00017h-8l for qemu-devel@nongnu.org; Mon, 19 Nov 2018 10:48:13 -0500 Received: from ubuntu.localdomain (unknown [36.22.237.106]) by smtp12 (Coremail) with SMTP id EMCowADHTWIx2_JbFk1cAw--.51875S5; Mon, 19 Nov 2018 23:48:11 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=/4W4dH0MiRJvranPW4 QvTbZVQ+fmb+Q0190j7NLpws8=; b=moyQHekCkN8BEJDOaFqp9fBGXcs3O3jvAQ WsRGcLhDuc/xcijNPfmtnTAYZAPRkvUg62aN7sylTBiv/FrxZZMtTzFKWFty6mTw 29UJ0FQoRxmATWNsqkOswjX3swentCgQRBsS4JTajr5D3kyEJeZpMKSky93yHa0E QS5CIT0xA= From: Li Qiang To: pbonzini@redhat.com, kraxel@redhat.com, lersek@redhat.com, philmd@redhat.com, armbru@redhat.com Date: Mon, 19 Nov 2018 07:47:37 -0800 Message-Id: <20181119154737.9840-4-liq3ea@163.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181119154737.9840-1-liq3ea@163.com> References: <20181119154737.9840-1-liq3ea@163.com> X-CM-TRANSID: EMCowADHTWIx2_JbFk1cAw--.51875S5 X-Coremail-Antispam: 1Uf129KBjvJXoW7XFyxGFyDZw13AFy3KFWktFb_yoW8Jr4kpF WkJ3WkKrs7JrW5Z34ag3W7AFyxW39xXF1YqayUZa4Ivrn8JF97Xa1UKa1FkrW8trZ5Wa1q 9r43XrWFy3WjqFJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07UhiSLUUUUU= X-Originating-IP: [36.22.237.106] X-CM-SenderInfo: 5oltjvrd6rljoofrz/1tbiKRkEbVXloqekmAABsR X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 220.181.12.16 Subject: [Qemu-devel] [PATCH 3/3] fw_cfg: make qemu_extra_params_fw locally X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Li Qiang , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" qemu_extra_params_fw[] has external linkage, but is used only in fw_cfg_bootsplash(), it makes sense to make it locally. Suggested-by: Markus Armbruster Signed-off-by: Li Qiang Reviewed-by: Markus Armbruster --- hw/nvram/fw_cfg.c | 1 + include/sysemu/sysemu.h | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index 0489d63a1b..4eddd6a885 100644 --- a/hw/nvram/fw_cfg.c +++ b/hw/nvram/fw_cfg.c @@ -120,6 +120,7 @@ static void fw_cfg_bootsplash(FWCfgState *s) { const char *boot_splash_filename =3D NULL; const char *boot_splash_time =3D NULL; + uint8_t qemu_extra_params_fw[2]; char *filename, *file_data; gsize file_size; int file_type; diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h index 8d6095d98b..f8608d24d9 100644 --- a/include/sysemu/sysemu.h +++ b/include/sysemu/sysemu.h @@ -133,7 +133,6 @@ extern uint8_t *boot_splash_filedata; extern size_t boot_splash_filedata_size; extern bool enable_mlock; extern bool enable_cpu_pm; -extern uint8_t qemu_extra_params_fw[2]; extern QEMUClockType rtc_clock; extern const char *mem_path; extern int mem_prealloc; --=20 2.17.1