From nobody Sun May 19 19:10:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1542622998586532.0367885950128; Mon, 19 Nov 2018 02:23:18 -0800 (PST) Received: from localhost ([::1]:55053 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gOghw-0008TN-2S for importer@patchew.org; Mon, 19 Nov 2018 05:23:08 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47280) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gOgfh-00072i-GU for qemu-devel@nongnu.org; Mon, 19 Nov 2018 05:20:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gOgeP-0000o9-0Q for qemu-devel@nongnu.org; Mon, 19 Nov 2018 05:19:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52598) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gOgeM-0000mt-JF; Mon, 19 Nov 2018 05:19:26 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D61BA356F1; Mon, 19 Nov 2018 10:19:25 +0000 (UTC) Received: from localhost (unknown [10.40.205.156]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 69A5960C67; Mon, 19 Nov 2018 10:19:25 +0000 (UTC) From: Max Reitz To: qemu-block@nongnu.org Date: Mon, 19 Nov 2018 11:19:20 +0100 Message-Id: <20181119101921.31949-2-mreitz@redhat.com> In-Reply-To: <20181119101921.31949-1-mreitz@redhat.com> References: <20181119101921.31949-1-mreitz@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 19 Nov 2018 10:19:25 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH for-next? 1/2] qemu-img: Fix typo X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-stable@nongnu.org, qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Fixes: d402b6a21a825a5c07aac9251990860723d49f5d Reported-by: Kevin Wolf Cc: qemu-stable@nongnu.org Signed-off-by: Max Reitz Reviewed-by: John Snow --- qemu-img.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index 13a6ca31b4..a9a2470e1a 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -261,7 +261,7 @@ static int print_block_option_help(const char *filename= , const char *fmt) return 1; } if (!proto_drv->create_opts) { - error_report("Protocal driver '%s' does not support image crea= tion", + error_report("Protocol driver '%s' does not support image crea= tion", proto_drv->format_name); return 1; } --=20 2.17.2 From nobody Sun May 19 19:10:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 15426229767055.45920748434412; Mon, 19 Nov 2018 02:22:56 -0800 (PST) Received: from localhost ([::1]:55052 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gOgha-0008GI-B3 for importer@patchew.org; Mon, 19 Nov 2018 05:22:46 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47284) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gOgfd-00072j-BM for qemu-devel@nongnu.org; Mon, 19 Nov 2018 05:20:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gOgeS-0000pz-TL for qemu-devel@nongnu.org; Mon, 19 Nov 2018 05:19:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:21063) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gOgeP-0000nk-1W; Mon, 19 Nov 2018 05:19:29 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 31E363082DDB; Mon, 19 Nov 2018 10:19:28 +0000 (UTC) Received: from localhost (unknown [10.40.205.156]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BB57E105B1E0; Mon, 19 Nov 2018 10:19:27 +0000 (UTC) From: Max Reitz To: qemu-block@nongnu.org Date: Mon, 19 Nov 2018 11:19:21 +0100 Message-Id: <20181119101921.31949-3-mreitz@redhat.com> In-Reply-To: <20181119101921.31949-1-mreitz@redhat.com> References: <20181119101921.31949-1-mreitz@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Mon, 19 Nov 2018 10:19:28 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH for-next? 2/2] qemu-img: Fix leak X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-stable@nongnu.org, qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" create_opts was leaked here. This is not too bad since the process is about to exit anyway, but relying on that does not make the code nicer to read. Fixes: d402b6a21a825a5c07aac9251990860723d49f5d Reported-by: Kevin Wolf Cc: qemu-stable@nongnu.org Signed-off-by: Max Reitz Reviewed-by: John Snow --- qemu-img.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qemu-img.c b/qemu-img.c index a9a2470e1a..ad04f59565 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -263,6 +263,7 @@ static int print_block_option_help(const char *filename= , const char *fmt) if (!proto_drv->create_opts) { error_report("Protocol driver '%s' does not support image crea= tion", proto_drv->format_name); + qemu_opts_free(create_opts); return 1; } create_opts =3D qemu_opts_append(create_opts, proto_drv->create_op= ts); --=20 2.17.2