From nobody Thu Nov 6 16:21:11 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1542387265205422.4986868335425; Fri, 16 Nov 2018 08:54:25 -0800 (PST) Received: from localhost ([::1]:45786 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNhNs-0002OB-Fz for importer@patchew.org; Fri, 16 Nov 2018 11:54:20 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44257) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNhHx-0006Ru-IO for qemu-devel@nongnu.org; Fri, 16 Nov 2018 11:48:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gNhHt-0007dX-Iu for qemu-devel@nongnu.org; Fri, 16 Nov 2018 11:48:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53170) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gNhHt-0007cy-DV for qemu-devel@nongnu.org; Fri, 16 Nov 2018 11:48:09 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B583A3082AFD for ; Fri, 16 Nov 2018 16:48:08 +0000 (UTC) Received: from donizetti.redhat.com (ovpn-112-60.ams2.redhat.com [10.36.112.60]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0D13E648A2 for ; Fri, 16 Nov 2018 16:48:07 +0000 (UTC) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Fri, 16 Nov 2018 17:48:05 +0100 Message-Id: <20181116164806.26929-1-pbonzini@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Fri, 16 Nov 2018 16:48:08 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] target/i386: kvm: add VMX and SVM migration blockers X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Nested VMX and SVM do not support live migration yet. Add a blocker until that is worked out. Signed-off-by: Paolo Bonzini --- target/i386/kvm.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/target/i386/kvm.c b/target/i386/kvm.c index db1f4104b6..3b6fbd3f20 100644 --- a/target/i386/kvm.c +++ b/target/i386/kvm.c @@ -860,6 +860,8 @@ static int hyperv_init_vcpu(X86CPU *cpu) } =20 static Error *invtsc_mig_blocker; +static Error *vmx_mig_blocker; +static Error *svm_mig_blocker; =20 #define KVM_MAX_CPUID_ENTRIES 100 =20 @@ -1250,6 +1252,29 @@ int kvm_arch_init_vcpu(CPUState *cs) if (c) { has_msr_feature_control =3D !!(c->ecx & CPUID_EXT_VMX) || !!(c->ecx & CPUID_EXT_SMX); + + } + + if ((env->features[FEAT_1_ECX] & CPUID_EXT_VMX) && !vmx_mig_blocker) { + error_setg(&vmx_mig_blocker, + "Nested VMX virtualization does not support live migrat= ion yet"); + r =3D migrate_add_blocker(vmx_mig_blocker, &local_err); + if (local_err) { + error_report_err(local_err); + error_free(vmx_mig_blocker); + return r; + } + } + + if ((env->features[FEAT_8000_0001_ECX] & CPUID_EXT3_SVM) && !svm_mig_b= locker) { + error_setg(&svm_mig_blocker, + "Nested SVM virtualization does not support live migrat= ion yet"); + r =3D migrate_add_blocker(svm_mig_blocker, &local_err); + if (local_err) { + error_report_err(local_err); + error_free(svm_mig_blocker); + return r; + } } =20 if (env->mcg_cap & MCG_LMCE_P) { --=20 2.19.1