From nobody Thu Nov 6 18:04:29 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1542290861428630.1142219885742; Thu, 15 Nov 2018 06:07:41 -0800 (PST) Received: from localhost ([::1]:38994 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNIJ2-0006kW-Ab for importer@patchew.org; Thu, 15 Nov 2018 09:07:40 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52821) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNIHH-0005r8-B0 for qemu-devel@nongnu.org; Thu, 15 Nov 2018 09:05:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gNIH2-0004Tq-W8 for qemu-devel@nongnu.org; Thu, 15 Nov 2018 09:05:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35340) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gNIGx-0004Mc-3P for qemu-devel@nongnu.org; Thu, 15 Nov 2018 09:05:33 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C393058E35; Thu, 15 Nov 2018 14:05:19 +0000 (UTC) Received: from t460s.redhat.com (ovpn-117-224.ams2.redhat.com [10.36.117.224]) by smtp.corp.redhat.com (Postfix) with ESMTP id 354FD600C3; Thu, 15 Nov 2018 14:05:18 +0000 (UTC) From: David Hildenbrand To: qemu-devel@nongnu.org Date: Thu, 15 Nov 2018 15:04:57 +0100 Message-Id: <20181115140501.7872-6-david@redhat.com> In-Reply-To: <20181115140501.7872-1-david@redhat.com> References: <20181115140501.7872-1-david@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 15 Nov 2018 14:05:20 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v1 5/9] test-string-input-visitor: add more tests X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , David Hildenbrand , Markus Armbruster , Michael Roth Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Test that very big/small values are not accepted and that ranges with only one element work. Rename expect4 to expect5, as we will be moving that to a separate ulist test after the rework. Signed-off-by: David Hildenbrand --- tests/test-string-input-visitor.c | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/tests/test-string-input-visitor.c b/tests/test-string-input-vi= sitor.c index 88e0e1aa9a..f55e0696c0 100644 --- a/tests/test-string-input-visitor.c +++ b/tests/test-string-input-visitor.c @@ -121,7 +121,8 @@ static void test_visitor_in_intList(TestInputVisitorDat= a *data, int64_t expect1[] =3D { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 20 }; int64_t expect2[] =3D { 32767, -32768, -32767 }; int64_t expect3[] =3D { INT64_MAX, INT64_MIN }; - uint64_t expect4[] =3D { UINT64_MAX }; + int64_t expect4[] =3D { 1 }; + uint64_t expect5[] =3D { UINT64_MAX }; Error *err =3D NULL; int64List *res =3D NULL; int64List *tail; @@ -140,8 +141,25 @@ static void test_visitor_in_intList(TestInputVisitorDa= ta *data, "-9223372036854775808,9223372036854775807"= ); check_ilist(v, expect3, ARRAY_SIZE(expect3)); =20 + v =3D visitor_input_test_init(data, "1-1"); + check_ilist(v, expect4, ARRAY_SIZE(expect4)); + v =3D visitor_input_test_init(data, "18446744073709551615"); - check_ulist(v, expect4, ARRAY_SIZE(expect4)); + check_ulist(v, expect5, ARRAY_SIZE(expect5)); + + /* Value too large */ + + v =3D visitor_input_test_init(data, "9223372036854775808"); + visit_type_int64List(v, NULL, &res, &err); + error_free_or_abort(&err); + g_assert(!res); + + /* Value too small */ + + v =3D visitor_input_test_init(data, "-9223372036854775809"); + visit_type_int64List(v, NULL, &res, &err); + error_free_or_abort(&err); + g_assert(!res); =20 /* Empty list */ =20 --=20 2.17.2