From nobody Tue Feb 10 06:27:38 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1541680270343948.4194380632414; Thu, 8 Nov 2018 04:31:10 -0800 (PST) Received: from localhost ([::1]:56328 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKjSk-0006nl-Qh for importer@patchew.org; Thu, 08 Nov 2018 07:31:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43373) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKjFI-0005Gc-LZ for qemu-devel@nongnu.org; Thu, 08 Nov 2018 07:17:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKjFF-0003iw-VE for qemu-devel@nongnu.org; Thu, 08 Nov 2018 07:17:12 -0500 Received: from ozlabs.org ([2401:3900:2:1::2]:44029) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gKjF8-0003at-S6; Thu, 08 Nov 2018 07:17:04 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 42rMj01wrmz9sDT; Thu, 8 Nov 2018 23:16:51 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1541679412; bh=SEgsqD9Kv2vjT3C3MPL+PuFeLmBYOgNwhYJnA0LjKkI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NxaTcFV1mUGOD5OUodWx2ipSTDiNrdw1SrZZOda6zaBNx9QoqZYOQW2bMNEJ3TjmK xdEuR5ToWyuczLfxU6h/MWJjMSxd3phS3C55lwK0dEI2G+m47BObzI3zAjjgbH7GoC 59f1zSXAN8SFPjjCYLIYU5HxYRFTHJpzNoTAtymg= From: David Gibson To: peter.maydell@linaro.org Date: Thu, 8 Nov 2018 23:16:32 +1100 Message-Id: <20181108121646.26173-9-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181108121646.26173-1-david@gibson.dropbear.id.au> References: <20181108121646.26173-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: [Qemu-devel] [PULL 08/22] target/ppc: Introduce fp number classification X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, Richard Henderson , agraf@suse.de, qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Richard Henderson Having a separate, logical classifiation of numbers will unify more error paths for different formats. Signed-off-by: Richard Henderson Signed-off-by: David Gibson --- target/ppc/fpu_helper.c | 94 ++++++++++++++++++++++------------------- 1 file changed, 51 insertions(+), 43 deletions(-) diff --git a/target/ppc/fpu_helper.c b/target/ppc/fpu_helper.c index c9198f826d..9ae55b1e93 100644 --- a/target/ppc/fpu_helper.c +++ b/target/ppc/fpu_helper.c @@ -114,54 +114,62 @@ static inline int ppc_float64_get_unbiased_exp(float6= 4 f) return ((f >> 52) & 0x7FF) - 1023; } =20 -#define COMPUTE_FPRF(tp) \ -void helper_compute_fprf_##tp(CPUPPCState *env, tp arg) \ +/* Classify a floating-point number. */ +enum { + is_normal =3D 1, + is_zero =3D 2, + is_denormal =3D 4, + is_inf =3D 8, + is_qnan =3D 16, + is_snan =3D 32, + is_neg =3D 64, +}; + +#define COMPUTE_CLASS(tp) \ +static int tp##_classify(tp arg) \ { \ - int isneg; \ - int fprf; \ - \ - isneg =3D tp##_is_neg(arg); \ + int ret =3D tp##_is_neg(arg) * is_neg; \ if (unlikely(tp##_is_any_nan(arg))) { \ - if (tp##_is_signaling_nan(arg, &env->fp_status)) { \ - /* Signaling NaN: flags are undefined */ \ - fprf =3D 0x00; \ - } else { \ - /* Quiet NaN */ \ - fprf =3D 0x11; \ - } \ + float_status dummy =3D { }; /* snan_bit_is_one =3D 0 */ \ + ret |=3D (tp##_is_signaling_nan(arg, &dummy) \ + ? is_snan : is_qnan); \ } else if (unlikely(tp##_is_infinity(arg))) { \ - /* +/- infinity */ \ - if (isneg) { \ - fprf =3D 0x09; \ - } else { \ - fprf =3D 0x05; \ - } \ + ret |=3D is_inf; \ + } else if (tp##_is_zero(arg)) { \ + ret |=3D is_zero; \ + } else if (tp##_is_zero_or_denormal(arg)) { \ + ret |=3D is_denormal; \ } else { \ - if (tp##_is_zero(arg)) { \ - /* +/- zero */ \ - if (isneg) { \ - fprf =3D 0x12; \ - } else { \ - fprf =3D 0x02; \ - } \ - } else { \ - if (tp##_is_zero_or_denormal(arg)) { \ - /* Denormalized numbers */ \ - fprf =3D 0x10; \ - } else { \ - /* Normalized numbers */ \ - fprf =3D 0x00; \ - } \ - if (isneg) { \ - fprf |=3D 0x08; \ - } else { \ - fprf |=3D 0x04; \ - } \ - } \ + ret |=3D is_normal; \ } \ - /* We update FPSCR_FPRF */ \ - env->fpscr &=3D ~(0x1F << FPSCR_FPRF); \ - env->fpscr |=3D fprf << FPSCR_FPRF; \ + return ret; \ +} + +COMPUTE_CLASS(float16) +COMPUTE_CLASS(float32) +COMPUTE_CLASS(float64) +COMPUTE_CLASS(float128) + +static void set_fprf_from_class(CPUPPCState *env, int class) +{ + static const uint8_t fprf[6][2] =3D { + { 0x04, 0x08 }, /* normalized */ + { 0x02, 0x12 }, /* zero */ + { 0x14, 0x18 }, /* denormalized */ + { 0x05, 0x09 }, /* infinity */ + { 0x11, 0x11 }, /* qnan */ + { 0x00, 0x00 }, /* snan -- flags are undefined */ + }; + bool isneg =3D class & is_neg; + + env->fpscr &=3D ~(0x1F << FPSCR_FPRF); + env->fpscr |=3D fprf[ctz32(class)][isneg] << FPSCR_FPRF; +} + +#define COMPUTE_FPRF(tp) \ +void helper_compute_fprf_##tp(CPUPPCState *env, tp arg) \ +{ \ + set_fprf_from_class(env, tp##_classify(arg)); \ } =20 COMPUTE_FPRF(float16) --=20 2.19.1