From nobody Mon Feb 9 12:26:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1541526285189781.1006330576297; Tue, 6 Nov 2018 09:44:45 -0800 (PST) Received: from localhost ([::1]:42369 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gK5P5-0002eN-TC for importer@patchew.org; Tue, 06 Nov 2018 12:44:39 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52701) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gK5Ki-0005pC-34 for qemu-devel@nongnu.org; Tue, 06 Nov 2018 12:40:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gK5Kd-00086k-ME for qemu-devel@nongnu.org; Tue, 06 Nov 2018 12:40:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39288) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gK5Kc-0007IE-TE for qemu-devel@nongnu.org; Tue, 06 Nov 2018 12:40:03 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2D3F9356CD for ; Tue, 6 Nov 2018 17:39:43 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-117-34.ams2.redhat.com [10.36.117.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E5FBD611D3; Tue, 6 Nov 2018 17:39:42 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 66E5D11384D8; Tue, 6 Nov 2018 18:39:41 +0100 (CET) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Tue, 6 Nov 2018 18:39:41 +0100 Message-Id: <20181106173941.9449-4-armbru@redhat.com> In-Reply-To: <20181106173941.9449-1-armbru@redhat.com> References: <20181106173941.9449-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 06 Nov 2018 17:39:43 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL v2 3/3] vl: Avoid crash when -mon is underspecified X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Eric Blake A quick coredump on an incomplete command line: ./x86_64-softmmu/qemu-system-x86_64 -mon mode=3Dcontrol,pretty=3Don #0 0x00007ffff723d9e4 in g_str_hash () at /lib64/libglib-2.0.so.0 #1 0x00007ffff723ce38 in g_hash_table_lookup () at /lib64/libglib-2.0.so.0 #2 0x0000555555cc0073 in object_class_property_find (klass=3D0x5555566a94= b0, name=3D0x0, errp=3D0x0) at qom/object.c:1135 #3 0x0000555555cc004b in object_class_property_find (klass=3D0x5555566a94= 40, name=3D0x0, errp=3D0x0) at qom/object.c:1129 #4 0x0000555555cbfe6e in object_property_find (obj=3D0x5555568348c0, name= =3D0x0, errp=3D0x0) at qom/object.c:1080 #5 0x0000555555cc183d in object_resolve_path_component (parent=3D0x555556= 8348c0, part=3D0x0) at qom/object.c:1762 #6 0x0000555555d82071 in qemu_chr_find (name=3D0x0) at chardev/char.c:802 #7 0x00005555559d77cb in mon_init_func (opaque=3D0x0, opts=3D0x5555566b65= a0, errp=3D0x0) at vl.c:2291 Fix it to instead fail gracefully. Signed-off-by: Eric Blake Message-Id: <20181023213600.364086-1-eblake@redhat.com> Reviewed-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Xu Signed-off-by: Markus Armbruster --- vl.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/vl.c b/vl.c index 03ed215d7b..55bab005b6 100644 --- a/vl.c +++ b/vl.c @@ -2323,6 +2323,10 @@ static int mon_init_func(void *opaque, QemuOpts *opt= s, Error **errp) } =20 chardev =3D qemu_opt_get(opts, "chardev"); + if (!chardev) { + error_report("chardev is required"); + exit(1); + } chr =3D qemu_chr_find(chardev); if (chr =3D=3D NULL) { error_setg(errp, "chardev \"%s\" not found", chardev); --=20 2.17.2