From nobody Thu Nov 6 12:14:35 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1540950984457178.8976654147433; Tue, 30 Oct 2018 18:56:24 -0700 (PDT) Received: from localhost ([::1]:56665 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHfk7-00083e-88 for importer@patchew.org; Tue, 30 Oct 2018 21:56:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60479) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHfV7-0000hz-25 for qemu-devel@nongnu.org; Tue, 30 Oct 2018 21:40:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gHfV3-0002Qs-MY for qemu-devel@nongnu.org; Tue, 30 Oct 2018 21:40:52 -0400 Received: from mail-qt1-x82f.google.com ([2607:f8b0:4864:20::82f]:41688) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gHfV3-0002NM-E8 for qemu-devel@nongnu.org; Tue, 30 Oct 2018 21:40:49 -0400 Received: by mail-qt1-x82f.google.com with SMTP id l41-v6so15967721qtl.8 for ; Tue, 30 Oct 2018 18:40:47 -0700 (PDT) Received: from localhost (76-251-165-188.lightspeed.austtx.sbcglobal.net. [76.251.165.188]) by smtp.gmail.com with ESMTPSA id j51-v6sm8460161qtj.26.2018.10.30.18.40.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 Oct 2018 18:40:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mK5a7Z5zumPu2nLwlxQAQAUPJW+cZQHhbt7ia2+g+Zw=; b=ZAKatNyH0RRdWoxYx8VYcLlWz4+7XvkoiQu3i+JyKtoyKBRNIDwqZbtMrs7GrWF5eF ERw4ShRsinqPmCiu3ubrypzUVpFIf63KQckZ36W4T99AoJ8SH6OSCmbzxaSihhkbINMP FXCsm1l8TSNUGcPBfajiXVNAlv3UhZ3zPRj4V5Pp0aTdViUF96+oLifjtT0n6oOIRkiu KTDDInHQN96PO0w47RZ/LM69WSKERnVbQieWzRUwwsu37JGFjjaS0f7Y3MmRsrayd3zz 1ROkGCha6rLQIRJBa+bMe/bJnjq0mVCLozaXT8hPlQSPmE7CiUErGrnwLjIB+3ZHwSTB SzAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=mK5a7Z5zumPu2nLwlxQAQAUPJW+cZQHhbt7ia2+g+Zw=; b=aQuvETNm7A6/Nb3n8M4svE6eWS2uui/4hF+2WpL0xoVOKrh0Kij+iate+LqjnGA2yu jdwR+Pgy/gYHy+7ljeh71oQ1nVJQoz+hfgW1TDnXaW1WnmHrq0W9MzLI2Z7+jHxqdAiG VsmbRUjJAIq9uH1Tp/B+SeFYz2FunUlIOJT5l1JCW3M8/iPo3XIZPkthrZ5/7gIBXNB3 u2wRe2AosLXSfTMoCOiM9wcmcD/SFnaqumFyIdAp+JHMYLHpRdhKmHTyCUTgI//q2asd hy6Dfb2xK955D0MspuTbnYnPlGLy73qX3CaHqR+TtTvU5U1Uq5whJBhxFSPT9vI76nAe ce3A== X-Gm-Message-State: AGRZ1gILWGXyoSw9TQSi2zFJAySGHL39LKdGXb3vdZ5bg9QgziCwjy40 IgAMorOMbWvrkAuBb6hBW4aSHCv8 X-Google-Smtp-Source: AJdET5duHEdBO+xOruEFiJyD2OEqaE9/DXfF/b3ZnfpU2Hu7xNdVxcnGSHIujMxOLRYH885kKILoWQ== X-Received: by 2002:ac8:2807:: with SMTP id 7-v6mr986584qtq.31.1540950046094; Tue, 30 Oct 2018 18:40:46 -0700 (PDT) From: Michael Roth To: qemu-devel@nongnu.org Date: Tue, 30 Oct 2018 20:38:20 -0500 Message-Id: <20181031013821.24023-24-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181031013821.24023-1-mdroth@linux.vnet.ibm.com> References: <20181031013821.24023-1-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::82f Subject: [Qemu-devel] [PULL v2 23/24] qga-win: report specific error when failing to open channel X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Useful in general, but especially now that errors might occur more frequently with --retry-path set. Signed-off-by: Michael Roth Reviewed-by: Marc-Andr=C3=A9 Lureau Signed-off-by: Michael Roth --- qga/channel-win32.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qga/channel-win32.c b/qga/channel-win32.c index b3597a8a0f..c86f4388db 100644 --- a/qga/channel-win32.c +++ b/qga/channel-win32.c @@ -302,7 +302,8 @@ static gboolean ga_channel_open(GAChannel *c, GAChannel= Method method, OPEN_EXISTING, FILE_FLAG_NO_BUFFERING | FILE_FLAG_OVERLAPPED, = NULL); if (c->handle =3D=3D INVALID_HANDLE_VALUE) { - g_critical("error opening path %s", newpath); + g_critical("error opening path %s: %s", newpath, + g_win32_error_message(GetLastError())); return false; } =20 --=20 2.17.1