From nobody Thu Nov 6 12:15:34 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 15409506427601003.458324985164; Tue, 30 Oct 2018 18:50:42 -0700 (PDT) Received: from localhost ([::1]:56634 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHfeb-0001Lp-Le for importer@patchew.org; Tue, 30 Oct 2018 21:50:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60355) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHfUu-0000YN-6s for qemu-devel@nongnu.org; Tue, 30 Oct 2018 21:40:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gHfUt-0002IF-Ay for qemu-devel@nongnu.org; Tue, 30 Oct 2018 21:40:40 -0400 Received: from mail-qt1-x830.google.com ([2607:f8b0:4864:20::830]:36093) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gHfUs-0002G4-Vg for qemu-devel@nongnu.org; Tue, 30 Oct 2018 21:40:39 -0400 Received: by mail-qt1-x830.google.com with SMTP id u34-v6so15976663qth.3 for ; Tue, 30 Oct 2018 18:40:35 -0700 (PDT) Received: from localhost (76-251-165-188.lightspeed.austtx.sbcglobal.net. [76.251.165.188]) by smtp.gmail.com with ESMTPSA id j4-v6sm15568556qte.84.2018.10.30.18.40.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 Oct 2018 18:40:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=ab6VptyiBF+UH0FW+m/qIjGDhVLzmPY8RK/Fm0aX5X0=; b=KPcixcl3Uahim3055cETAg4RYuf226LIPInImmTgu7tFa+WeAyKamy7KkuWoVJ+C+T r4olGtSeklLYVdEfhpAfhqnc+5NgFA047aMzWANaAmeLgBpzTYkMDxu5DMPn/ZTgd7yB aiXtB/LASSyGXTxscYsjihm0L05mY6uX8lLy+VJ3CIU+v6qnerzGg1W6su5p1iLm2sX1 INLpotXwTPGTL5YQsH7P5BIiXkXSzsxNDZhYP2eVtmZiB++UF5wGLL/GI/VQKHgIW5Ou 4qJZmIyzK0dzD04Iwg/jgLU8uV7eelaq6QClWLT8kV+IPPPH1rR/IVV6WfaF9kYsouuC knBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=ab6VptyiBF+UH0FW+m/qIjGDhVLzmPY8RK/Fm0aX5X0=; b=bDwllWO3CNWSemTrMACIGPakPnZksrxeG0hwInMyp4ZYiQ3x+F04TkirSouJ55Di5X 4Y37GTlVfVN6di06ztY867sbzWJ/2BiBpniK35mCr0QDcTB981h4XKrBfB8+fZmGLClz vwn2VyesMabFIRt1kIc98JBvqPrvriV3FjXCQPA5lp4wmeTwQ30bC8aPANKdLeiMB1JV BQpAt6MCSkGPica8G+SM4MdDJQQpyDRn/eyqTICG+tphVpJ1gvXqBIjAtkEPYtS7TyNn HWB901w1C+3GL4rPspRViGjb4l6Mp1JOYIvUtLmzKaJD1bYMAJ8yuJfQQoq6F0dmH5QP YCQA== X-Gm-Message-State: AGRZ1gKhYhfw4HAl45/+XB/kM3a0jdQckHFGULKPg2T90qPeWJnDS/SP Hx+XnXuXCOFow/Me2w4kTo2OtXa4 X-Google-Smtp-Source: AJdET5cBQ0jlPk0SoKqWoBBuvESyH0hoNI7c+6DcDdwz2k+YmBQRlMsFxhqDOsks9U/95u9TiPVmGw== X-Received: by 2002:ac8:164a:: with SMTP id x10mr992605qtk.67.1540950034435; Tue, 30 Oct 2018 18:40:34 -0700 (PDT) From: Michael Roth To: qemu-devel@nongnu.org Date: Tue, 30 Oct 2018 20:38:17 -0500 Message-Id: <20181031013821.24023-21-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181031013821.24023-1-mdroth@linux.vnet.ibm.com> References: <20181031013821.24023-1-mdroth@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::830 Subject: [Qemu-devel] [PULL v2 20/24] qga: move w32 service handling out of run_agent() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bishara AbuHattoum , peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Eventually we want a w32 service to be able to restart the qga main loop from within service_main(). To allow for this we move service handling out of run_agent() such that service_main() calls run_agent() instead of the reverse. Signed-off-by: Michael Roth Signed-off-by: Bishara AbuHattoum Signed-off-by: Michael Roth --- qga/main.c | 26 +++++++++++++++----------- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/qga/main.c b/qga/main.c index eb31f99b38..761007deb4 100644 --- a/qga/main.c +++ b/qga/main.c @@ -119,6 +119,7 @@ DWORD WINAPI service_ctrl_handler(DWORD ctrl, DWORD typ= e, LPVOID data, LPVOID ctx); VOID WINAPI service_main(DWORD argc, TCHAR *argv[]); #endif +static int run_agent(GAState *s); =20 static void init_dfl_pathnames(void) @@ -712,7 +713,7 @@ VOID WINAPI service_main(DWORD argc, TCHAR *argv[]) service->status.dwWaitHint =3D 0; SetServiceStatus(service->status_handle, &service->status); =20 - g_main_loop_run(ga_state->main_loop); + run_agent(ga_state); =20 service->status.dwCurrentState =3D SERVICE_STOPPED; SetServiceStatus(service->status_handle, &service->status); @@ -1340,17 +1341,8 @@ static int run_agent(GAState *s) g_critical("failed to initialize guest agent channel"); return EXIT_FAILURE; } -#ifndef _WIN32 + g_main_loop_run(ga_state->main_loop); -#else - if (s->config->daemonize) { - SERVICE_TABLE_ENTRY service_table[] =3D { - { (char *)QGA_SERVICE_NAME, service_main }, { NULL, NULL } }; - StartServiceCtrlDispatcher(service_table); - } else { - g_main_loop_run(ga_state->main_loop); - } -#endif =20 return EXIT_SUCCESS; } @@ -1436,7 +1428,19 @@ int main(int argc, char **argv) g_critical("error initializing guest agent"); goto end; } + +#ifdef _WIN32 + if (config->daemonize) { + SERVICE_TABLE_ENTRY service_table[] =3D { + { (char *)QGA_SERVICE_NAME, service_main }, { NULL, NULL } }; + StartServiceCtrlDispatcher(service_table); + } else { + ret =3D run_agent(s); + } +#else ret =3D run_agent(s); +#endif + cleanup_agent(s); =20 end: --=20 2.17.1