From nobody Thu Nov 6 12:14:38 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1540950317282291.31898038828706; Tue, 30 Oct 2018 18:45:17 -0700 (PDT) Received: from localhost ([::1]:56603 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHfZL-0004yy-Q6 for importer@patchew.org; Tue, 30 Oct 2018 21:45:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60184) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHfUc-0000JH-4w for qemu-devel@nongnu.org; Tue, 30 Oct 2018 21:40:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gHfUY-000249-3C for qemu-devel@nongnu.org; Tue, 30 Oct 2018 21:40:22 -0400 Received: from mail-qk1-x742.google.com ([2607:f8b0:4864:20::742]:36402) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gHfUX-0001ru-SE for qemu-devel@nongnu.org; Tue, 30 Oct 2018 21:40:17 -0400 Received: by mail-qk1-x742.google.com with SMTP id o125so5328419qkf.3 for ; Tue, 30 Oct 2018 18:40:00 -0700 (PDT) Received: from localhost (76-251-165-188.lightspeed.austtx.sbcglobal.net. [76.251.165.188]) by smtp.gmail.com with ESMTPSA id g80sm1057706qkh.41.2018.10.30.18.39.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 Oct 2018 18:39:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=V12rGQsTUHuze1dHFF69yG9N87hdC2Z0Se0NxY6Wtew=; b=LGIuaTCCvLpmWNKzx9be42cYnBpVyQqm3fXRgYwcs6DHkA1EpNLr1HM6LvMtDkCJFT L2GmOTI1rwDFgji8EkoaK+313fdFVuPMiqg55f0RDGulcLRyPA8CAjE7mhGQspvRppy7 l5IzMI+M5O4NARTq8GM64inXPSocZhw915oid7Q1cV3chL9Wpi6Lqm0+qUSSWQXxcXKa 7DtbxL1vQJH4ynMzVKbNOVWVXNLVe9aDNF5L+LK93SnVA+f6ra81w2zxM8My2ZN4/dDD lBcFZFhydHdRmZi/SyEG3Ly/mEXv+5enHv5KWKVoe3qMycjEg0AUIOyWRhDOlvwZMa2O QtZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=V12rGQsTUHuze1dHFF69yG9N87hdC2Z0Se0NxY6Wtew=; b=fQjd0Dut8+usCv9BXYyQEU8ZWEc0hMMLpOFDvHBAUz+QQ41pnECQPs633s3FUdV5Bv wuC77R6gJFo3mJNlNxf/0RI63F0UbXgGp0MJNa77cFEWTZ/s9VTiPmjisQL3yp4dERMR QmZRjet8Dg5f3/MiQA5sytZLsCwB0w42NhiJd2XqxG+Hv0hbsAnPxgYSjaW12rcrEdA/ +lr9UsitzhHjASG4vmMDQLcGTMbyiA+58yeaIMXGL4AJVm6e2LGvjJJGVKLAdwBMQtwC +KE3H08JBgIaIHu1uFmjtd35gRUfaUyiuB0XyYmabw5aeyieR3C6aX9V/1bkLeeAMYyv SaYQ== X-Gm-Message-State: AGRZ1gKXqP/f9wlX3dRL4TCrqEeLJ8YBxzY28y65DNVsyLewDEbO3m6w rX2gmuIXkxrEjxV4I6+slLrh+CEy X-Google-Smtp-Source: AJdET5f9JAPu9XfK9CvvjZHqs2DGxQiXp3FO3YlCGrPXuuFYzCh5ck9Ar8pyQBKfBnf/q+hsg8wIbA== X-Received: by 2002:a37:de15:: with SMTP id h21-v6mr901640qkj.254.1540949998978; Tue, 30 Oct 2018 18:39:58 -0700 (PDT) From: Michael Roth To: qemu-devel@nongnu.org Date: Tue, 30 Oct 2018 20:38:06 -0500 Message-Id: <20181031013821.24023-10-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181031013821.24023-1-mdroth@linux.vnet.ibm.com> References: <20181031013821.24023-1-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::742 Subject: [Qemu-devel] [PULL v2 09/24] build: rename CONFIG_QGA_NTDDDISK to CONFIG_QGA_NTDDSCSI X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, =?UTF-8?q?Tom=C3=A1=C5=A1=20Golembiovsk=C3=BD?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Tom=C3=A1=C5=A1 Golembiovsk=C3=BD There was inconsistency between commits: 50cbebb9a3 configure: add configure check for ntdddisk.h a3ef3b2272 qga: added bus type and disk location path The first commit added #define CONFIG_QGA_NTDDDISK but the second commit expected the name to be CONFIG_QGA_NTDDSCSI. As a result the code in second patch was never used. Renaming the option to CONFIG_QGA_NTDDSCSI to match the name of header file that is being checked for. Signed-off-by: Tom=C3=A1=C5=A1 Golembiovsk=C3=BD Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Sameeh Jubran Signed-off-by: Michael Roth --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 406f48f46e..081a3069e3 100755 --- a/configure +++ b/configure @@ -6144,7 +6144,7 @@ if test "$mingw32" =3D "yes" ; then echo "WIN_SDK=3D\"$win_sdk\"" >> $config_host_mak fi if test "$guest_agent_ntddscsi" =3D "yes" ; then - echo "CONFIG_QGA_NTDDDISK=3Dy" >> $config_host_mak + echo "CONFIG_QGA_NTDDSCSI=3Dy" >> $config_host_mak fi if test "$guest_agent_msi" =3D "yes"; then echo "QEMU_GA_MSI_ENABLED=3Dyes" >> $config_host_mak --=20 2.17.1