From nobody Thu Nov 6 12:15:34 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1540947169898183.55832426119946; Tue, 30 Oct 2018 17:52:49 -0700 (PDT) Received: from localhost ([::1]:56366 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHekY-0006DA-Ji for importer@patchew.org; Tue, 30 Oct 2018 20:52:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43344) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHeQw-0002cE-EK for qemu-devel@nongnu.org; Tue, 30 Oct 2018 20:32:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gHeQu-0004QI-8Z for qemu-devel@nongnu.org; Tue, 30 Oct 2018 20:32:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53196) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gHeQn-0004KT-Uk; Tue, 30 Oct 2018 20:32:22 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0F5B588306; Wed, 31 Oct 2018 00:32:21 +0000 (UTC) Received: from localhost (ovpn-116-56.gru2.redhat.com [10.97.116.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 887871001F53; Wed, 31 Oct 2018 00:32:20 +0000 (UTC) From: Eduardo Habkost To: Peter Maydell , qemu-devel@nongnu.org Date: Tue, 30 Oct 2018 21:31:20 -0300 Message-Id: <20181031003120.26771-16-ehabkost@redhat.com> In-Reply-To: <20181031003120.26771-1-ehabkost@redhat.com> References: <20181031003120.26771-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 31 Oct 2018 00:32:21 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 15/15] scripts/qemu.py: use a more consistent docstring style X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Fam Zheng , Eduardo Habkost , qemu-block@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Max Reitz , Cleber Rosa , =?UTF-8?q?Alex=20Benn=C3=A9e?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Cleber Rosa Signed-off-by: Cleber Rosa Message-Id: <20181004161852.11673-10-crosa@redhat.com> [ehabkost: reverted unintentional submodule update] Signed-off-by: Eduardo Habkost --- scripts/qemu.py | 65 +++++++++++++++++++++++++++++++------------------ 1 file changed, 41 insertions(+), 24 deletions(-) diff --git a/scripts/qemu.py b/scripts/qemu.py index 768611f1de..6e3b0e6771 100644 --- a/scripts/qemu.py +++ b/scripts/qemu.py @@ -59,9 +59,9 @@ class QEMUMachineAddDeviceError(QEMUMachineError): """ =20 class MonitorResponseError(qmp.qmp.QMPError): - ''' + """ Represents erroneous QMP monitor reply - ''' + """ def __init__(self, reply): try: desc =3D reply["error"]["desc"] @@ -72,14 +72,15 @@ class MonitorResponseError(qmp.qmp.QMPError): =20 =20 class QEMUMachine(object): - '''A QEMU VM + """ + A QEMU VM =20 Use this object as a context manager to ensure the QEMU process termin= ates:: =20 with VM(binary) as vm: ... # vm is guaranteed to be shut down here - ''' + """ =20 def __init__(self, binary, args=3DNone, wrapper=3DNone, name=3DNone, test_dir=3D"/var/tmp", monitor_address=3DNone, @@ -141,7 +142,9 @@ class QEMUMachine(object): self._args.append(args) =20 def add_fd(self, fd, fdset, opaque, opts=3D''): - '''Pass a file descriptor to the VM''' + """ + Pass a file descriptor to the VM + """ options =3D ['fd=3D%d' % fd, 'set=3D%d' % fdset, 'opaque=3D%s' % opaque] @@ -197,7 +200,9 @@ class QEMUMachine(object): =20 @staticmethod def _remove_if_exists(path): - '''Remove file object at path if it exists''' + """ + Remove file object at path if it exists + """ try: os.remove(path) except OSError as exception: @@ -300,7 +305,9 @@ class QEMUMachine(object): raise =20 def _launch(self): - '''Launch the VM and establish a QMP connection''' + """ + Launch the VM and establish a QMP connection + """ devnull =3D open(os.path.devnull, 'rb') self._pre_launch() self._qemu_full_args =3D (self._wrapper + [self._binary] + @@ -314,14 +321,18 @@ class QEMUMachine(object): self._post_launch() =20 def wait(self): - '''Wait for the VM to power off''' + """ + Wait for the VM to power off + """ self._popen.wait() self._qmp.close() self._load_io_log() self._post_shutdown() =20 def shutdown(self): - '''Terminate the VM and clean up''' + """ + Terminate the VM and clean up + """ if self.is_running(): try: self._qmp.cmd('quit') @@ -345,7 +356,9 @@ class QEMUMachine(object): self._launched =3D False =20 def qmp(self, cmd, conv_keys=3DTrue, **args): - '''Invoke a QMP command and return the response dict''' + """ + Invoke a QMP command and return the response dict + """ qmp_args =3D dict() for key, value in args.items(): if conv_keys: @@ -356,11 +369,11 @@ class QEMUMachine(object): return self._qmp.cmd(cmd, args=3Dqmp_args) =20 def command(self, cmd, conv_keys=3DTrue, **args): - ''' + """ Invoke a QMP command. On success return the response dict. On failure raise an exception. - ''' + """ reply =3D self.qmp(cmd, conv_keys, **args) if reply is None: raise qmp.qmp.QMPError("Monitor is closed") @@ -369,13 +382,17 @@ class QEMUMachine(object): return reply["return"] =20 def get_qmp_event(self, wait=3DFalse): - '''Poll for one queued QMP events and return it''' + """ + Poll for one queued QMP events and return it + """ if len(self._events) > 0: return self._events.pop(0) return self._qmp.pull_event(wait=3Dwait) =20 def get_qmp_events(self, wait=3DFalse): - '''Poll for queued QMP events and return a list of dicts''' + """ + Poll for queued QMP events and return a list of dicts + """ events =3D self._qmp.get_events(wait=3Dwait) events.extend(self._events) del self._events[:] @@ -383,7 +400,7 @@ class QEMUMachine(object): return events =20 def event_wait(self, name, timeout=3D60.0, match=3DNone): - ''' + """ Wait for specified timeout on named event in QMP; optionally filter results by match. =20 @@ -391,7 +408,7 @@ class QEMUMachine(object): branch processing on match's value None {"foo": {"bar": 1}} matches {"foo": None} {"foo": {"bar": 1}} does not matches {"foo": {"baz": None}} - ''' + """ def event_match(event, match=3DNone): if match is None: return True @@ -424,29 +441,29 @@ class QEMUMachine(object): return None =20 def get_log(self): - ''' + """ After self.shutdown or failed qemu execution, this returns the out= put of the qemu process. - ''' + """ return self._iolog =20 def add_args(self, *args): - ''' + """ Adds to the list of extra arguments to be given to the QEMU binary - ''' + """ self._args.extend(args) =20 def set_machine(self, machine_type): - ''' + """ Sets the machine type =20 If set, the machine type will be added to the base arguments of the resulting QEMU command line. - ''' + """ self._machine =3D machine_type =20 def set_console(self, device_type=3DNone): - ''' + """ Sets the device type for a console device =20 If set, the console device and a backing character device will @@ -464,7 +481,7 @@ class QEMUMachine(object): @param device_type: the device type, such as "isa-serial" @raises: QEMUMachineAddDeviceError if the device type is not given and can not be determined. - ''' + """ if device_type is None: if self._machine is None: raise QEMUMachineAddDeviceError("Can not add a console dev= ice:" --=20 2.18.0.rc1.1.g3f1ff2140