From nobody Thu Nov 6 10:17:48 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1540918918559355.0421202874876; Tue, 30 Oct 2018 10:01:58 -0700 (PDT) Received: from localhost ([::1]:54502 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHXOv-0006uE-Bp for importer@patchew.org; Tue, 30 Oct 2018 13:01:57 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34855) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHXNk-0006Pa-NI for qemu-devel@nongnu.org; Tue, 30 Oct 2018 13:00:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gHXNj-000708-JK for qemu-devel@nongnu.org; Tue, 30 Oct 2018 13:00:44 -0400 Received: from orth.archaic.org.uk ([2001:8b0:1d0::2]:52146) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gHXNj-0006s2-CQ for qemu-devel@nongnu.org; Tue, 30 Oct 2018 13:00:43 -0400 Received: from pm215 by orth.archaic.org.uk with local (Exim 4.89) (envelope-from ) id 1gHXNb-0001I7-BD; Tue, 30 Oct 2018 17:00:35 +0000 From: Peter Maydell To: qemu-devel@nongnu.org Date: Tue, 30 Oct 2018 17:00:32 +0000 Message-Id: <20181030170032.1844-1-peter.maydell@linaro.org> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:8b0:1d0::2 Subject: [Qemu-devel] [PATCH for-3.1] milkymist: Check for failure trying to load BIOS image X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Walle , patches@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Check the return value from load_image_targphys(), which tells us whether our attempt to load the BIOS image into RAM failed. (Spotted by Coverity, CID 1190305.) Signed-off-by: Peter Maydell Acked-by: Michael Walle Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/lm32/milkymist.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/lm32/milkymist.c b/hw/lm32/milkymist.c index 321f184595e..63c6894c955 100644 --- a/hw/lm32/milkymist.c +++ b/hw/lm32/milkymist.c @@ -138,7 +138,10 @@ milkymist_init(MachineState *machine) bios_filename =3D qemu_find_file(QEMU_FILE_TYPE_BIOS, bios_name); =20 if (bios_filename) { - load_image_targphys(bios_filename, BIOS_OFFSET, BIOS_SIZE); + if (load_image_targphys(bios_filename, BIOS_OFFSET, BIOS_SIZE) < 0= ) { + error_report("could not load bios '%s'", bios_filename); + exit(1); + } } =20 reset_info->bootstrap_pc =3D BIOS_OFFSET; --=20 2.19.1