From nobody Thu Nov 6 12:31:04 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 15409126827881006.6063810203806; Tue, 30 Oct 2018 08:18:02 -0700 (PDT) Received: from localhost ([::1]:53832 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHVm9-00062f-I2 for importer@patchew.org; Tue, 30 Oct 2018 11:17:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53398) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHVcd-0005tx-HQ for qemu-devel@nongnu.org; Tue, 30 Oct 2018 11:08:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gHVcZ-0006E0-OG for qemu-devel@nongnu.org; Tue, 30 Oct 2018 11:07:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59548) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gHVcZ-0004vP-D7 for qemu-devel@nongnu.org; Tue, 30 Oct 2018 11:07:55 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3AF7EC068BD2; Tue, 30 Oct 2018 15:07:29 +0000 (UTC) Received: from localhost (ovpn-112-20.ams2.redhat.com [10.36.112.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4AAD36091D; Tue, 30 Oct 2018 15:06:45 +0000 (UTC) From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= To: qemu-devel@nongnu.org Date: Tue, 30 Oct 2018 19:04:49 +0400 Message-Id: <20181030150453.9344-7-marcandre.lureau@redhat.com> In-Reply-To: <20181030150453.9344-1-marcandre.lureau@redhat.com> References: <20181030150453.9344-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 30 Oct 2018 15:07:29 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 06/10] qom/object: set globals when initializing object X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , Amit Shah , "Michael S. Tsirkin" , Mark Cave-Ayland , dgilbert@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Igor Mammedov , Paolo Bonzini , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Set globals for all objects, although only TYPE_DEVICE & TYPE_USER_CREATABLE can have globals for now. Replaces the qdev post-init callback (which was the last called in the hierarchy order) by an explicit call during object creation after post-init, to maintain the call ordering. Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/core/qdev.c | 6 ------ qom/object.c | 2 ++ 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 09a2c4df62..6a25fa027c 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -970,11 +970,6 @@ static void device_initfn(Object *obj) QLIST_INIT(&dev->gpios); } =20 -static void device_post_init(Object *obj) -{ - object_property_set_globals(obj); -} - /* Unlink device from bus and free the structure. */ static void device_finalize(Object *obj) { @@ -1098,7 +1093,6 @@ static const TypeInfo device_type_info =3D { .parent =3D TYPE_OBJECT, .instance_size =3D sizeof(DeviceState), .instance_init =3D device_initfn, - .instance_post_init =3D device_post_init, .instance_finalize =3D device_finalize, .class_base_init =3D device_class_base_init, .class_init =3D device_class_init, diff --git a/qom/object.c b/qom/object.c index eb770dbf7f..7300878125 100644 --- a/qom/object.c +++ b/qom/object.c @@ -12,6 +12,7 @@ =20 #include "qemu/osdep.h" #include "qapi/error.h" +#include "qom/globals.h" #include "qom/object.h" #include "qom/object_interfaces.h" #include "qemu/cutils.h" @@ -390,6 +391,7 @@ static void object_initialize_with_type(void *data, siz= e_t size, TypeImpl *type) NULL, object_property_free); object_init_with_type(obj, type); object_post_init_with_type(obj, type); + object_property_set_globals(obj); } =20 void object_initialize(void *data, size_t size, const char *typename) --=20 2.19.0.271.gfe8321ec05