From nobody Thu Nov 6 12:13:07 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1540912171495103.78110929941681; Tue, 30 Oct 2018 08:09:31 -0700 (PDT) Received: from localhost ([::1]:53777 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHVe6-0006q0-2U for importer@patchew.org; Tue, 30 Oct 2018 11:09:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46459) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHVGa-0007wm-Q9 for qemu-devel@nongnu.org; Tue, 30 Oct 2018 10:45:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gHVGZ-0000om-Jw for qemu-devel@nongnu.org; Tue, 30 Oct 2018 10:45:12 -0400 Received: from mail-qt1-x82f.google.com ([2607:f8b0:4864:20::82f]:40703) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gHVGZ-0000nc-An for qemu-devel@nongnu.org; Tue, 30 Oct 2018 10:45:11 -0400 Received: by mail-qt1-x82f.google.com with SMTP id k12so7857772qtf.7 for ; Tue, 30 Oct 2018 07:45:11 -0700 (PDT) Received: from localhost (76-251-165-188.lightspeed.austtx.sbcglobal.net. [76.251.165.188]) by smtp.gmail.com with ESMTPSA id 5-v6sm16934690qtz.8.2018.10.30.07.45.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 Oct 2018 07:45:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mK5a7Z5zumPu2nLwlxQAQAUPJW+cZQHhbt7ia2+g+Zw=; b=HmZsSvpkZNzR760lqMpHpqwP+AirAiVhJOmco+Fnk7mFxV6aRpdNegu7m8Vq/XGB9x tA1cyVOW0ZihZ7BZpL8LjVDeKtb4s4UakJKzUET69wnVLB0tn7kWxeayYcCztXsU9Num tVw8vz1QZw/SnJqVx75dl1QmuhsNNaaWitmwowJs6OaUoop8fwr8SmDh/87Wgxl8KjW2 v1BOhV1dKT1CP9irnjnsNWLUsyPEtdhZdpj/nlezCsakplB+V8zFJmEgDbM3BKJVWOnL JHL8ZdvO8o37G32NQdLO3R+FPDtVZEmnjLxOT6K3NXRZgE870X38sGBrYnrNlpvrCZu5 kAtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=mK5a7Z5zumPu2nLwlxQAQAUPJW+cZQHhbt7ia2+g+Zw=; b=FNw4rllk1EQQ/EJUIArhDVhaQMbRLiR1ZkIo0e7syEGo5jdED5WFf+YvXQ2wjAuJ9v hEsTMUu19egMpArT+jDRg1+oBJorb+nQJo4tlvA53fSbIiUzid1jWS2B4bpKgs3kYneg KK3BLUCqoayOz2xFL9KCYWXo85DzJUmCBHAtnIJIbE3GYjEm02lGNRfPd172u1MHzdUP qiM8QIx66GL1NJt8yAMy7oVmsdOIyMktzCws6i25ysDTTgaLvSrtLP6nG55AooVLpox0 khNnleH5sPONXz/0kM8L2JW0EWuM4DcY+zl7s6c1i7GITVdX6r6ahKi8f2Vxy4C7OsNW W9rQ== X-Gm-Message-State: AGRZ1gK5P86xUOqS1r7ckTtbW4BarI5Mq0V21bZeR2p3oX3/5nBoUdjE 8PibQhSW4eQQ0JcdVQFGQbF6ZjBc X-Google-Smtp-Source: AJdET5e4Xn8/Mqi8mwXQc0dRXs9BXdOQ2SV2T/C2oCrSDznEIUO2D3+KUHUa9EVfNQMHuCwURElNOw== X-Received: by 2002:ac8:1aa8:: with SMTP id x37-v6mr2496044qtj.44.1540910709750; Tue, 30 Oct 2018 07:45:09 -0700 (PDT) From: Michael Roth To: qemu-devel@nongnu.org Date: Tue, 30 Oct 2018 09:43:57 -0500 Message-Id: <20181030144358.23144-24-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181030144358.23144-1-mdroth@linux.vnet.ibm.com> References: <20181030144358.23144-1-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::82f Subject: [Qemu-devel] [PULL 23/24] qga-win: report specific error when failing to open channel X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Useful in general, but especially now that errors might occur more frequently with --retry-path set. Signed-off-by: Michael Roth Reviewed-by: Marc-Andr=C3=A9 Lureau Signed-off-by: Michael Roth --- qga/channel-win32.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qga/channel-win32.c b/qga/channel-win32.c index b3597a8a0f..c86f4388db 100644 --- a/qga/channel-win32.c +++ b/qga/channel-win32.c @@ -302,7 +302,8 @@ static gboolean ga_channel_open(GAChannel *c, GAChannel= Method method, OPEN_EXISTING, FILE_FLAG_NO_BUFFERING | FILE_FLAG_OVERLAPPED, = NULL); if (c->handle =3D=3D INVALID_HANDLE_VALUE) { - g_critical("error opening path %s", newpath); + g_critical("error opening path %s: %s", newpath, + g_win32_error_message(GetLastError())); return false; } =20 --=20 2.17.1