From nobody Thu Nov 6 12:13:09 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1540910828510945.3337131469746; Tue, 30 Oct 2018 07:47:08 -0700 (PDT) Received: from localhost ([::1]:53651 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHVIF-0000IR-Tc for importer@patchew.org; Tue, 30 Oct 2018 10:46:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHVG8-0007Vb-Qq for qemu-devel@nongnu.org; Tue, 30 Oct 2018 10:44:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gHVG3-0008UX-Hk for qemu-devel@nongnu.org; Tue, 30 Oct 2018 10:44:44 -0400 Received: from mail-qt1-x844.google.com ([2607:f8b0:4864:20::844]:45330) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gHVFz-0008FF-Oa for qemu-devel@nongnu.org; Tue, 30 Oct 2018 10:44:38 -0400 Received: by mail-qt1-x844.google.com with SMTP id l9-v6so13690255qtj.12 for ; Tue, 30 Oct 2018 07:44:24 -0700 (PDT) Received: from localhost (76-251-165-188.lightspeed.austtx.sbcglobal.net. [76.251.165.188]) by smtp.gmail.com with ESMTPSA id x65-v6sm12689105qkc.11.2018.10.30.07.44.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 Oct 2018 07:44:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WPWBh6By3Y4gxc13mbKpC2tU/e7So4GXs2Y4fF/82OA=; b=BKJcgUJ33bsJRqsit/8XdckbG8Gjlv3BNd/N0n1pE8fqMSXDFh2JPOoxw14kzJTuG5 JGsMqyyWtths34goSAnr2exuTA02cmXCsamSq6/m+gav3xDqLXwiwS+roCAknRwotr4o lO+oQlaj5vwTAZ9DPMvEVSB+WFANkMqvFqxwJR16nJVeIjjGwbbz6Fhf18g+d18iRPA4 3qp7vGpFi6mapoXrMvqgsqPXdF1xlt92JeN2L49tgOz8Nga6DelrPvObw8boWP4iAbvP eUs3x9ufw1quX6Arfye9eXMnWuOxZ5suuKmWBUSF6Ys5pzY3UWiW5dpZQBtnfGwaGji2 e/ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=WPWBh6By3Y4gxc13mbKpC2tU/e7So4GXs2Y4fF/82OA=; b=Jr2Mk+3bM4v+U3GSM7AVR+0LpslwWaj6nRpLy652VP5qonVCPQKXViUC1G9uLUtA7i n2BNnGodz9fwFbJ2n9G4sdBbnZRdZk2hk3V4B9fpNVgidfpq6kuRa4Cgiby8sRvaxfiX WIrby4NZy3oDo3pK8V7G9c4JsVcJp9MWWqvu8zOx6iU28NJsOomwyW1zVtyGueCCrx2S C5xac64J1ioAbTMSxis51PyN2cDy/fBMged/BNZKiyn0R+lamHSjlphJ+azNyDGM1Dqi FAOXCJNeUdpl3Pd9VqV0R6vMJnGqb9TMQvrLJs4CSUB/IXccxDS9Y0dC+WUGzpuHgePa /0ng== X-Gm-Message-State: AGRZ1gJDCK2Gny/HIrkfppy84RslqcVNY+HD2RAaZXNwmr8CLUtS/OIj pvztfIaTwGGlByQ6ZC4eRI5eBaJv X-Google-Smtp-Source: AJdET5ePXQTxmH6gP6N+krCRqmt9meX01zyDuDQ2g+e44B3FcPXYgKoDMaQb2P8Hu4IbkOa4zpYBww== X-Received: by 2002:ac8:c84:: with SMTP id n4-v6mr2468972qti.192.1540910663165; Tue, 30 Oct 2018 07:44:23 -0700 (PDT) From: Michael Roth To: qemu-devel@nongnu.org Date: Tue, 30 Oct 2018 09:43:43 -0500 Message-Id: <20181030144358.23144-10-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181030144358.23144-1-mdroth@linux.vnet.ibm.com> References: <20181030144358.23144-1-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::844 Subject: [Qemu-devel] [PULL 09/24] build: rename CONFIG_QGA_NTDDDISK to CONFIG_QGA_NTDDSCSI X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, =?UTF-8?q?Tom=C3=A1=C5=A1=20Golembiovsk=C3=BD?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Tom=C3=A1=C5=A1 Golembiovsk=C3=BD There was inconsistency between commits: 50cbebb9a3 configure: add configure check for ntdddisk.h a3ef3b2272 qga: added bus type and disk location path The first commit added #define CONFIG_QGA_NTDDDISK but the second commit expected the name to be CONFIG_QGA_NTDDSCSI. As a result the code in second patch was never used. Renaming the option to CONFIG_QGA_NTDDSCSI to match the name of header file that is being checked for. Signed-off-by: Tom=C3=A1=C5=A1 Golembiovsk=C3=BD Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Sameeh Jubran Signed-off-by: Michael Roth --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index eea3b0c7a4..e63ec5e60d 100755 --- a/configure +++ b/configure @@ -6136,7 +6136,7 @@ if test "$mingw32" =3D "yes" ; then echo "WIN_SDK=3D\"$win_sdk\"" >> $config_host_mak fi if test "$guest_agent_ntddscsi" =3D "yes" ; then - echo "CONFIG_QGA_NTDDDISK=3Dy" >> $config_host_mak + echo "CONFIG_QGA_NTDDSCSI=3Dy" >> $config_host_mak fi if test "$guest_agent_msi" =3D "yes"; then echo "QEMU_GA_MSI_ENABLED=3Dyes" >> $config_host_mak --=20 2.17.1