From nobody Mon Feb 9 01:09:54 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1540818196553960.811830121611; Mon, 29 Oct 2018 06:03:16 -0700 (PDT) Received: from localhost ([::1]:45427 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gH7CN-0003XG-Fm for importer@patchew.org; Mon, 29 Oct 2018 09:03:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50746) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gH7AB-0001vD-5m for qemu-devel@nongnu.org; Mon, 29 Oct 2018 09:01:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gH7A7-0004G0-2I for qemu-devel@nongnu.org; Mon, 29 Oct 2018 09:00:59 -0400 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:45281) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gH7A6-000435-Q7; Mon, 29 Oct 2018 09:00:54 -0400 Received: by mail-wr1-x441.google.com with SMTP id n5-v6so8551858wrw.12; Mon, 29 Oct 2018 06:00:40 -0700 (PDT) Received: from x1.redhat.com ([195.166.127.210]) by smtp.gmail.com with ESMTPSA id n7-v6sm7441142wrr.81.2018.10.29.06.00.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Oct 2018 06:00:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tNjrC/pGw0eGeVtNQBbofdQUL+4ecHNO0puGOj16MlE=; b=VFve2bOKv43G+Gx0SV0675H2ZVk/ISVvrB1SNi3R1KwvXVkSfuy0yGa+nt+61InHo8 MQ6+kdt88nC9q17Nsvkta6s6CARbN+Pz2+heNjkd/Pf6mj+OAKvSuD7IvuO0Fwtn7rWD WMihwVvim5WZCs/nJPSBy1ypOt3u9i95Op96HhMXvf17lSMHyMu24s4DqkJ5eTo2BY+u +sHaIXWojSUrRs3ggZvr0Rhq12wpxLUdg7Wm7CZyH+RcGXia/frp28MiNusM7zKSUYrg 9gjqNHnOeQev4SM20g+4KBxfT6lL1toUphGY1FQzwQ6/wmbMDYgLQ/x2ImSUlRbL8MEe oD4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=tNjrC/pGw0eGeVtNQBbofdQUL+4ecHNO0puGOj16MlE=; b=r+t30/PuMX3exf8GSee7N+OXusXNo5o9uEWt4fRTlLrGLPzUhj/PmXd3L3OMaKTTkS WJtI9IMH2KwKvCuHln48Nm3s9X6yb32nFRp8RX83Ec+FaYub5thqsS82sq7PmMgRiaxb ivd5ID7DM3sEltAJYxrsWY0rhyfK6Asvb6NJOKB5+ed+1VD07hjmYq8byz90Hp9C+DZK hpv/hsbehAkf89FgqY6NfxYb1xZ3bOB1xBFKtkRl7xG44VJoFdtsg0YliiJQQepQr0nm vItS9VlYjwJH65nvJg24vsyixmqF2e3OaDf8kIbY3+TctI87aS0LMWmDb6ADW0iw8wD4 JTrw== X-Gm-Message-State: AGRZ1gJqFxy3k03AFfz2N9g/O4TNJvV2vZejpcAuyn2ELgTKOq1nXz8k 7mqUMY62VR4//YJhLnhdaFo= X-Google-Smtp-Source: AJdET5cpg+ROpHANoHVAxcxh6DA4eI1L0qt5Ct3ska8ySn8VM/esSqRsWThhrfVXz/T60j8vdbC7kg== X-Received: by 2002:adf:f74f:: with SMTP id z15-v6mr14789928wrp.237.1540818039021; Mon, 29 Oct 2018 06:00:39 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Michael Walle , Jason Wang , Laurent Vivier Date: Mon, 29 Oct 2018 14:00:34 +0100 Message-Id: <20181029130034.26750-1-f4bug@amsat.org> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::441 Subject: [Qemu-devel] [PATCH v3] milkymist-minimac2: Use qemu_log_mask(GUEST_ERROR) instead of error_report X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) qemu_log_mask(GUEST_ERROR) is more appropriate: $ qemu -d help Log items (comma separated): guest_errors log when the guest OS does something invalid (eg accessin= g a non-existent register) Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Michael Walle --- v3: Fixed format string (Peter Maydell) hw/net/milkymist-minimac2.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/net/milkymist-minimac2.c b/hw/net/milkymist-minimac2.c index 7ef1daee41..85c9fc0b65 100644 --- a/hw/net/milkymist-minimac2.c +++ b/hw/net/milkymist-minimac2.c @@ -30,6 +30,7 @@ #include "hw/sysbus.h" #include "trace.h" #include "net/net.h" +#include "qemu/log.h" #include "qemu/error-report.h" =20 #include @@ -214,7 +215,8 @@ static size_t assemble_frame(uint8_t *buf, size_t size, uint32_t crc; =20 if (size < payload_size + 12) { - error_report("milkymist_minimac2: received too big ethernet frame"= ); + qemu_log_mask(LOG_GUEST_ERROR, "milkymist_minimac2: frame too big " + "(%zd bytes)\n", payload_size); return 0; } =20 @@ -347,8 +349,9 @@ minimac2_read(void *opaque, hwaddr addr, unsigned size) break; =20 default: - error_report("milkymist_minimac2: read access to unknown register = 0x" - TARGET_FMT_plx, addr << 2); + qemu_log_mask(LOG_GUEST_ERROR, + "milkymist_minimac2_rd%d: 0x%" HWADDR_PRIx "\n", + size, addr << 2); break; } =20 @@ -413,8 +416,10 @@ minimac2_write(void *opaque, hwaddr addr, uint64_t val= ue, break; =20 default: - error_report("milkymist_minimac2: write access to unknown register= 0x" - TARGET_FMT_plx, addr << 2); + qemu_log_mask(LOG_GUEST_ERROR, + "milkymist_minimac2_wr%d: 0x%" HWADDR_PRIx + " =3D 0x%" PRIx64 "\n", + size, addr << 2, value); break; } } --=20 2.19.1