From nobody Thu Nov 6 08:26:14 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1540548714793676.1613375343541; Fri, 26 Oct 2018 03:11:54 -0700 (PDT) Received: from localhost ([::1]:59310 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFz5l-0001jn-5y for importer@patchew.org; Fri, 26 Oct 2018 06:11:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37123) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFz4u-0001Qf-CB for qemu-devel@nongnu.org; Fri, 26 Oct 2018 06:10:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gFz4p-0008HN-TQ for qemu-devel@nongnu.org; Fri, 26 Oct 2018 06:10:49 -0400 Received: from mo6-p00-ob.smtp.rzone.de ([2a01:238:20a:202:5300::1]:35247) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gFz4k-0007zq-A3 for qemu-devel@nongnu.org; Fri, 26 Oct 2018 06:10:44 -0400 Received: from sender by smtp.strato.de (RZmta 44.3 AUTH) with ESMTPSA id 906dd1u9QAAJe7c (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Fri, 26 Oct 2018 12:10:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1540548632; s=strato-dkim-0002; d=aepfle.de; h=Message-Id:Date:Subject:Cc:To:From:X-RZG-CLASS-ID:X-RZG-AUTH:From: Subject:Sender; bh=d/sk+gYVOHWS0uwQ4SmPFODqFxgUshSKqzKuPsxRg1M=; b=SVPWIIEjY6obG+sOnq0jZWXnMJuymt0Vx4uhHdSi7cRAbQ3PXdcpciU0oqCRLyNiKw Nt4DfZUiUby/sMP5b6p3EfYIY+NSlugK5KwcGK0DXvyX0o3Vuh7bFwmDtXFPsr6C5Kd5 NO5Xo78C6UQ5ib1C2t6aj7qL0pTQFkxts4sLqQvn+EA736QIVA1f9h4wYVepkQs1pta+ GZlnN4oElaoPXwmllwKFaoJ+VY+mh6tgN8EJ4vHUu9Z9D7fnwDRdAwhEBzw9UDNrnTzT QS3RdTze6KwQttK4B0WXWM0FJCMMut+GcrGHOP+nTi8r4Mv432KGm0Lt3WXdpvq68VQb 2ypg== X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzpIG0mv9coXAgc0/lb4QMstw0mqi/C51hpW50R4vli8caicjAbM" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: qemu-devel@nongnu.org Date: Fri, 26 Oct 2018 12:10:16 +0200 Message-Id: <20181026101016.28584-1-olaf@aepfle.de> X-Mailer: git-send-email 2.16.4 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 2a01:238:20a:202:5300::1 Subject: [Qemu-devel] [PATCH v1] xen: preserve COMPAT in CFLAGS X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anthony Perard , "open list:X86" , Olaf Hering , Stefano Stabellini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" A given Qemu version can not predict what version of Xen it will run on. There are some checks in configure to decide what Xen libraries and functions are available. How exactly these functions must be accessed has to be decided by configure and the user who is compiling Qemu. In no way some random header file must override this decision. Remove the breakage introduced by commit 5eeb39c24b, which would always hide the libxc interfaces the given version of Qemu knows about. The current symptom of such breakage is a build failure with qemu-2.9 and older, in combination with Xen 4.12. Fixes: 5eeb39c24b7d4da5d129bfdd9c4fd21cfb3d28d6 Signed-off-by: Olaf Hering --- include/hw/xen/xen_common.h | 9 --------- 1 file changed, 9 deletions(-) diff --git a/include/hw/xen/xen_common.h b/include/hw/xen/xen_common.h index 5f1402b494..33fa2d3497 100644 --- a/include/hw/xen/xen_common.h +++ b/include/hw/xen/xen_common.h @@ -1,15 +1,6 @@ #ifndef QEMU_HW_XEN_COMMON_H #define QEMU_HW_XEN_COMMON_H =20 -/* - * If we have new enough libxenctrl then we do not want/need these compat - * interfaces, despite what the user supplied cflags might say. They - * must be undefined before including xenctrl.h - */ -#undef XC_WANT_COMPAT_EVTCHN_API -#undef XC_WANT_COMPAT_GNTTAB_API -#undef XC_WANT_COMPAT_MAP_FOREIGN_API - #include #include #include