From nobody Thu Nov 6 08:19:38 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 154053925066449.81990065985542; Fri, 26 Oct 2018 00:34:10 -0700 (PDT) Received: from localhost ([::1]:58656 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFwcw-0005Br-OC for importer@patchew.org; Fri, 26 Oct 2018 03:33:50 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45585) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFwbx-0004TJ-Bz for qemu-devel@nongnu.org; Fri, 26 Oct 2018 03:32:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gFwbt-00072N-D9 for qemu-devel@nongnu.org; Fri, 26 Oct 2018 03:32:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52284) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gFwbt-00071q-65 for qemu-devel@nongnu.org; Fri, 26 Oct 2018 03:32:45 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 39E073091743; Fri, 26 Oct 2018 07:32:44 +0000 (UTC) Received: from localhost.localdomain (unknown [10.65.150.231]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8765A60C5C; Fri, 26 Oct 2018 07:32:41 +0000 (UTC) From: P J P To: Qemu Developers Date: Fri, 26 Oct 2018 13:00:34 +0530 Message-Id: <20181026073034.16648-1-ppandit@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Fri, 26 Oct 2018 07:32:44 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2] strongarm: mask off high[32:28] bits from dir and state registers X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , liqsub1 , Moguofang , Prasad J Pandit Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Prasad J Pandit The high[32:28] bits of 'direction' and 'state' registers of SA-1100/SA-1110 device are reserved. Setting them may lead to OOB 's->handler[]' array access issue. Mask off [32:28] bits to avoid it. Reported-by: Moguofang Signed-off-by: Prasad J Pandit --- hw/arm/strongarm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Update v2: mask off high[32:28] bits -> https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg05746.html diff --git a/hw/arm/strongarm.c b/hw/arm/strongarm.c index ec2627374d..dd8c4b1f2e 100644 --- a/hw/arm/strongarm.c +++ b/hw/arm/strongarm.c @@ -587,12 +587,12 @@ static void strongarm_gpio_write(void *opaque, hwaddr= offset, =20 switch (offset) { case GPDR: /* GPIO Pin-Direction registers */ - s->dir =3D value; + s->dir =3D value & 0x3fffff; strongarm_gpio_handler_update(s); break; =20 case GPSR: /* GPIO Pin-Output Set registers */ - s->olevel |=3D value; + s->olevel |=3D value & 0x3fffff; strongarm_gpio_handler_update(s); break; =20 --=20 2.17.2