From nobody Thu Nov 6 10:16:09 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1540460143264712.6432812076625; Thu, 25 Oct 2018 02:35:43 -0700 (PDT) Received: from localhost ([::1]:53422 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFc3K-0002LC-8t for importer@patchew.org; Thu, 25 Oct 2018 05:35:42 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50347) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFbzT-0007Zv-0b for qemu-devel@nongnu.org; Thu, 25 Oct 2018 05:31:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gFbzO-0008Uf-1O for qemu-devel@nongnu.org; Thu, 25 Oct 2018 05:31:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49876) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gFbzM-0008Ib-C9 for qemu-devel@nongnu.org; Thu, 25 Oct 2018 05:31:37 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6184E30F5593 for ; Thu, 25 Oct 2018 09:31:30 +0000 (UTC) Received: from lupin.home.kraxel.org (ovpn-117-207.ams2.redhat.com [10.36.117.207]) by smtp.corp.redhat.com (Postfix) with ESMTP id 718FF102BCEB; Thu, 25 Oct 2018 09:31:24 +0000 (UTC) Received: by lupin.home.kraxel.org (Postfix, from userid 1000) id 5888F628B937; Thu, 25 Oct 2018 10:52:56 +0200 (CEST) From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Thu, 25 Oct 2018 10:52:55 +0200 Message-Id: <20181025085256.20522-3-kraxel@redhat.com> In-Reply-To: <20181025085256.20522-1-kraxel@redhat.com> References: <20181025085256.20522-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Thu, 25 Oct 2018 09:31:30 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 2/3] adlib: mark as insecure and deprecated. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: libvir-list@redhat.com, Gerd Hoffmann , Prasad J Pandit Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" We have a lovely, guest-triggerable buffer overflow in opl2 emulation. Reproducer: outw(0xff60, 0x220); outw(0x1020, 0x220); outw(0xffb0, 0x220); Result: Will overflow FM_OPL->AR_TABLE[] (see hw/audio/fmopl.[ch]) The specs google finds (http://www.symphoniae.com/Yamaha/YSC/YM3812.pdf) are rather sparse, possibly incomplete (looks like scanned fax with a scrambled page at the end) and not really helpful in identifying which of the register writes sets some illegal value. So, go tag the device as deprecated with a warning messge, to notify users and schedule it for removal according to our deprecation policy. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- hw/audio/adlib.c | 1 + qemu-deprecated.texi | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/hw/audio/adlib.c b/hw/audio/adlib.c index 97b876c..fb4a29c 100644 --- a/hw/audio/adlib.c +++ b/hw/audio/adlib.c @@ -311,6 +311,7 @@ static void adlib_class_initfn (ObjectClass *klass, voi= d *data) set_bit(DEVICE_CATEGORY_SOUND, dc->categories); dc->desc =3D ADLIB_DESC; dc->props =3D adlib_properties; + dc->deprecation_reason =3D "insecure, buffer overflow in opl2 emulatio= n"; } =20 static const TypeInfo adlib_info =3D { diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 11b870c..7951a4f 100644 --- a/qemu-deprecated.texi +++ b/qemu-deprecated.texi @@ -116,6 +116,10 @@ The @option{[hub_id name]} parameter tuple of the 'hos= tfwd_add' and The ``ivshmem'' device type is replaced by either the ``ivshmem-plain'' or ``ivshmem-doorbell`` device types. =20 +@subsection adlib (since 3.1) + +Has known buffer overflow. + @section System emulator machines =20 @subsection pc-0.10 and pc-0.11 (since 3.0) --=20 2.9.3