From nobody Tue Feb 10 11:24:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1539912096747396.46447464600556; Thu, 18 Oct 2018 18:21:36 -0700 (PDT) Received: from localhost ([::1]:45961 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDJTm-0000ZW-Gx for importer@patchew.org; Thu, 18 Oct 2018 21:21:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58926) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDJFc-0004eW-3N for qemu-devel@nongnu.org; Thu, 18 Oct 2018 21:06:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gDJFX-00031m-JK for qemu-devel@nongnu.org; Thu, 18 Oct 2018 21:06:51 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:57345) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gDJFX-0002kj-5R for qemu-devel@nongnu.org; Thu, 18 Oct 2018 21:06:47 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 5BEA022955; Thu, 18 Oct 2018 21:06:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 18 Oct 2018 21:06:29 -0400 Received: from localhost (flamenco.cs.columbia.edu [128.59.20.216]) by mail.messagingengine.com (Postfix) with ESMTPA id E057B102DE; Thu, 18 Oct 2018 21:06:28 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=braap.org; h= from:to:cc:subject:date:message-id:in-reply-to:references; s= mesmtp; bh=SV4gvrTs0LZPMCtVmqhozQEiEogs+Bx3TOMykcg/EbU=; b=cZh4V 5cLjyXIIuyXeku0RBa5jazHc4IxDBb0yf1tNNPoJZ8AWUuFjdp+XGx2BrxFcWgCC G1jtXN9DLjsa2aK/kjUvwV2d2uSRj1SLNPfCUeshGmq9Vw4lbnpdtxRigJ1bPVkL ev0ZmCTSHkBdDJM7eqTswBkaj1SIuhURYR5tLQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=SV4gvrTs0LZPMCtVmqhozQEiEogs+ Bx3TOMykcg/EbU=; b=mQ7qxmHiMLcsW/kiJTKeEG+N6WwGTMhgMEXp4G1GHTp4X 46n3rFymmRiw3+7XVtRaEeZfzoHaAio14gmutA94h4bfTsVxYn4rda25CL4YqfL8 oGOIigBYAYZe6d9mFGPBbT4OLzZ6Tg9IeCsJ6J1atAby8KSfqxRtaEVPHJJk6F1o WrIzYJVS5lYQ8x2uEtWps5sHwS/9PADybHPQX8YzlLPCtrG08Invoq5n0hkcT/3v td1rKp3ZQe63ZJj0v0v8zjuWCmpEFjOjTkBPwFKvMOhKuEMYifSUVUDDQOnAcmHV gUEjO+TeWE8mizBWqLmal0HZkJNS6u+X6En1NlujA== X-ME-Sender: X-ME-Proxy: From: "Emilio G. Cota" To: qemu-devel@nongnu.org Date: Thu, 18 Oct 2018 21:05:41 -0400 Message-Id: <20181019010625.25294-13-cota@braap.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181019010625.25294-1-cota@braap.org> References: <20181019010625.25294-1-cota@braap.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.111.4.29 Subject: [Qemu-devel] [RFC v3 12/56] i386: convert to cpu_halted X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Eduardo Habkost Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Cc: Eduardo Habkost Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson --- target/i386/cpu.h | 2 +- target/i386/cpu.c | 2 +- target/i386/hax-all.c | 4 ++-- target/i386/helper.c | 4 ++-- target/i386/hvf/hvf.c | 8 ++++---- target/i386/hvf/x86hvf.c | 4 ++-- target/i386/kvm.c | 10 +++++----- target/i386/misc_helper.c | 2 +- target/i386/whpx-all.c | 6 +++--- 9 files changed, 21 insertions(+), 21 deletions(-) diff --git a/target/i386/cpu.h b/target/i386/cpu.h index 730c06f80a..461459520a 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -1600,7 +1600,7 @@ static inline void cpu_x86_load_seg_cache_sipi(X86CPU= *cpu, sipi_vector << 12, env->segs[R_CS].limit, env->segs[R_CS].flags); - cs->halted =3D 0; + cpu_halted_set(cs, 0); } =20 int cpu_x86_get_descr_debug(CPUX86State *env, unsigned int selector, diff --git a/target/i386/cpu.c b/target/i386/cpu.c index c88876dfe3..b91d80af0a 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -4524,7 +4524,7 @@ static void x86_cpu_reset(CPUState *s) /* We hard-wire the BSP to the first CPU. */ apic_designate_bsp(cpu->apic_state, s->cpu_index =3D=3D 0); =20 - s->halted =3D !cpu_is_bsp(cpu); + cpu_halted_set(s, !cpu_is_bsp(cpu)); =20 if (kvm_enabled()) { kvm_arch_reset_vcpu(cpu); diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c index d2e512856b..f095c527e3 100644 --- a/target/i386/hax-all.c +++ b/target/i386/hax-all.c @@ -480,7 +480,7 @@ static int hax_vcpu_hax_exec(CPUArchState *env) return 0; } =20 - cpu->halted =3D 0; + cpu_halted_set(cpu, 0); =20 if (cpu->interrupt_request & CPU_INTERRUPT_POLL) { cpu->interrupt_request &=3D ~CPU_INTERRUPT_POLL; @@ -557,7 +557,7 @@ static int hax_vcpu_hax_exec(CPUArchState *env) !(cpu->interrupt_request & CPU_INTERRUPT_NMI)) { /* hlt instruction with interrupt disabled is shutdown */ env->eflags |=3D IF_MASK; - cpu->halted =3D 1; + cpu_halted_set(cpu, 1); cpu->exception_index =3D EXCP_HLT; ret =3D 1; } diff --git a/target/i386/helper.c b/target/i386/helper.c index e695f8ba7a..a75278f954 100644 --- a/target/i386/helper.c +++ b/target/i386/helper.c @@ -454,7 +454,7 @@ void x86_cpu_dump_state(CPUState *cs, FILE *f, fprintf_= function cpu_fprintf, (env->hflags >> HF_INHIBIT_IRQ_SHIFT) & 1, (env->a20_mask >> 20) & 1, (env->hflags >> HF_SMM_SHIFT) & 1, - cs->halted); + cpu_halted(cs)); } else #endif { @@ -481,7 +481,7 @@ void x86_cpu_dump_state(CPUState *cs, FILE *f, fprintf_= function cpu_fprintf, (env->hflags >> HF_INHIBIT_IRQ_SHIFT) & 1, (env->a20_mask >> 20) & 1, (env->hflags >> HF_SMM_SHIFT) & 1, - cs->halted); + cpu_halted(cs)); } =20 for(i =3D 0; i < 6; i++) { diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c index 9f52bc413a..fb3b2a26a1 100644 --- a/target/i386/hvf/hvf.c +++ b/target/i386/hvf/hvf.c @@ -500,7 +500,7 @@ void hvf_reset_vcpu(CPUState *cpu) { } =20 hv_vm_sync_tsc(0); - cpu->halted =3D 0; + cpu_halted_set(cpu, 0); hv_vcpu_invalidate_tlb(cpu->hvf_fd); hv_vcpu_flush(cpu->hvf_fd); } @@ -665,7 +665,7 @@ int hvf_vcpu_exec(CPUState *cpu) int ret =3D 0; uint64_t rip =3D 0; =20 - cpu->halted =3D 0; + cpu_halted_set(cpu, 0); =20 if (hvf_process_events(cpu)) { return EXCP_HLT; @@ -683,7 +683,7 @@ int hvf_vcpu_exec(CPUState *cpu) vmx_update_tpr(cpu); =20 qemu_mutex_unlock_iothread(); - if (!cpu_is_bsp(X86_CPU(cpu)) && cpu->halted) { + if (!cpu_is_bsp(X86_CPU(cpu)) && cpu_halted(cpu)) { qemu_mutex_lock_iothread(); return EXCP_HLT; } @@ -717,7 +717,7 @@ int hvf_vcpu_exec(CPUState *cpu) (EFLAGS(env) & IF_MASK)) && !(cpu->interrupt_request & CPU_INTERRUPT_NMI) && !(idtvec_info & VMCS_IDT_VEC_VALID)) { - cpu->halted =3D 1; + cpu_halted_set(cpu, 1); ret =3D EXCP_HLT; } ret =3D EXCP_INTERRUPT; diff --git a/target/i386/hvf/x86hvf.c b/target/i386/hvf/x86hvf.c index df8e946fbc..163bbed23f 100644 --- a/target/i386/hvf/x86hvf.c +++ b/target/i386/hvf/x86hvf.c @@ -446,7 +446,7 @@ int hvf_process_events(CPUState *cpu_state) if (((cpu_state->interrupt_request & CPU_INTERRUPT_HARD) && (EFLAGS(env) & IF_MASK)) || (cpu_state->interrupt_request & CPU_INTERRUPT_NMI)) { - cpu_state->halted =3D 0; + cpu_halted_set(cpu_state, 0); } if (cpu_state->interrupt_request & CPU_INTERRUPT_SIPI) { hvf_cpu_synchronize_state(cpu_state); @@ -458,5 +458,5 @@ int hvf_process_events(CPUState *cpu_state) apic_handle_tpr_access_report(cpu->apic_state, env->eip, env->tpr_access_type); } - return cpu_state->halted; + return cpu_halted(cpu); } diff --git a/target/i386/kvm.c b/target/i386/kvm.c index dc4047b02f..d593818cd5 100644 --- a/target/i386/kvm.c +++ b/target/i386/kvm.c @@ -2650,7 +2650,7 @@ static int kvm_get_mp_state(X86CPU *cpu) } env->mp_state =3D mp_state.mp_state; if (kvm_irqchip_in_kernel()) { - cs->halted =3D (mp_state.mp_state =3D=3D KVM_MP_STATE_HALTED); + cpu_halted_set(cs, mp_state.mp_state =3D=3D KVM_MP_STATE_HALTED); } return 0; } @@ -3136,7 +3136,7 @@ int kvm_arch_process_async_events(CPUState *cs) env->exception_injected =3D EXCP12_MCHK; env->has_error_code =3D 0; =20 - cs->halted =3D 0; + cpu_halted_set(cs, 0); if (kvm_irqchip_in_kernel() && env->mp_state =3D=3D KVM_MP_STATE_H= ALTED) { env->mp_state =3D KVM_MP_STATE_RUNNABLE; } @@ -3159,7 +3159,7 @@ int kvm_arch_process_async_events(CPUState *cs) if (((cs->interrupt_request & CPU_INTERRUPT_HARD) && (env->eflags & IF_MASK)) || (cs->interrupt_request & CPU_INTERRUPT_NMI)) { - cs->halted =3D 0; + cpu_halted_set(cs, 0); } if (cs->interrupt_request & CPU_INTERRUPT_SIPI) { kvm_cpu_synchronize_state(cs); @@ -3172,7 +3172,7 @@ int kvm_arch_process_async_events(CPUState *cs) env->tpr_access_type); } =20 - return cs->halted; + return cpu_halted(cs); } =20 static int kvm_handle_halt(X86CPU *cpu) @@ -3183,7 +3183,7 @@ static int kvm_handle_halt(X86CPU *cpu) if (!((cs->interrupt_request & CPU_INTERRUPT_HARD) && (env->eflags & IF_MASK)) && !(cs->interrupt_request & CPU_INTERRUPT_NMI)) { - cs->halted =3D 1; + cpu_halted_set(cs, 1); return EXCP_HLT; } =20 diff --git a/target/i386/misc_helper.c b/target/i386/misc_helper.c index 78f2020ef2..fcd6d833e8 100644 --- a/target/i386/misc_helper.c +++ b/target/i386/misc_helper.c @@ -554,7 +554,7 @@ static void do_hlt(X86CPU *cpu) CPUX86State *env =3D &cpu->env; =20 env->hflags &=3D ~HF_INHIBIT_IRQ_MASK; /* needed if sti is just before= */ - cs->halted =3D 1; + cpu_halted_set(cs, 1); cs->exception_index =3D EXCP_HLT; cpu_loop_exit(cs); } diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c index 57e53e1f1f..b9c79ccd99 100644 --- a/target/i386/whpx-all.c +++ b/target/i386/whpx-all.c @@ -697,7 +697,7 @@ static int whpx_handle_halt(CPUState *cpu) (env->eflags & IF_MASK)) && !(cpu->interrupt_request & CPU_INTERRUPT_NMI)) { cpu->exception_index =3D EXCP_HLT; - cpu->halted =3D true; + cpu_halted_set(cpu, true); ret =3D 1; } qemu_mutex_unlock_iothread(); @@ -857,7 +857,7 @@ static void whpx_vcpu_process_async_events(CPUState *cp= u) if (((cpu->interrupt_request & CPU_INTERRUPT_HARD) && (env->eflags & IF_MASK)) || (cpu->interrupt_request & CPU_INTERRUPT_NMI)) { - cpu->halted =3D false; + cpu_halted_set(cpu, false); } =20 if (cpu->interrupt_request & CPU_INTERRUPT_SIPI) { @@ -887,7 +887,7 @@ static int whpx_vcpu_run(CPUState *cpu) int ret; =20 whpx_vcpu_process_async_events(cpu); - if (cpu->halted) { + if (cpu_halted(cpu)) { cpu->exception_index =3D EXCP_HLT; atomic_set(&cpu->exit_request, false); return 0; --=20 2.17.1