From nobody Thu Nov 6 06:17:51 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1539789570935779.435246442716; Wed, 17 Oct 2018 08:19:30 -0700 (PDT) Received: from localhost ([::1]:37273 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gCnbT-0004aM-Ig for importer@patchew.org; Wed, 17 Oct 2018 11:19:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gCnaH-0003vg-5B for qemu-devel@nongnu.org; Wed, 17 Oct 2018 11:18:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gCnaC-0007CN-7Y for qemu-devel@nongnu.org; Wed, 17 Oct 2018 11:18:05 -0400 Received: from fanzine.igalia.com ([91.117.99.155]:54125) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gCnaB-00078t-OI for qemu-devel@nongnu.org; Wed, 17 Oct 2018 11:18:00 -0400 Received: from [194.100.51.2] (helo=perseus.local) by fanzine.igalia.com with esmtpsa (Cipher TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim) id 1gCna9-0001Fb-Pn; Wed, 17 Oct 2018 17:17:57 +0200 Received: from berto by perseus.local with local (Exim 4.89) (envelope-from ) id 1gCnZu-0005IC-2b; Wed, 17 Oct 2018 18:17:42 +0300 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Message-Id:Date:Subject:Cc:To:From; bh=Jj6sn+v9WcVa5keLAWhz3GcAWPz++/QHZab4XYcwBiA=; b=Wc2PzghJ9PIgmQh2/a6xmDwGPC+IzC8Z3C05nK6qS4ulB+QOrGj5aGNKghmmqs0c9KOmeMRFeJWPu6KP46aOc+Mp+zhut0O7UAiMEXjeKSdMvlad4ivP6C9CcfTm5yzyRH6tGbbmWcFKbL9Pn/bRyAuDWQfaCGjUUEDPFjrI5fK++4efpVZNuvbCF7uIVwUOAlvLAg7Zd9O6pWkX6+WZ4hJfM6SaK3V7OPvo/jaeZpXSsNV/7aHB+B65NZs4oIftiyMK9kBL5TZ0YmbCgZBoiTgKK4g3A8kQWyO2W9CCmwjCTyzqzdwMsEgdjV5p93+VHkqnnKJEnwM9FjsecMqLxA==; From: Alberto Garcia To: qemu-devel@nongnu.org Date: Wed, 17 Oct 2018 18:17:38 +0300 Message-Id: <20181017151738.20299-1-berto@igalia.com> X-Mailer: git-send-email 2.11.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 91.117.99.155 Subject: [Qemu-devel] [PATCH] scripts: Remove check-qerror.sh X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alberto Garcia , Markus Armbruster Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" qerror.h contains leftovers from the now-defunct QError API. There's only a handful of string macros left, and no one is supposed to add anything else. The check-qerror.sh script was used to make sure that all definitions on the qerror.c and qerror.h files were sorted alphabetically. The former was removed three years ago, and the latter is now in a different location, so the script doesn't even work (as a matter of fact the alphabetical order was broken last time someone added a macro -also in 2015- and no one seemed to notice). There's no point in fixing this script so let's just remove it. The rogue macro is also moved to its correct location. Signed-off-by: Alberto Garcia Reviewed-by: Markus Armbruster --- include/qapi/qmp/qerror.h | 6 +++--- scripts/check-qerror.sh | 22 ---------------------- 2 files changed, 3 insertions(+), 25 deletions(-) delete mode 100755 scripts/check-qerror.sh diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h index 145571f618..7c76e24aa7 100644 --- a/include/qapi/qmp/qerror.h +++ b/include/qapi/qmp/qerror.h @@ -79,6 +79,9 @@ #define QERR_QGA_COMMAND_FAILED \ "Guest agent command failed, error was '%s'" =20 +#define QERR_REPLAY_NOT_SUPPORTED \ + "Record/replay feature is not supported for '%s'" + #define QERR_SET_PASSWD_FAILED \ "Could not set password" =20 @@ -88,7 +91,4 @@ #define QERR_UNSUPPORTED \ "this feature or command is not currently supported" =20 -#define QERR_REPLAY_NOT_SUPPORTED \ - "Record/replay feature is not supported for '%s'" - #endif /* QERROR_H */ diff --git a/scripts/check-qerror.sh b/scripts/check-qerror.sh deleted file mode 100755 index af7fbd5249..0000000000 --- a/scripts/check-qerror.sh +++ /dev/null @@ -1,22 +0,0 @@ -#!/bin/sh -# This script verifies that qerror definitions and table entries are -# alphabetically ordered. - -check_order() { - errmsg=3D$1 - shift - - # sort -C verifies order but does not print a message. sort -c does pri= nt a - # message. These options are both in POSIX. - if ! "$@" | sort -C; then - echo "$errmsg" - "$@" | sort -c - exit 1 - fi - return 0 -} - -check_order 'Definitions in qerror.h must be in alphabetical order:' \ - grep '^#define QERR_' qerror.h -check_order 'Entries in qerror.c:qerror_table must be in alphabetical orde= r:' \ - sed -n '/^static.*qerror_table\[\]/,/^};/s/QERR_/&/gp' qerror.c --=20 2.11.0