From nobody Thu Nov 6 08:40:03 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1539769592880149.96363915893073; Wed, 17 Oct 2018 02:46:32 -0700 (PDT) Received: from localhost ([::1]:34979 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gCiP9-0003IH-7g for importer@patchew.org; Wed, 17 Oct 2018 05:46:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47301) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gCiNW-0002Kn-5x for qemu-devel@nongnu.org; Wed, 17 Oct 2018 05:44:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gCiNR-00051D-Io for qemu-devel@nongnu.org; Wed, 17 Oct 2018 05:44:34 -0400 Received: from cmccmta3.chinamobile.com ([221.176.66.81]:17371) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gCiNO-0004s0-KO for qemu-devel@nongnu.org; Wed, 17 Oct 2018 05:44:28 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.3]) by rmmx-syy-dmz-app10-12010 (RichMail) with SMTP id 2eea5bc7046f88e-8db56; Wed, 17 Oct 2018 17:44:15 +0800 (CST) Received: from localhost.localdomain (unknown[112.25.154.149]) by rmsmtp-syy-appsvr02-12002 (RichMail) with SMTP id 2ee25bc70468719-372aa; Wed, 17 Oct 2018 17:44:15 +0800 (CST) X-RM-TRANSID: 2eea5bc7046f88e-8db56 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 X-RM-TRANSID: 2ee25bc70468719-372aa From: Mao Zhongyi To: qemu-devel@nongnu.org Date: Wed, 17 Oct 2018 17:44:05 +0800 Message-Id: <20181017094406.4844-3-maozhongyi@cmss.chinamobile.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181017094406.4844-1-maozhongyi@cmss.chinamobile.com> References: <20181017094406.4844-1-maozhongyi@cmss.chinamobile.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 221.176.66.81 Subject: [Qemu-devel] [PATCH 2/3] debian-bootstrap.pre: Modern shell scripting (use $() instead of ``) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: famz@redhat.com, alex.bennee@linaro.org, Mao Zhongyi , philmd@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Various shell files contain a mix between obsolete `` and modern $(); It would be nice to convert to using $() everywhere. Cc: alex.bennee@linaro.org Cc: famz@redhat.com Cc: philmd@redhat.com Signed-off-by: Mao Zhongyi Reviewed-by: Alex Benn=C3=A9e Tested-by: Alex Benn=C3=A9e --- tests/docker/dockerfiles/debian-bootstrap.pre | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/docker/dockerfiles/debian-bootstrap.pre b/tests/docker/d= ockerfiles/debian-bootstrap.pre index 3b0ef95374..c164778c30 100755 --- a/tests/docker/dockerfiles/debian-bootstrap.pre +++ b/tests/docker/dockerfiles/debian-bootstrap.pre @@ -2,7 +2,7 @@ # # Simple wrapper for debootstrap, run in the docker build context # -FAKEROOT=3D`which fakeroot 2> /dev/null` +FAKEROOT=3D$(which fakeroot 2> /dev/null) # debootstrap < 1.0.67 generates empty sources.list, see Debian#732255 MIN_DEBOOTSTRAP_VERSION=3D1.0.67 =20 @@ -52,7 +52,7 @@ fi =20 if [ -z $DEBOOTSTRAP_DIR ]; then NEED_DEBOOTSTRAP=3Dfalse - DEBOOTSTRAP=3D`which debootstrap 2> /dev/null` + DEBOOTSTRAP=3D$(which debootstrap 2> /dev/null) if [ -z $DEBOOTSTRAP ]; then echo "No debootstrap installed, attempting to install from SCM" NEED_DEBOOTSTRAP=3Dtrue --=20 2.17.1