From nobody Thu Nov 6 08:24:10 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1539741390932998.8547441034991; Tue, 16 Oct 2018 18:56:30 -0700 (PDT) Received: from localhost ([::1]:33381 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gCb4S-0003A7-4F for importer@patchew.org; Tue, 16 Oct 2018 21:56:24 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gCb3B-0002W6-3p for qemu-devel@nongnu.org; Tue, 16 Oct 2018 21:55:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gCb37-0006z3-JL for qemu-devel@nongnu.org; Tue, 16 Oct 2018 21:55:04 -0400 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]:44224) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gCb37-0006yW-DQ for qemu-devel@nongnu.org; Tue, 16 Oct 2018 21:55:01 -0400 Received: by mail-pg1-x541.google.com with SMTP id g2-v6so11710050pgu.11 for ; Tue, 16 Oct 2018 18:55:01 -0700 (PDT) Received: from cloudburst.twiddle.net (174-21-9-133.tukw.qwest.net. [174.21.9.133]) by smtp.gmail.com with ESMTPSA id o133-v6sm24988124pfg.86.2018.10.16.18.54.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Oct 2018 18:54:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7LDAkXYqm0E1INzhyCfPvhMzExqgurjucKqSbAhcSOg=; b=OUVYb2xJEQxeUL7/0wbuFc5C0dAMjJg2SPvJgMBGzV3f98HZUiAeNBE6SD59Kdap04 MOreS8guKKeY18NMFc5qPj7tr19NtyW23fIV4uNQkvJ+GEvk4OLigSyYcJacsMx6eN+H 55T+YsBza/MsYZlu8aBROmH1rv7zl8rhDUYyY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=7LDAkXYqm0E1INzhyCfPvhMzExqgurjucKqSbAhcSOg=; b=G1rRhroGEcP1QDrtvyZPnDQMVqAXLLor2TY2GsC8iAVX/ytsXEeVqBPJJu1+qrJvlU Q+Go1cAR3m9H5P1DhjXuWlbGnnlMatKC6FNRzkjRp698+i4dz0fQTUycC50MwiFUdVmX RVqQSkgNBFBVClAaHcGvCesNpcSz8cHYNp4ZivQ8aikUF2Frx2jRchxbKL5EY0WU4pNJ 6XLEPkRZJ6CGC2YGts2ztFr4tIjXsQxU8YU7qgB0Cr7uAR/vyluLXRGFQFhxZoobQYbR ep5wUPUQIqfEnrTdjsYQ4pqwOJ5v9k/3LL9BrSrVi2GXdeLu1FEpSZFKLwOJH6YS1a5J 2u/g== X-Gm-Message-State: ABuFfoi2mjudvih7or+nGBp9H4zbFF2LP/UzljAhYCPclAD/mxCio+iJ IfqZ32rLj3gT/6y2JgBioDgSzb5bqKk= X-Google-Smtp-Source: ACcGV63V2/Z+3F18u3YF3EXO6m6v+cUSZhNHHIIAwk6d2nmVqtGOANwUYfbcbIGsoL/4nX98LAmdmQ== X-Received: by 2002:a65:4301:: with SMTP id j1-v6mr6445832pgq.279.1539741300064; Tue, 16 Oct 2018 18:55:00 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 16 Oct 2018 18:54:54 -0700 Message-Id: <20181017015456.3293-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181017015456.3293-1-richard.henderson@linaro.org> References: <20181017015456.3293-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::541 Subject: [Qemu-devel] [PATCH 1/3] tests/tcg/multiarch/linux-test: Fix error check for shmat X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: laurent@vivier.eu Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDMRC_1 RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The error indicator for this syscall is -1, not 0. Signed-off-by: Richard Henderson --- tests/tcg/multiarch/linux-test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/tcg/multiarch/linux-test.c b/tests/tcg/multiarch/linux-t= est.c index e80eccc0ce..6d2c02c5c0 100644 --- a/tests/tcg/multiarch/linux-test.c +++ b/tests/tcg/multiarch/linux-test.c @@ -503,8 +503,9 @@ static void test_shm(void) =20 shmid =3D chk_error(shmget(IPC_PRIVATE, SHM_SIZE, IPC_CREAT | 0777)); ptr =3D shmat(shmid, NULL, 0); - if (!ptr) + if (ptr =3D=3D (void *)-1) { error("shmat"); + } =20 memset(ptr, 0, SHM_SIZE); =20 --=20 2.17.2