From nobody Tue Apr 8 23:32:36 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 15397145756011013.6198948988689; Tue, 16 Oct 2018 11:29:35 -0700 (PDT) Received: from localhost ([::1]:59615 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gCU62-0007AR-5h for importer@patchew.org; Tue, 16 Oct 2018 14:29:34 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59694) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gCTTP-00046S-5Z for qemu-devel@nongnu.org; Tue, 16 Oct 2018 13:49:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gCTTL-00010n-A8 for qemu-devel@nongnu.org; Tue, 16 Oct 2018 13:49:38 -0400 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]:39086) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gCTTL-0000z6-2T for qemu-devel@nongnu.org; Tue, 16 Oct 2018 13:49:35 -0400 Received: by mail-pg1-x530.google.com with SMTP id r9-v6so11204282pgv.6 for ; Tue, 16 Oct 2018 10:49:35 -0700 (PDT) Received: from cloudburst.twiddle.net (174-21-9-133.tukw.qwest.net. [174.21.9.133]) by smtp.gmail.com with ESMTPSA id 6-v6sm17441210pgl.6.2018.10.16.10.49.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Oct 2018 10:49:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DB1b/fVktprVB9+vgwXapy40A76LQaCwLNLh795KUCE=; b=c2a3u27c4btEwl5p1FlwTXBGuxeT0HV8FjfvoAUl80LdoTY1vPtysvAzdE27CXeOjv MmuqMXCK64tLnnxN5tIjOZAFo2pTQorHZjlcClcbde6KsL+o12fewH1TJh+3fLgNDY/n zkRnM7l6r9LD7Git6K/UNPHTCtmV7SaahJIBM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DB1b/fVktprVB9+vgwXapy40A76LQaCwLNLh795KUCE=; b=kR1XSsi5VDrOHLhemtlWvBA5UBxGm0Myyn1fqeVBx15eyL27H7CL3MHeoIUsEGScI6 NgsrkDnQDl6eO5oSbwvyXe/jtPMBkuRxMyu4NQXEJRNnAZIb9vE6bQGU+Qg6zXgY2bE4 2xXDFzLK7lKtp1YpIazn4afEi/ZT0M0Qd131TznKdanr/ng7VejNetTKM1wfrBHm5XJx mdYCrQbWUzcXVJy7vJYXWLvXJllKoUSXd/yTi7+2dtP4gnmpRMJzTCf3RDBhp2roDMIr aILTzYHdXPywwNgnMNv/lyFfVVqYSS+0GMNDWl2VcJfA686q/hJzbHC92/7CnjTv4clG VqLw== X-Gm-Message-State: ABuFfojpXKKnyIux6BMHz8Cs9O0CGcRbrTzf3Fiq5U+g0Z1QiRqI3eNc 9jlVnZbKwh7n02PyJiUZ9b+jORgLtuU= X-Google-Smtp-Source: ACcGV60ktBTcy4ihQ9/HpVSVGFhwz1kL6N/IJAJ4coBk5CmUZk4rFZwUuyGmAf0n59yFaA4LsO3j8Q== X-Received: by 2002:a63:1148:: with SMTP id 8-v6mr21459996pgr.172.1539712173623; Tue, 16 Oct 2018 10:49:33 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 16 Oct 2018 10:49:03 -0700 Message-Id: <20181016174911.9052-14-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181016174911.9052-1-richard.henderson@linaro.org> References: <20181016174911.9052-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::530 Subject: [Qemu-devel] [PULL 13/21] target/i386: Convert to HAVE_CMPXCHG128 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDMRC_1 RDKM_2 RSF_0 Z_629925259 SPT_0 Reviewed-by: Emilio G. Cota Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Richard Henderson --- target/i386/mem_helper.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/target/i386/mem_helper.c b/target/i386/mem_helper.c index 30c26b9d9c..6cc53bcb40 100644 --- a/target/i386/mem_helper.c +++ b/target/i386/mem_helper.c @@ -23,6 +23,7 @@ #include "exec/exec-all.h" #include "exec/cpu_ldst.h" #include "qemu/int128.h" +#include "qemu/atomic128.h" #include "tcg.h" =20 void helper_cmpxchg8b_unlocked(CPUX86State *env, target_ulong a0) @@ -137,10 +138,7 @@ void helper_cmpxchg16b(CPUX86State *env, target_ulong = a0) =20 if ((a0 & 0xf) !=3D 0) { raise_exception_ra(env, EXCP0D_GPF, ra); - } else { -#ifndef CONFIG_ATOMIC128 - cpu_loop_exit_atomic(ENV_GET_CPU(env), ra); -#else + } else if (HAVE_CMPXCHG128) { int eflags =3D cpu_cc_compute_all(env, CC_OP); =20 Int128 cmpv =3D int128_make128(env->regs[R_EAX], env->regs[R_EDX]); @@ -159,7 +157,8 @@ void helper_cmpxchg16b(CPUX86State *env, target_ulong a= 0) eflags &=3D ~CC_Z; } CC_SRC =3D eflags; -#endif + } else { + cpu_loop_exit_atomic(ENV_GET_CPU(env), ra); } } #endif --=20 2.17.2