From nobody Thu Nov 6 08:25:34 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1539712773819814.5323361677798; Tue, 16 Oct 2018 10:59:33 -0700 (PDT) Received: from localhost ([::1]:59432 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gCTcu-0004Ia-GM for importer@patchew.org; Tue, 16 Oct 2018 13:59:28 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56833) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gCTMB-000677-6V for qemu-devel@nongnu.org; Tue, 16 Oct 2018 13:42:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gCTM8-0000DR-Uh for qemu-devel@nongnu.org; Tue, 16 Oct 2018 13:42:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33610) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gCTM8-0000BC-H6 for qemu-devel@nongnu.org; Tue, 16 Oct 2018 13:42:08 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A2818CD162 for ; Tue, 16 Oct 2018 17:42:07 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-50.ams2.redhat.com [10.36.116.50]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 715B96249E for ; Tue, 16 Oct 2018 17:42:07 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 31D7D1162B62; Tue, 16 Oct 2018 19:41:59 +0200 (CEST) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Tue, 16 Oct 2018 19:41:57 +0200 Message-Id: <20181016174158.15229-38-armbru@redhat.com> In-Reply-To: <20181016174158.15229-1-armbru@redhat.com> References: <20181016174158.15229-1-armbru@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 16 Oct 2018 17:42:07 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v3 37/38] raw: Convert a warning to warn_report() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RDMRC_1 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Markus Armbruster --- block/raw-format.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/block/raw-format.c b/block/raw-format.c index 6f6dc99b2c..d65fd0ffce 100644 --- a/block/raw-format.c +++ b/block/raw-format.c @@ -29,6 +29,7 @@ #include "qemu/osdep.h" #include "block/block_int.h" #include "qapi/error.h" +#include "qemu/error-report.h" #include "qemu/option.h" =20 typedef struct BDRVRawState { @@ -436,14 +437,14 @@ static int raw_open(BlockDriverState *bs, QDict *opti= ons, int flags, bs->file->bs->supported_zero_flags); =20 if (bs->probed && !bdrv_is_read_only(bs)) { - fprintf(stderr, - "WARNING: Image format was not specified for '%s' and prob= ing " - "guessed raw.\n" - " Automatically detecting the format is dangerous = for " - "raw images, write operations on block 0 will be restricte= d.\n" - " Specify the 'raw' format explicitly to remove th= e " - "restrictions.\n", - bs->file->bs->filename); + warn_report("Image format was not specified for '%s' and probing " + "guessed raw", + bs->file->bs->filename); + error_printf("Automatically detecting the format is dangerous for " + "raw images, write\n" + "operations on block 0 will be restricted.\n" + "Specify the 'raw' format explicitly to remove the " + "restrictions.\n"); } =20 ret =3D raw_read_options(options, bs, s, errp); --=20 2.17.1