From nobody Thu Nov 6 06:16:06 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1539624675769617.9033862582199; Mon, 15 Oct 2018 10:31:15 -0700 (PDT) Received: from localhost ([::1]:53400 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gC6i1-0006u8-IX for importer@patchew.org; Mon, 15 Oct 2018 13:31:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48106) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gC6fi-0005Vz-0J for qemu-devel@nongnu.org; Mon, 15 Oct 2018 13:28:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gC6fh-0005EF-6H for qemu-devel@nongnu.org; Mon, 15 Oct 2018 13:28:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51836) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gC6fX-00056I-3e; Mon, 15 Oct 2018 13:28:39 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7AA6C3097075; Mon, 15 Oct 2018 17:28:37 +0000 (UTC) Received: from localhost (ovpn-204-236.brq.redhat.com [10.40.204.236]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 21BDD62472; Mon, 15 Oct 2018 17:28:34 +0000 (UTC) From: Max Reitz To: qemu-block@nongnu.org Date: Mon, 15 Oct 2018 19:28:15 +0200 Message-Id: <20181015172817.19796-4-mreitz@redhat.com> In-Reply-To: <20181015172817.19796-1-mreitz@redhat.com> References: <20181015172817.19796-1-mreitz@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Mon, 15 Oct 2018 17:28:37 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 3/5] qdev-monitor: Make device options help nicer X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , qemu-devel@nongnu.org, Markus Armbruster , Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RDMRC_1 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Just like in qemu_opts_print_help(), print the device name as a caption instead of on every single line, indent all options, and replace the '=3D' by ': '. Signed-off-by: Max Reitz --- qdev-monitor.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/qdev-monitor.c b/qdev-monitor.c index 802c18a74e..481bb4bbf9 100644 --- a/qdev-monitor.c +++ b/qdev-monitor.c @@ -285,8 +285,13 @@ int qdev_device_help(QemuOpts *opts) goto error; } =20 + if (prop_list) { + out_printf("%s options:\n", driver); + } else { + out_printf("There are no options for %s.\n", driver); + } for (prop =3D prop_list; prop; prop =3D prop->next) { - out_printf("%s.%s=3D%s", driver, prop->value->name, prop->value->t= ype); + out_printf(" %s: %s", prop->value->name, prop->value->type); if (prop->value->has_description) { out_printf(" (%s)\n", prop->value->description); } else { --=20 2.17.1