From nobody Sun Oct 5 19:23:34 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1539269376352298.72663619324203; Thu, 11 Oct 2018 07:49:36 -0700 (PDT) Received: from localhost ([::1]:34931 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gAcHF-0005yR-V3 for importer@patchew.org; Thu, 11 Oct 2018 10:49:25 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51159) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gAcFs-0005Ud-8z for qemu-devel@nongnu.org; Thu, 11 Oct 2018 10:48:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gAcFm-0001u0-PP for qemu-devel@nongnu.org; Thu, 11 Oct 2018 10:48:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40510) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gAcFm-0001sy-HK for qemu-devel@nongnu.org; Thu, 11 Oct 2018 10:47:54 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AFE1430820C0 for ; Thu, 11 Oct 2018 14:47:53 +0000 (UTC) Received: from red.redhat.com (ovpn-121-240.rdu2.redhat.com [10.10.121.240]) by smtp.corp.redhat.com (Postfix) with ESMTP id F2F5A8B95F; Thu, 11 Oct 2018 14:47:52 +0000 (UTC) From: Eric Blake To: qemu-devel@nongnu.org Date: Thu, 11 Oct 2018 09:47:51 -0500 Message-Id: <20181011144751.2724218-1-eblake@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Thu, 11 Oct 2018 14:47:53 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] tests: Prevent more accidental test disabling X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: philmd@redhat.com, armbru@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RDMRC_1 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" GNU make is perfectly happy to use 'check-FOO-y +=3D bar' to initialize check-FOO-y. (GNU Automake strictly insists that you cannot use +=3D until after an initial =3D per variable, but thankfully we aren't using automake). As we have had more than one instance where copy-and-paste of 'check-FOO-y =3D bar' from a first test under category FOO into an additional test, which ends up disabling the first (see commits 992159c7 and 4429532b), it's better to just always use the form that survives copy-and-paste, even for categories that don't currently add more than one test. Done with s/^\(check-[a-z]*-y \)=3D/\1+=3D/g Signed-off-by: Eric Blake Acked-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tests/Makefile.include | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 8264af64a86..fa6d30e26f7 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -38,7 +38,7 @@ $(SRC_PATH)/scripts/qapi-gen.py SYSEMU_TARGET_LIST :=3D $(subst -softmmu.mak,,$(notdir \ $(wildcard $(SRC_PATH)/default-configs/*-softmmu.mak))) -check-unit-y =3D tests/check-qdict$(EXESUF) +check-unit-y +=3D tests/check-qdict$(EXESUF) gcov-files-check-qdict-y =3D qobject/qdict.c check-unit-y +=3D tests/check-block-qdict$(EXESUF) gcov-files-check-block-qdict-y =3D qobject/block-qdict.c @@ -181,7 +181,7 @@ check-block-$(CONFIG_POSIX) +=3D tests/qemu-iotests-qui= ck.sh # All QTests for now are POSIX-only, but the dependencies are # really in libqtest, not in the testcases themselves. -check-qtest-generic-y =3D tests/qmp-test$(EXESUF) +check-qtest-generic-y +=3D tests/qmp-test$(EXESUF) gcov-files-generic-y =3D monitor.c qapi/qmp-dispatch.c check-qtest-generic-y +=3D tests/qmp-cmd-test$(EXESUF) @@ -324,13 +324,13 @@ check-qtest-x86_64-$(CONFIG_SDHCI) +=3D tests/sdhci-t= est$(EXESUF) gcov-files-i386-y +=3D i386-softmmu/hw/timer/mc146818rtc.c gcov-files-x86_64-y =3D $(subst i386-softmmu/,x86_64-softmmu/,$(gcov-files= -i386-y)) -check-qtest-alpha-y =3D tests/boot-serial-test$(EXESUF) +check-qtest-alpha-y +=3D tests/boot-serial-test$(EXESUF) -check-qtest-hppa-y =3D tests/boot-serial-test$(EXESUF) +check-qtest-hppa-y +=3D tests/boot-serial-test$(EXESUF) check-qtest-m68k-y =3D tests/boot-serial-test$(EXESUF) -check-qtest-microblaze-y =3D tests/boot-serial-test$(EXESUF) +check-qtest-microblaze-y +=3D tests/boot-serial-test$(EXESUF) check-qtest-mips-$(CONFIG_ISA_TESTDEV) =3D tests/endianness-test$(EXESUF) @@ -338,7 +338,7 @@ check-qtest-mips64-$(CONFIG_ISA_TESTDEV) =3D tests/endi= anness-test$(EXESUF) check-qtest-mips64el-$(CONFIG_ISA_TESTDEV) =3D tests/endianness-test$(EXES= UF) -check-qtest-moxie-y =3D tests/boot-serial-test$(EXESUF) +check-qtest-moxie-y +=3D tests/boot-serial-test$(EXESUF) check-qtest-ppc-$(CONFIG_ISA_TESTDEV) =3D tests/endianness-test$(EXESUF) check-qtest-ppc-y +=3D tests/boot-order-test$(EXESUF) @@ -348,7 +348,7 @@ check-qtest-ppc-y +=3D tests/boot-serial-test$(EXESUF) check-qtest-ppc-y +=3D tests/m48t59-test$(EXESUF) gcov-files-ppc-y +=3D hw/timer/m48t59.c -check-qtest-ppc64-y =3D $(check-qtest-ppc-y) +check-qtest-ppc64-y +=3D $(check-qtest-ppc-y) gcov-files-ppc64-y =3D $(subst ppc-softmmu/,ppc64-softmmu/,$(gcov-files-pp= c-y)) check-qtest-ppc64-y +=3D tests/spapr-phb-test$(EXESUF) gcov-files-ppc64-y +=3D ppc64-softmmu/hw/ppc/spapr_pci.c @@ -377,7 +377,7 @@ check-qtest-sh4-$(CONFIG_ISA_TESTDEV) =3D tests/endiann= ess-test$(EXESUF) check-qtest-sh4eb-$(CONFIG_ISA_TESTDEV) =3D tests/endianness-test$(EXESUF) -check-qtest-sparc-y =3D tests/prom-env-test$(EXESUF) +check-qtest-sparc-y +=3D tests/prom-env-test$(EXESUF) check-qtest-sparc-y +=3D tests/m48t59-test$(EXESUF) gcov-files-sparc-y =3D hw/timer/m48t59.c check-qtest-sparc-y +=3D tests/boot-serial-test$(EXESUF) @@ -386,7 +386,7 @@ check-qtest-sparc64-$(CONFIG_ISA_TESTDEV) =3D tests/end= ianness-test$(EXESUF) check-qtest-sparc64-y +=3D tests/prom-env-test$(EXESUF) check-qtest-sparc64-y +=3D tests/boot-serial-test$(EXESUF) -check-qtest-arm-y =3D tests/tmp105-test$(EXESUF) +check-qtest-arm-y +=3D tests/tmp105-test$(EXESUF) check-qtest-arm-y +=3D tests/pca9552-test$(EXESUF) check-qtest-arm-y +=3D tests/ds1338-test$(EXESUF) check-qtest-arm-y +=3D tests/m25p80-test$(EXESUF) @@ -403,9 +403,9 @@ check-qtest-aarch64-y =3D tests/numa-test$(EXESUF) check-qtest-aarch64-$(CONFIG_SDHCI) +=3D tests/sdhci-test$(EXESUF) check-qtest-aarch64-y +=3D tests/boot-serial-test$(EXESUF) -check-qtest-microblazeel-y =3D $(check-qtest-microblaze-y) +check-qtest-microblazeel-y +=3D $(check-qtest-microblaze-y) -check-qtest-xtensaeb-y =3D $(check-qtest-xtensa-y) +check-qtest-xtensaeb-y +=3D $(check-qtest-xtensa-y) check-qtest-s390x-y =3D tests/boot-serial-test$(EXESUF) check-qtest-s390x-$(CONFIG_SLIRP) +=3D tests/pxe-test$(EXESUF) --=20 2.17.1