From nobody Fri Nov 7 12:35:13 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1539211498075466.43511605567596; Wed, 10 Oct 2018 15:44:58 -0700 (PDT) Received: from localhost ([::1]:59468 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gANDk-0007nS-KD for importer@patchew.org; Wed, 10 Oct 2018 18:44:48 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38838) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gAN6R-0002g1-2r for qemu-devel@nongnu.org; Wed, 10 Oct 2018 18:37:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gAN6N-0000RK-Vk for qemu-devel@nongnu.org; Wed, 10 Oct 2018 18:37:12 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]:50248) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gAN6N-0000Or-Ms for qemu-devel@nongnu.org; Wed, 10 Oct 2018 18:37:11 -0400 Received: by mail-wm1-x32a.google.com with SMTP id i8-v6so7017958wmg.0 for ; Wed, 10 Oct 2018 15:37:11 -0700 (PDT) Received: from x1.local (26.red-83-32-208.dynamicip.rima-tde.net. [83.32.208.26]) by smtp.gmail.com with ESMTPSA id q77-v6sm10344886wmd.33.2018.10.10.15.37.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Oct 2018 15:37:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9UGvxbUbOUkUs2h21ghA50gksaYfYt0H93Hwt6BIzRw=; b=HH6XFs47KWxzSGy26l5F+zcRAJt7pwgyW30vQwbnIEyUNpjKAobaW7gmro/7wjL/wR wTnF92aaEnWGSKmieSQuhH4tcqCnBws+xxC9GoU1hJgQ5Orv7Bb89pUE3ww4fXAryIcu VuYvsgn2WJ4oGw1afKUCMaXcRunJDxdtFcZqVpqF/WoKBw8tmQC7tCQ3kqibZMIs3TxO kc/ybVSaKbuOrhsgISpSrPAGGtRSaf5+qjrGkI/K3/IFNJ7OjuKpJG7MeqqmfQVtLEat 5Sems45glw43xD6Xi/9vcuAMi41ThbCpovdrxFeumdYFUlc/hJ6RdxrE+uQfboDin1aJ gEyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=9UGvxbUbOUkUs2h21ghA50gksaYfYt0H93Hwt6BIzRw=; b=tG/IW5mF4MUQVFAabjWGPgyD3LNxgfUHmrPhweY8NpGQmaeAxR0/9Bciwwq0bhTbWE RmqyKY2yWRSWgaSo3gMJyvboQAAmP2A7kO6OUyZ9YMMgnU74/aYgF8NOax37kTZpqdJw INqJdQoJs2FeJyo85f/wyRKDy6tURvj3UuHe6c4zxYL2ZHX7N+2TRD1uic/anpnQLuoV hyU6klySpxR2VIfo7rLirtow1Vb7UhIY4jpjr6lkpXjY1A1Fo1VHY3pJhKWF9fKM0AR2 Prw734hajqRsdKz/nkY88Zbiep9pR4P3Vv8qykBwLX8/NQ5RVKVV6RxTYlNI3h+tKzMj +Omw== X-Gm-Message-State: ABuFfojyRudrZCC+G97zHy8Xc/nJeaiUlPMihhhgG3qTtH1W+GQT/ckK 9pKe+BKVm32K0JFjEikaAUw= X-Google-Smtp-Source: ACcGV61IaXszHIwVKStBnGVmDj88apEmkudj1w4yi03eQC6Lkbz5U3a9Ny/YJtsUHTnb021kKgaD7w== X-Received: by 2002:a1c:6655:: with SMTP id a82-v6mr2505530wmc.10.1539211030741; Wed, 10 Oct 2018 15:37:10 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Laurent Vivier Date: Thu, 11 Oct 2018 00:36:54 +0200 Message-Id: <20181010223656.31632-9-f4bug@amsat.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181010223656.31632-1-f4bug@amsat.org> References: <20181010223656.31632-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32a Subject: [Qemu-devel] [PATCH v5 08/10] linux-user/strace: Let print_sockaddr() have a 'last' argument X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Guido=20G=C3=BCnther?= , Riku Voipio , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 If the format is not the syscall last argument, a comma is append. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Laurent Vivier --- linux-user/strace.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index 5435d01569..14ec5f9f23 100644 --- a/linux-user/strace.c +++ b/linux-user/strace.c @@ -67,7 +67,7 @@ UNUSED static void print_timeval(abi_ulong, int); UNUSED static void print_timezone(abi_ulong, int); UNUSED static void print_number(abi_long, int); UNUSED static void print_signal(abi_ulong, int); -UNUSED static void print_sockaddr(abi_ulong addr, abi_long addrlen); +UNUSED static void print_sockaddr(abi_ulong addr, abi_long addrlen, int); UNUSED static void print_socket_domain(int domain); UNUSED static void print_socket_type(int type); UNUSED static void print_socket_protocol(int domain, int type, int protoco= l); @@ -336,7 +336,7 @@ static void print_siginfo(const target_siginfo_t *tinfo) } =20 static void -print_sockaddr(abi_ulong addr, abi_long addrlen) +print_sockaddr(abi_ulong addr, abi_long addrlen, int last) { struct target_sockaddr *sa; int i; @@ -418,7 +418,7 @@ print_sockaddr(abi_ulong addr, abi_long addrlen) } else { print_raw_param("0x"TARGET_ABI_FMT_lx, addr, 0); } - gemu_log(", "TARGET_ABI_FMT_ld, addrlen); + gemu_log(", "TARGET_ABI_FMT_ld"%s", addrlen, get_comma(last)); } =20 static void @@ -1666,7 +1666,7 @@ static void do_print_sockaddr(const char *name, abi_l= ong arg1) =20 gemu_log("%s(", name); print_sockfd(sockfd, 0); - print_sockaddr(addr, addrlen); + print_sockaddr(addr, addrlen, 0); gemu_log(")"); } =20 @@ -1736,7 +1736,7 @@ static void do_print_msgaddr(const char *name, abi_lo= ng arg1) print_buf(msg, len, 0); print_raw_param(TARGET_ABI_FMT_ld, len, 0); print_flags(msg_flags, flags, 0); - print_sockaddr(addr, addrlen); + print_sockaddr(addr, addrlen, 0); gemu_log(")"); } =20 --=20 2.19.1