From nobody Fri Nov 7 12:30:28 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 153909331924392.0658087561153; Tue, 9 Oct 2018 06:55:19 -0700 (PDT) Received: from localhost ([::1]:51696 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g9sTl-0003PY-Ve for importer@patchew.org; Tue, 09 Oct 2018 09:55:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49286) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g9rnB-0004Hg-Ro for qemu-devel@nongnu.org; Tue, 09 Oct 2018 09:11:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g9rn0-0000VH-1o for qemu-devel@nongnu.org; Tue, 09 Oct 2018 09:11:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36472) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g9rmz-0000Un-PV for qemu-devel@nongnu.org; Tue, 09 Oct 2018 09:11:05 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B2A7A4024F; Tue, 9 Oct 2018 13:11:04 +0000 (UTC) Received: from diego.redhat.com (unknown [10.40.205.140]) by smtp.corp.redhat.com (Postfix) with ESMTP id B88FB672E2; Tue, 9 Oct 2018 13:10:59 +0000 (UTC) From: =?UTF-8?q?Luk=C3=A1=C5=A1=20Hr=C3=A1zk=C3=BD?= To: spice-devel@lists.freedesktop.org, qemu-devel@nongnu.org Date: Tue, 9 Oct 2018 15:10:51 +0200 Message-Id: <20181009131052.18500-2-lhrazky@redhat.com> In-Reply-To: <20181009131052.18500-1-lhrazky@redhat.com> References: <20181009131052.18500-1-lhrazky@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 09 Oct 2018 13:11:04 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-Mailman-Approved-At: Tue, 09 Oct 2018 09:45:57 -0400 Subject: [Qemu-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kraxel@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RDMRC_1 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Adds two functions to let QEMU provide information to identify graphics devices and their monitors in the guest: * device path - The path identifying the device on the system (e.g. PCI path): spice_qxl_device_set_path(...) * device display ID - The index of the monitor on the graphics device: spice_qxl_device_monitor_add_display_id(...) Signed-off-by: Luk=C3=A1=C5=A1 Hr=C3=A1zk=C3=BD --- server/red-qxl.c | 67 ++++++++++++++++++++++++++++++++++++++++ server/spice-qxl.h | 3 ++ server/spice-server.syms | 6 ++++ 3 files changed, 76 insertions(+) diff --git a/server/red-qxl.c b/server/red-qxl.c index 97940611..143228ca 100644 --- a/server/red-qxl.c +++ b/server/red-qxl.c @@ -41,6 +41,9 @@ #include "red-qxl.h" =20 =20 +#define MAX_PATH_LEN 256 +#define MAX_MONITORS_COUNT 16 + struct QXLState { QXLWorker qxl_worker; QXLInstance *qxl; @@ -53,6 +56,9 @@ struct QXLState { unsigned int max_monitors; RedsState *reds; RedWorker *worker; + char device_path[MAX_PATH_LEN]; + uint32_t device_display_ids[MAX_MONITORS_COUNT]; + size_t monitors_count; // length of ^^^ =20 pthread_mutex_t scanout_mutex; SpiceMsgDisplayGlScanoutUnix scanout; @@ -846,6 +852,67 @@ void red_qxl_gl_draw_async_complete(QXLInstance *qxl) red_qxl_async_complete(qxl, cookie); } =20 +/** + * spice_qxl_device_set_path: + * @instance the QXL instance to set the path to + * @device_path the path of the device this QXL instance belongs to + * + * Sets the hardware (e.g. PCI) path of the graphics device represented by= this QXL interface instance. + * + */ +SPICE_GNUC_VISIBLE +void spice_qxl_device_set_path(QXLInstance *instance, const char *device_p= ath) +{ + g_return_if_fail(device_path !=3D NULL); + + size_t dp_len =3D strnlen(device_path, MAX_PATH_LEN); + if (dp_len >=3D MAX_PATH_LEN) { + spice_error("PCI device path too long: %lu > %u", dp_len, MAX_PATH= _LEN); + return; + } + + strncpy(instance->st->device_path, device_path, MAX_PATH_LEN); + + g_debug("QXL Instance %d setting device PCI path \"%s\"", instance->id= , device_path); +} + +/** + * spice_qxl_device_monitor_add_display_id: + * @instance the QXL instance to add the display ID to + * @device_display_id the display ID to add to the QXL instance + * + * Adds a #device_display_id to this QXL interface instance. The + * #device_display_id is an index (a sequence starting from 0) into the li= st of + * all the displays on the graphics device. This function should be called= in + * sequence for all possible displays of the device. The ID of the first c= all + * will belong to #monitor_id 0, and so forth in the sequence. + * + * Since for some graphics devices (e.g. virtio-gpu) a QXL interface insta= nce + * is created per each display of a single device, you can get e.g. the si= ngle + * following call on the third QXL interface instance for this device: + * + * spice_qxl_device_monitor_add_display_id(instance, 2); + * + * This tells you that the single monitor of this QXL interface actually + * belongs to the 3rd display of the underlying device. + * + * Returns: The actual SPICE server monitor_id associated with the display + */ +SPICE_GNUC_VISIBLE +int spice_qxl_device_monitor_add_display_id(QXLInstance *instance, uint32_= t device_display_id) +{ + if (instance->st->monitors_count >=3D MAX_MONITORS_COUNT) { + spice_error("Cannot register more than %u monitors per QXL interfa= ce", MAX_MONITORS_COUNT); + return -1; + } + + instance->st->device_display_ids[instance->st->monitors_count] =3D dev= ice_display_id; + + g_debug("QXL Instance %d adding device display ID %u", instance->id, d= evice_display_id); + + return instance->st->monitors_count++; +} + void red_qxl_init(RedsState *reds, QXLInstance *qxl) { QXLState *qxl_state; diff --git a/server/spice-qxl.h b/server/spice-qxl.h index 0c4e75fc..ae2d5975 100644 --- a/server/spice-qxl.h +++ b/server/spice-qxl.h @@ -114,6 +114,9 @@ void spice_qxl_gl_draw_async(QXLInstance *instance, uint32_t x, uint32_t y, uint32_t w, uint32_t h, uint64_t cookie); +/* since spice 0.14.2 */ +void spice_qxl_device_set_path(QXLInstance *instance, const char *device_p= ath); +int spice_qxl_device_monitor_add_display_id(QXLInstance *instance, uint32_= t device_display_id); =20 typedef struct QXLDevInitInfo { uint32_t num_memslots_groups; diff --git a/server/spice-server.syms b/server/spice-server.syms index edf04a42..fdeafd23 100644 --- a/server/spice-server.syms +++ b/server/spice-server.syms @@ -173,3 +173,9 @@ SPICE_SERVER_0.13.2 { global: spice_server_set_video_codecs; } SPICE_SERVER_0.13.1; + +SPICE_SERVER_0.14.2 { +global: + spice_qxl_device_set_path; + spice_qxl_device_monitor_add_display_id; +} SPICE_SERVER_0.13.2; --=20 2.19.1