From nobody Thu Nov 6 01:32:26 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1538886884062726.105071232373; Sat, 6 Oct 2018 21:34:44 -0700 (PDT) Received: from localhost ([::1]:41121 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g90m8-0000FL-Mt for importer@patchew.org; Sun, 07 Oct 2018 00:34:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g90lG-0008Nc-BV for qemu-devel@nongnu.org; Sun, 07 Oct 2018 00:33:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g90lB-0002N7-RB for qemu-devel@nongnu.org; Sun, 07 Oct 2018 00:33:46 -0400 Received: from m12-11.163.com ([220.181.12.11]:34711) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g90lB-0002JK-00 for qemu-devel@nongnu.org; Sun, 07 Oct 2018 00:33:41 -0400 Received: from ubuntu.localdomain (unknown [183.159.200.5]) by smtp7 (Coremail) with SMTP id C8CowAD303SgjLlbi12FDA--.23021S2; Sun, 07 Oct 2018 12:33:37 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=BR28F58puqR/7x+0Ms eiJvyacW8+RLa00G5iSjtm4Z8=; b=ebfKw0wIpNfdXJf6GKAX11xbkeKWMbmwLX cpDCuS0B2rM8d53XOYq5Y3mIqbGeb84BQDD57Mqzi4EXPWEtlQkRXIO1Am5YC/oZ XAa5jZCAzPtoF0FF3P7enrlgMIoLoE5scCsjTLSoyviEZJrmV1wzN6J/NRZPLirk U89qvBaP8= From: Li Qiang To: pbonzini@redhat.com Date: Sat, 6 Oct 2018 21:33:35 -0700 Message-Id: <20181007043335.23631-1-liq3ea@163.com> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: C8CowAD303SgjLlbi12FDA--.23021S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7JFW5GF18JF1DWr13Jr45GFg_yoW3JFX_Ca 4vqw18uw4DZFy3ZFn7Ars0va4IgayDZFs3X34fKayayF1UJw4aqrs2qrZ5JrWfuw47KrZx t34kZwnxJFn7ujkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUjrWFUUUUUU== X-Originating-IP: [183.159.200.5] X-CM-SenderInfo: 5oltjvrd6rljoofrz/1tbiTwHYbVsGMSYxEwAAsT X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 220.181.12.11 Subject: [Qemu-devel] [PATCH] vl.c: print error message if load fw_cfg file failed X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Li Qiang , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" It makes sense to print the error message while reading file failed. Signed-off-by: Li Qiang Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- vl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index cc55fe04a2..3db410e771 100644 --- a/vl.c +++ b/vl.c @@ -2207,8 +2207,9 @@ static int parse_fw_cfg(void *opaque, QemuOpts *opts,= Error **errp) size =3D strlen(str); /* NUL terminator NOT included in fw_cfg blo= b */ buf =3D g_memdup(str, size); } else { - if (!g_file_get_contents(file, &buf, &size, NULL)) { - error_report("can't load %s", file); + GError *error =3D NULL; + if (!g_file_get_contents(file, &buf, &size, &error)) { + error_report("can't load %s, %s", file, error->message); return -1; } } --=20 2.17.1