From nobody Thu Nov 6 01:36:06 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 15387512143461000.3205796366575; Fri, 5 Oct 2018 07:53:34 -0700 (PDT) Received: from localhost ([::1]:35516 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g8RTn-0005Bs-PZ for importer@patchew.org; Fri, 05 Oct 2018 10:53:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g8RSh-0004K8-E8 for qemu-devel@nongnu.org; Fri, 05 Oct 2018 10:52:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g8RSc-0005E5-Kp for qemu-devel@nongnu.org; Fri, 05 Oct 2018 10:52:15 -0400 Received: from fanzine.igalia.com ([91.117.99.155]:45258) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g8RSZ-0005BJ-Ql; Fri, 05 Oct 2018 10:52:08 -0400 Received: from [192.168.12.179] (helo=perseus.local) by fanzine.igalia.com with esmtpsa (Cipher TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim) id 1g8RSW-0008FJ-DK; Fri, 05 Oct 2018 16:52:04 +0200 Received: from berto by perseus.local with local (Exim 4.89) (envelope-from ) id 1g8RSW-00025q-8I; Fri, 05 Oct 2018 17:52:04 +0300 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Message-Id:Date:Subject:Cc:To:From; bh=nJUmDo0yVZ1IAzeXW5stBH0Dx/Gr9YURbfrEr++QWR0=; b=l2igbbfSytOUt1XKFkgeWv/HO3lUbIsedyTHcwaxro2qaZYsEizevyjeVGL28TndfXGx6HiYkZn4CuK8clZ92WOMPCMf2wPhEHhwuT0t6mQ63J4iHyEWp+9EgR2o1PrcTNwd1wakAdNySyxyizjE2jJBmXCovEz9m9RvMJ5SZMoCOctubQK+rwnKX5rlSHVHU9hoc/jDgliEmyj4qWrr5tWV283t3IiaDd51ZIE/R8hDHWRQOCLmVUT+v/hHIV+cdL6BQlNp7dGrhDY/UAFGTp+X5x9oVz+FLPKaP961skeuiEUhsuvQhgy6WXcO81wTKCsIU9Y6tHf/uSPbIkt4Jw==; From: Alberto Garcia To: qemu-devel@nongnu.org Date: Fri, 5 Oct 2018 16:52:02 +0200 Message-Id: <20181005145202.8005-1-berto@igalia.com> X-Mailer: git-send-email 2.11.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 91.117.99.155 Subject: [Qemu-devel] [PATCH] crypto: Fix defaults in QCryptoBlockCreateOptionsLUKS X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alberto Garcia , qemu-block@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The values specified in the documentation don't match the actual defaults set in qcrypto_block_luks_create(). Signed-off-by: Alberto Garcia Reviewed-by: Daniel P. Berrang=C3=A9 --- qapi/crypto.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qapi/crypto.json b/qapi/crypto.json index a51b434412..b2a4cff683 100644 --- a/qapi/crypto.json +++ b/qapi/crypto.json @@ -181,11 +181,11 @@ # The options that apply to LUKS encryption format initialization # # @cipher-alg: the cipher algorithm for data encryption -# Currently defaults to 'aes'. +# Currently defaults to 'aes-256'. # @cipher-mode: the cipher mode for data encryption -# Currently defaults to 'cbc' +# Currently defaults to 'xts' # @ivgen-alg: the initialization vector generator -# Currently defaults to 'essiv' +# Currently defaults to 'plain64' # @ivgen-hash-alg: the initialization vector generator hash # Currently defaults to 'sha256' # @hash-alg: the master key hash algorithm --=20 2.11.0